/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure garbage collector will collect all the VMs object and QubesDB/libvirt connections #1697

Closed
marmarek opened this Issue Jan 26, 2016 · 0 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Release 4.0
1 participant
@marmarek
@marmarek
Member

marmarek commented Jan 26, 2016

Related to #1380

@marmarek marmarek added C: core P: major task labels Jan 26, 2016

@marmarek marmarek added this to the Release 4.0 milestone Jan 26, 2016

@marmarek marmarek changed the title from Make sure garbage collector will collect all the VMs object and QubesDB connections to Make sure garbage collector will collect all the VMs object and QubesDB/libvirt connections Feb 10, 2016

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Feb 10, 2016

@marmarek
Move libvirt_conn.close to object destructor 
Process exit is too late for long-running processes. Especially tests,
which create a lot of such objects which leads to depleting all
the file descriptors.

QubesOS/qubes-issues#1697
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
fe76233

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Feb 10, 2016

@marmarek
core/log: do not attach multiple handlers to the same logger 
logging.getLogger when given the same name twice, will return the same
object. Do not attach handler there every time, it will really open new
file, leading to multiplicated log entries and depleting file
descriptors.

QubesOS/qubes-issues#1697
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
4cc3122

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Feb 10, 2016

@marmarek
tests: few more FD leak fixes 
QubesOS/qubes-issues#1697
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
0bc171f

woju added a commit to woju/qubes-core-admin that referenced this issue Feb 29, 2016

@marmarek @woju
Move libvirt_conn.close to object destructor 
Process exit is too late for long-running processes. Especially tests,
which create a lot of such objects which leads to depleting all
the file descriptors.

QubesOS/qubes-issues#1697
77daf8a

woju added a commit to woju/qubes-core-admin that referenced this issue Feb 29, 2016

@marmarek @woju
core/log: do not attach multiple handlers to the same logger 
logging.getLogger when given the same name twice, will return the same
object. Do not attach handler there every time, it will really open new
file, leading to multiplicated log entries and depleting file
descriptors.

QubesOS/qubes-issues#1697
0c1cb84

woju added a commit to woju/qubes-core-admin that referenced this issue Feb 29, 2016

@marmarek @woju
tests: few more FD leak fixes 
QubesOS/qubes-issues#1697
5323309

woju added a commit to woju/qubes-core-admin that referenced this issue Mar 3, 2016

@marmarek @woju
Move libvirt_conn.close to object destructor 
Process exit is too late for long-running processes. Especially tests,
which create a lot of such objects which leads to depleting all
the file descriptors.

QubesOS/qubes-issues#1697
01a6a13

woju added a commit to woju/qubes-core-admin that referenced this issue Mar 3, 2016

@marmarek @woju
core/log: do not attach multiple handlers to the same logger 
logging.getLogger when given the same name twice, will return the same
object. Do not attach handler there every time, it will really open new
file, leading to multiplicated log entries and depleting file
descriptors.

QubesOS/qubes-issues#1697
2359050

woju added a commit to woju/qubes-core-admin that referenced this issue Mar 3, 2016

@marmarek @woju
tests: few more FD leak fixes 
QubesOS/qubes-issues#1697
a82bd8a

woju added a commit to woju/qubes-core-admin that referenced this issue Mar 3, 2016

@marmarek @woju
Move libvirt_conn.close to object destructor 
Process exit is too late for long-running processes. Especially tests,
which create a lot of such objects which leads to depleting all
the file descriptors.

QubesOS/qubes-issues#1697
9299231

woju added a commit to woju/qubes-core-admin that referenced this issue Mar 3, 2016

@marmarek @woju
core/log: do not attach multiple handlers to the same logger 
logging.getLogger when given the same name twice, will return the same
object. Do not attach handler there every time, it will really open new
file, leading to multiplicated log entries and depleting file
descriptors.

QubesOS/qubes-issues#1697
539a46c

@marmarek marmarek closed this in marmarek/qubes-core-admin@0a45164 May 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment