/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on units used in memory-related properties #1737

Open
marmarek opened this Issue Feb 10, 2016 · 3 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Release 4.1
4 participants
@marmarek @bnvk @woju @andrewdavidwong
@marmarek
Member

marmarek commented Feb 10, 2016

Currently there is a big mess. Some of them uses MB (vm.memory, vm.maxmem), some bytes (host.memory_total). And I think I saw KB somewhere too.
I vote for MB everywhere.

@marmarek marmarek added C: core P: minor task labels Feb 10, 2016

@marmarek marmarek added this to the Release 4.0 milestone Feb 10, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 10, 2016

Member

Found KB - host.memory_total, despite of comment saying it's in bytes...
Member

marmarek commented Feb 10, 2016

Found KB - host.memory_total, despite of comment saying it's in bytes...

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Feb 10, 2016

@marmarek
core: move maxmem default initialization to property itself 
Also fix (for now?) units - memory_total is int bytes while maxmem in
megabytes.

QubesOS/qubes-issues#1737
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
b394688

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Feb 10, 2016

@marmarek
core: adjust units comment for host.memory_total, and fix related places 
QubesOS/qubes-issues#1737
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
8deddc0
@bnvk

This comment has been minimized.

Show comment
Hide comment
@bnvk

bnvk Feb 17, 2016

👍 for MB, it is the most commonly understood data measurement size (based on an unofficial poll).

bnvk commented Feb 17, 2016

👍 for MB, it is the most commonly understood data measurement size (based on an unofficial poll).
@woju

This comment has been minimized.

Show comment
Hide comment
@woju

woju Feb 18, 2016

Member
Member

woju commented Feb 18, 2016

woju added a commit to woju/qubes-core-admin that referenced this issue Feb 29, 2016

@marmarek @woju
core: move maxmem default initialization to property itself 
Also fix (for now?) units - memory_total is int bytes while maxmem in
megabytes.

QubesOS/qubes-issues#1737
4af074a

woju added a commit to woju/qubes-core-admin that referenced this issue Feb 29, 2016

@marmarek @woju
core: adjust units comment for host.memory_total, and fix related places 
QubesOS/qubes-issues#1737
39a2929

woju added a commit to woju/qubes-core-admin that referenced this issue Mar 3, 2016

@marmarek @woju
core: move maxmem default initialization to property itself 
Also fix (for now?) units - memory_total is int bytes while maxmem in
megabytes.

QubesOS/qubes-issues#1737
5c60787

woju added a commit to woju/qubes-core-admin that referenced this issue Mar 3, 2016

@marmarek @woju
core: adjust units comment for host.memory_total, and fix related places 
QubesOS/qubes-issues#1737
cd2758e

woju added a commit to woju/qubes-core-admin that referenced this issue Mar 3, 2016

@marmarek @woju
core: move maxmem default initialization to property itself 
Also fix (for now?) units - memory_total is int bytes while maxmem in
megabytes.

QubesOS/qubes-issues#1737
62759fb

woju added a commit to woju/qubes-core-admin that referenced this issue Mar 3, 2016

@marmarek @woju
core: adjust units comment for host.memory_total, and fix related places 
QubesOS/qubes-issues#1737
9633573

@andrewdavidwong andrewdavidwong modified the milestones: Release 4.0, Release 4.1 Mar 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment