New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design libvirt xml template search paths #1798

Closed
marmarek opened this Issue Mar 2, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@marmarek
Member

marmarek commented Mar 2, 2016

Allow overriding default template (xen.xml) with user-provided one (/etc/qubes/templates?). Also allow override it per-VM.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Oct 6, 2016

Member

AFAIR there was a reason why VM directory (/var/lib/qubes/appvms/some-name) cannot be used. @woju can you post it here for reference?

Member

marmarek commented Oct 6, 2016

AFAIR there was a reason why VM directory (/var/lib/qubes/appvms/some-name) cannot be used. @woju can you post it here for reference?

@woju

This comment has been minimized.

Show comment
Hide comment
@woju

woju Oct 6, 2016

Member

On Thu, Oct 06, 2016 at 10:37:02AM -0700, Marek Marczykowski-Górecki wrote:

AFAIR there was a reason why VM directory (/var/lib/qubes/appvms/some-name)
cannot be used. @woju can you post it here for reference?

I don't recall why you can't use /var/lib/qubes. But there is a reason for
using /etc: if you have single override file [1], you can write some logic
like {% if vm.<property> = '<value>' %} that applies to more than 1 domain.
It can't be done with per-vm templates.

So I did per-vm templates also in /etc mainly for consistency.

[1](currently /etc/qubes/templates/libvirt/xen-user.xml, though I'm not
attached to it)

pozdrawiam / best regards .-.
Wojtek Porczyk .-^' '^-.
Invisible Things Lab |'-.-^-.-'|
| | | |
I do not fear computers, | '-.-' |
I fear lack of them. '-._ : ,-'
-- Isaac Asimov `^-^-_>

Member

woju commented Oct 6, 2016

On Thu, Oct 06, 2016 at 10:37:02AM -0700, Marek Marczykowski-Górecki wrote:

AFAIR there was a reason why VM directory (/var/lib/qubes/appvms/some-name)
cannot be used. @woju can you post it here for reference?

I don't recall why you can't use /var/lib/qubes. But there is a reason for
using /etc: if you have single override file [1], you can write some logic
like {% if vm.<property> = '<value>' %} that applies to more than 1 domain.
It can't be done with per-vm templates.

So I did per-vm templates also in /etc mainly for consistency.

[1](currently /etc/qubes/templates/libvirt/xen-user.xml, though I'm not
attached to it)

pozdrawiam / best regards .-.
Wojtek Porczyk .-^' '^-.
Invisible Things Lab |'-.-^-.-'|
| | | |
I do not fear computers, | '-.-' |
I fear lack of them. '-._ : ,-'
-- Isaac Asimov `^-^-_>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment