/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qrexec service should be able to return stderr in addition to stdout #1808

Closed
marmarek opened this Issue Mar 5, 2016 · 0 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Release 3.2
1 participant
@marmarek
@marmarek
Member

marmarek commented Mar 5, 2016

In case of some services it makes much sense for caller to receive also
stderr in addition to stdout. For example:

  • qubes.VMShell (stderr required for salt-ssh over qrexec)
  • qubes.OpenInVM - especially when called to DispVM - otherwise
    diagnosing errors can be hard (and logs are lost after destruction of DispVM)

Generally all sort of error reporting (the purpose of stderr). It would ease debugging - instead of message "error occurred, check here and there for more details", it could be "error occurred: the reason".

@marmarek marmarek added enhancement C: core P: major release-notes labels Mar 5, 2016

@marmarek marmarek added this to the Release 3.2 milestone Mar 5, 2016

marmarek added a commit to marmarek/old-qubes-core-agent-linux that referenced this issue Mar 5, 2016

@marmarek
qrexec: write service stderr to both syslog and caller 
In case of some services it makes much sense for caller to receive also
stderr in addition to stdout. For example:
 - qubes.VMShell (stderr required for salt-ssh over qrexec)
 - qubes.OpenInVM - especially when called to DispVM - otherwise
 diagnosing errors can be hard

And generally all sort of error reporting (the purpose of stderr). It
would ease debugging - instead of message "error occurred, check here and
there for more details", it could be "error occurred: the reason".

Fixes QubesOS/qubes-issues#1808
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
b267e5c

This was referenced Mar 5, 2016

Merged
Closed

@marmarek marmarek closed this in marmarek/old-qubes-core-agent-linux#63 Mar 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment