Fix heading spacing

[bnvk]

A change introduced to the SASS this morning now causes this

I've figured out the issue, it was specifically, this commit made earlier today. What were you trying to achieve @axon-qubes ?

[andrewdavidwong]

Thank you to you and @mfc for spotting this and pointing it out. I've just reverted that commit.

I mentioned in my commit message what I was trying to achieve. To quote:

Fix heading spacing

Makes it so that each paragraph heading is closer to its own paragraph than to the previous paragraph.

Here's a screenshot of what I mean:

See how each paragraph heading is noticeably closer to the previous paragraph than to its own paragraph? (Might be easier to see on text-only pages, but it's evident on any page with headings and paragraphs.) I was just trying to fix that. I checked every type of page except the front page, and they all looked better, but it was my fault for not checking the front page.

Evidently my approach will not work, so would you mind taking a stab at it, @bnvk?

[andrewdavidwong]

Thank you to you and @mfc for spotting this and pointing it out. I've just reverted that commit.

I mentioned in my commit message what I was trying to achieve. To quote:

Fix heading spacing

Makes it so that each paragraph heading is closer to its own paragraph than to the previous paragraph.

Here's a screenshot of what I mean:

See how each paragraph heading is noticeably closer to the previous paragraph than to its own paragraph? (Might be easier to see on text-only pages, but it's evident on any page with headings and paragraphs.) I was just trying to fix that. I checked every type of page except the front page, and they all looked better, but it was my fault for not checking the front page.

Evidently my approach will not work, so would you mind taking a stab at it, @bnvk?

[bnvk]

Fix heading spacing

Makes it so that each paragraph heading is closer to its own paragraph than to the previous paragraph.

Yah, I saw that commit message, but the .white-box class is something that creates the large white "background" boxes for the whole site, hence why it broke the layouts!

Yah, those margins between the titles was something that got screwed up in the merge, as there is supposed to be <hr class="more-top more-bottom"> anywho, I just sent a pull-req for that!

[bnvk]

Fix heading spacing

Makes it so that each paragraph heading is closer to its own paragraph than to the previous paragraph.

Yah, I saw that commit message, but the .white-box class is something that creates the large white "background" boxes for the whole site, hence why it broke the layouts!

Yah, those margins between the titles was something that got screwed up in the merge, as there is supposed to be <hr class="more-top more-bottom"> anywho, I just sent a pull-req for that!

[andrewdavidwong]

Yah, I saw that commit message, but the .white-boxe class is something that creates the large white "background" boxes for the whole site, hence why it broke the layouts!

I know, but we need some way to create proper spacing between sections without pushing the very first heading down (hence the negative margin).

Yah, those margins between the titles was something that got screwed up in the merge, as there is supposed to be <hr class="more-top more-bottom"> anywho, I just sent a pull-req for that!

Actually, the problem was there before that merge, and it's back again now. Another screenshot to illustrate:

[andrewdavidwong]

Yah, I saw that commit message, but the .white-boxe class is something that creates the large white "background" boxes for the whole site, hence why it broke the layouts!

I know, but we need some way to create proper spacing between sections without pushing the very first heading down (hence the negative margin).

Yah, those margins between the titles was something that got screwed up in the merge, as there is supposed to be <hr class="more-top more-bottom"> anywho, I just sent a pull-req for that!

Actually, the problem was there before that merge, and it's back again now. Another screenshot to illustrate:

[andrewdavidwong]

As @mfc has pointed out in #1869, the problem is even more pronounced when viewing certain pages on "narrow" screens (even ones which aren't that narrow). Example:

[andrewdavidwong]

As @mfc has pointed out in #1869, the problem is even more pronounced when viewing certain pages on "narrow" screens (even ones which aren't that narrow). Example:

[bnvk]

Fxed this with recent commit. @axon-qubes feel free to verify if ya dig!

[bnvk]

Fxed this with recent commit. @axon-qubes feel free to verify if ya dig!

[andrewdavidwong]

The spacing of regular text headings look better, but the heading issue from this screenshot looks unchanged.

[andrewdavidwong]

The spacing of regular text headings look better, but the heading issue from this screenshot looks unchanged.

[bnvk]

@axon-qubes yah that's an issue with Bootstraps CSS grid and making it properly responsive. This is being tracked in #1869 thanks ;)

[bnvk]

@axon-qubes yah that's an issue with Bootstraps CSS grid and making it properly responsive. This is being tracked in #1869 thanks ;)