/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colon (:) to trusted characters (for "Code::Blocks" appmenu) #1852

Closed
marmarek opened this Issue Mar 18, 2016 · 3 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Release 3.0 updates
1 participant
@marmarek
@marmarek
Member

marmarek commented Mar 18, 2016

Tracking issue for QubesOS/qubes-core-admin-linux#6 by @Galland

After installing "codeblocks" app in TemplateVM it doesn't appear in Qubes VM Manager's available app shortcuts.
If I run in a Dom0 Terminal: /usr/libexec/qubes-appmenus/qubes-receive-appmenus fedora-23
I get this: "Warning: ignoring key 'Name' of codeblocks.desktop"
The "Name" key in that file has value "Code::Blocks"

@marmarek marmarek added bug C: core P: minor UX labels Mar 18, 2016

@marmarek marmarek added this to the Release 3.0 updates milestone Mar 18, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 17, 2016

Member

Fixed in QubesOS/qubes-core-admin-linux@3acfb8e
Member

marmarek commented May 17, 2016

Fixed in QubesOS/qubes-core-admin-linux@3acfb8e

@marmarek marmarek closed this May 17, 2016

marmarek added a commit to QubesOS/qubes-core-admin-linux that referenced this issue May 17, 2016

@Galland @marmarek
Add colon (:) to trusted characters (for "Code::Blocks" appmenu) 
After installing "codeblocks" app in TemplateVM it doesn't appear in Qubes VM Manager's available app shortcuts.
If I run in a Dom0 Terminal: /usr/libexec/qubes-appmenus/qubes-receive-appmenus fedora-23
I get this: "Warning: ignoring key 'Name' of codeblocks.desktop"
The "Name" key in that file has value "Code::Blocks"

The problem comes from line 168, because of the colons in the app Name.

By adding the colon ":" to the std_re used to match valid characters for "Name", the app is correctly parsed and I can add the shortcut to AppVMs
(cherry picked from commit 3acfb8e)
Notes from origin:
    Fixes QubesOS/qubes-issues#1852
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
a0a2af3
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 17, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.1.11-1.fc20 has been pushed to the r3.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update
Member

marmarek commented May 17, 2016

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.1.11-1.fc20 has been pushed to the r3.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@marmarek marmarek added the r3.1-dom0-cur-test label May 17, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 25, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.1.12-1.fc20 has been pushed to the r3.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update
Member

marmarek commented Jul 25, 2016

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.1.12-1.fc20 has been pushed to the r3.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@marmarek marmarek added r3.1-dom0-stable and removed r3.1-dom0-cur-test labels Jul 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment