/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean vm.run* functions #1900

Closed
woju opened this Issue Apr 11, 2016 · 0 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Release 4.0
1 participant
@woju
@woju
Member

woju commented Apr 11, 2016

vm.run() and vm.run_service() functions are hairy. They should be separated to return one type (retcode or pipe or ...). This is currently done via passio* arguments, not separate functions.

@marmarek

@woju woju added the C: core label Apr 11, 2016

@woju woju added this to the Release 4.0 milestone Apr 11, 2016

woju added a commit to woju/qubes-core-admin that referenced this issue Apr 5, 2017

@woju
qubes/vm/qubesvm: rework QubesVM.run*() methods 
0) All those methods are now awaitable rather than synchronous.

1) The base method is run_service(). The method run() was rewritten
   using run_service('qubes.VMShell', input=...). There is no provision
   for running plain commands.

2) Get rid of passio*= arguments. If you'd like to get another return
   value, use another method. It's as simple as that.
   See:
      - run_service_for_stdio()
      - run_for_stdio()

   Also gone are wait= and localcmd= arguments. They are of no use
   inside qubesd.

3) The qvm-run tool and tests are left behind for now and will be fixed
   later. This is because they also need event loop, which is not
   implemented yet.

fixes QubesOS/qubes-issues#1900
QubesOS/qubes-issues#2622
ad59885

woju added a commit to woju/qubes-core-admin that referenced this issue Apr 5, 2017

@woju
qubes/vm/qubesvm: rework QubesVM.run*() methods 
0) All those methods are now awaitable rather than synchronous.

1) The base method is run_service(). The method run() was rewritten
   using run_service('qubes.VMShell', input=...). There is no provision
   for running plain commands.

2) Get rid of passio*= arguments. If you'd like to get another return
   value, use another method. It's as simple as that.
   See:
      - run_service_for_stdio()
      - run_for_stdio()

   Also gone are wait= and localcmd= arguments. They are of no use
   inside qubesd.

3) The qvm-run tool and tests are left behind for now and will be fixed
   later. This is because they also need event loop, which is not
   implemented yet.

fixes QubesOS/qubes-issues#1900
QubesOS/qubes-issues#2622
ff418ed

@woju woju closed this in woju/qubes-core-admin@78693c2 Apr 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment