Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix pages with multiple h1 headings #1914
Comments
andrewdavidwong
added
bug
P: minor
C: website
labels
Apr 18, 2016
andrewdavidwong
added this to the
Documentation/website milestone
Apr 18, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bnvk
Apr 18, 2016
This relates to the same jQuery plugin as #1713 However, in this case, I believe the plugin explicitly ignores h1 headings as those are supposed to be the page heading and not repeated throughout the content.
Thus, I believe the right approach here is to Convert h1 in doc pages to h2, h3 tags rather than modify the plugin. Is that something you are up to doing @axon-qubes ?
bnvk
commented
Apr 18, 2016
|
This relates to the same jQuery plugin as #1713 However, in this case, I believe the plugin explicitly ignores Thus, I believe the right approach here is to Convert |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Apr 19, 2016
Member
Sure, not a problem. However, I don't know of a good way to find all the pages with duplicate h1s, so I can only fix it for this one page for now.
|
Sure, not a problem. However, I don't know of a good way to find all the pages with duplicate |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Apr 19, 2016
Member
(For all I know, this may be the only page that has duplicate h1s.)
|
(For all I know, this may be the only page that has duplicate |
andrewdavidwong
closed this
in
QubesOS/qubes-doc@dc4e146
Apr 19, 2016
added a commit
to QubesOS/qubesos.github.io
that referenced
this issue
Apr 19, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Apr 27, 2016
Member
I'm reopening this issue since we've come across at least one more page with multiple h1 headings (and since there are probably more out there), but I'm changing the title to reflect the decision made here.
|
I'm reopening this issue since we've come across at least one more page with multiple |
andrewdavidwong
reopened this
Apr 27, 2016
andrewdavidwong
changed the title from
Auto-ToC doesn't detect multiple h1s
to
Fix pages with multiple h1 headings
Apr 27, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
I'll just fix these as I come across them in the future. |
andrewdavidwong commentedApr 18, 2016
Here's an example page:
https://www.qubes-os.org/doc/copy-from-dom0/
There are two h1 headings on that page. The second one doesn't show up in the automatically-generated table of contents on the right (or bottom, if on mobile).