Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upqubes-hcl-report doesn't properly escape spaces in machine name #1994
Comments
marmarek
added
bug
P: minor
labels
May 16, 2016
marmarek
added this to the Release 3.0 updates milestone
May 16, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
unman
May 19, 2016
Member
What about this?
FILENAME="Qubes-HCL-${BRAND//[^[:alnum:]]/_}-${PRODUCT//[^[:alnum:]]/_}-$DATE"
|
What about this? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Yes, I have exactly this already committed, just not pushed yet. |
marmarek
self-assigned this
May 19, 2016
andrewdavidwong
added
the
C: other
label
May 19, 2016
marmarek
closed this
in
marmarek/old-qubes-core-admin@7c0f5a4
May 25, 2016
tomck
referenced this issue
in QubesOS/qubes-hcl
Jun 9, 2016
Merged
Add HCL report for Dell XPS L702X #2
marmarek
referenced this issue
Jun 20, 2016
Closed
qubes-hcl-report ambigious redirect no report creation #2087
added a commit
to QubesOS/qubes-core-admin
that referenced
this issue
Jun 25, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Jun 25, 2016
Member
Automated announcement from builder-github
The package qubes-core-dom0-3.1.17-1.fc20 has been pushed to the r3.1 testing repository for dom0.
To test this update, please install it with the following command:
sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing
|
Automated announcement from builder-github The package |
marmarek
added
the
r3.1-dom0-cur-test
label
Jun 25, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Jul 25, 2016
Member
Automated announcement from builder-github
The package qubes-core-dom0-3.1.17-1.fc20 has been pushed to the r3.1 stable repository for dom0.
To install this update, please use the standard update command:
sudo qubes-dom0-update
Or update dom0 via Qubes Manager.
|
Automated announcement from builder-github The package Or update dom0 via Qubes Manager. |
marmarek commentedMay 16, 2016
There is expression meant to replace non-alphanumeric characters with underscore, but apparently it doesn't work:
https://github.com/QubesOS/qubes-core-admin/blob/master/qvm-tools/qubes-hcl-report#L106
FILENAME="Qubes-HCL-${BRAND//+([^[:alnum:]])/_}-${PRODUCT//+([^[:alnum:]])/_}-$DATE"According to bash manual it should be ok. And it works on bash 4.3.42, but not on 4.2.53 which we have in dom0. Some bash bug?
Reported by picard