Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure qvm-remove and qvm-create do not run as root #200
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Modified by joanna on 6 Apr 2011 12:51 UTC |
marmarek
assigned
rootkovska
Mar 8, 2015
marmarek
added this to the Release 1 Beta 1 milestone
Mar 8, 2015
marmarek
added
bug
C: core
P: major
labels
Mar 8, 2015
marmarek
assigned
marmarek
and unassigned
rootkovska
Mar 8, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Modified by marmarek on 6 Apr 2011 13:00 UTC |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by marmarek on 6 Apr 2011 13:30 UTC
I cannot reproduce the issue...
How to reproduce this?
|
Comment by marmarek on 6 Apr 2011 13:30 UTC |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by joanna on 6 Apr 2011 13:32 UTC
Hmm... let me build a new ISO, install a new system and test then. Changing this to minor in the meanwile...
|
Comment by joanna on 6 Apr 2011 13:32 UTC |
marmarek
added
P: minor
and removed
P: major
labels
Mar 8, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by joanna on 6 Apr 2011 17:19 UTC
Ok, the problem occurs when the user runs qvm-remove as root instead of as user. Then xdg-desktop* uses incorrect patch (global ones instead of ~/.local). Similarly things break (even more) when user runs qvm-create as root.
We should add checking code at the beginning of those two tools (qvm-create and qvm-remove) and exit when run as root (and display a message), similarly as we do with qvm-backup-restore.
|
Comment by joanna on 6 Apr 2011 17:19 UTC We should add checking code at the beginning of those two tools (qvm-create and qvm-remove) and exit when run as root (and display a message), similarly as we do with qvm-backup-restore. |
marmarek
added
P: major
and removed
P: minor
labels
Mar 8, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Modified by joanna on 6 Apr 2011 17:20 UTC |
marmarek
changed the title from
qvm-remove doesn't remove appmenus
to
Ensure qvm-remove and qvm-create do not run as root
Mar 8, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by marmarek on 6 Apr 2011 21:54 UTC
http://git.qubes-os.org/gitweb/?p=marmarek/core.git;a=commit;h=c569d4070e40ad059555203cbc16ecfc09980c57
|
Comment by marmarek on 6 Apr 2011 21:54 UTC |
marmarek commentedMar 8, 2015
Reported by joanna on 6 Apr 2011 12:34 UTC
None
Migrated-From: https://wiki.qubes-os.org/ticket/200