New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package i3 window manager #2015

Closed
marmarek opened this Issue May 23, 2016 · 33 comments

Comments

Projects
None yet
4 participants
@marmarek
Member

marmarek commented May 23, 2016

Follow up from #1756 (comment)

If that really works, I think that's all. Next steps (on our side):

  • review and test it out
  • include in official repository

Related to QubesOS/qubes-doc#143

/cc @SietsevanderMolen @minad

@SietsevanderMolen

This comment has been minimized.

Show comment
Hide comment
@SietsevanderMolen

SietsevanderMolen May 23, 2016

After thinking about this some more, and looking at Qubes' XFCE package, I think it's a good idea to package some sort of default configuration. I previously didn't want to do this because i3's config gets written on the fly, but I think I can make it generate a Qubes specific one instead fairly easily. A default configuration will make it integrate much better with Qubes, and should be easy enough with the scripts I already made with @minad. I'll make a proof of concept now.

After thinking about this some more, and looking at Qubes' XFCE package, I think it's a good idea to package some sort of default configuration. I previously didn't want to do this because i3's config gets written on the fly, but I think I can make it generate a Qubes specific one instead fairly easily. A default configuration will make it integrate much better with Qubes, and should be easy enough with the scripts I already made with @minad. I'll make a proof of concept now.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 23, 2016

Member

I guess it will include steps described in documentation you've written?

If possible, better do this with separate package (as in xfce) - will be easier to maintain, upgrade etc.

Member

marmarek commented May 23, 2016

I guess it will include steps described in documentation you've written?

If possible, better do this with separate package (as in xfce) - will be easier to maintain, upgrade etc.

@SietsevanderMolen

This comment has been minimized.

Show comment
Hide comment
@SietsevanderMolen

SietsevanderMolen May 23, 2016

Yes, it will be exactly that. I'll make a separate package for it, like https://github.com/QubesOS/qubes-desktop-linux-xfce4/tree/master/xfce4-settings-qubes.

Yes, it will be exactly that. I'll make a separate package for it, like https://github.com/QubesOS/qubes-desktop-linux-xfce4/tree/master/xfce4-settings-qubes.

marmarek added a commit to marmarek/qubes-desktop-linux-i3 that referenced this issue May 23, 2016

Improve integration with qubes-builder
Set _sourcedir for building directly from qubes-builder (it does not use
Makefile in the main directory).

QubesOS/qubes-issues#2015

marmarek added a commit to marmarek/qubes-desktop-linux-i3 that referenced this issue May 23, 2016

marmarek added a commit to marmarek/qubes-desktop-linux-i3 that referenced this issue May 23, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 23, 2016

Member

I've already reviewed it and tested - generally looks ok, as it it targeted at advanced users, it may be good enough even in the current state.
Improvements to consider:

  • Qubes 3.1 dom0 (fc20) does not support Recommends: dependency. Consider a separate package (may be that with Qubes-specific settings) with appropriate Requires:. Or wait with this until Qubes 3.2 (with fc23 based dom0)
  • package with Qubes-specific settings (as you've already noted above)

Slightly patched version (mostly build improvements): https://github.com/marmarek/qubes-desktop-linux-i3/tree/master

Member

marmarek commented May 23, 2016

I've already reviewed it and tested - generally looks ok, as it it targeted at advanced users, it may be good enough even in the current state.
Improvements to consider:

  • Qubes 3.1 dom0 (fc20) does not support Recommends: dependency. Consider a separate package (may be that with Qubes-specific settings) with appropriate Requires:. Or wait with this until Qubes 3.2 (with fc23 based dom0)
  • package with Qubes-specific settings (as you've already noted above)

Slightly patched version (mostly build improvements): https://github.com/marmarek/qubes-desktop-linux-i3/tree/master

@minad

This comment has been minimized.

Show comment
Hide comment
@minad

minad May 23, 2016

@marmarek @SietsevanderMolen Maybe we should add a patch to i3 which changes the following things in the auto-generated .i3/config:

  • Use dmenu-desktop
  • Add a line exec ~/.i3/qubes-autostart
  • Use ~/.i3/qubes-terminal instead of i3-sensible-terminal
  • Use ~/.i3/qubes-status instead of i3status

Then we could create a package i3-qubes-settings which includes ~/.i3/qubes-autostart, ~/.i3/qubes-terminal and ~/.i3/qubes-status

minad commented May 23, 2016

@marmarek @SietsevanderMolen Maybe we should add a patch to i3 which changes the following things in the auto-generated .i3/config:

  • Use dmenu-desktop
  • Add a line exec ~/.i3/qubes-autostart
  • Use ~/.i3/qubes-terminal instead of i3-sensible-terminal
  • Use ~/.i3/qubes-status instead of i3status

Then we could create a package i3-qubes-settings which includes ~/.i3/qubes-autostart, ~/.i3/qubes-terminal and ~/.i3/qubes-status

@SietsevanderMolen

This comment has been minimized.

Show comment
Hide comment
@SietsevanderMolen

SietsevanderMolen May 23, 2016

I think all of that should be in i3-qubes-settings, which is what I'm doing right now. The autogenerated config is based on a config that I can just swap out after install, so not a problem.

I think all of that should be in i3-qubes-settings, which is what I'm doing right now. The autogenerated config is based on a config that I can just swap out after install, so not a problem.

@minad

This comment has been minimized.

Show comment
Hide comment
@minad

minad May 23, 2016

Ah, so i3 is generating from a template config which can be replaced? Then this would be a better solution!

minad commented May 23, 2016

Ah, so i3 is generating from a template config which can be replaced? Then this would be a better solution!

@SietsevanderMolen

This comment has been minimized.

Show comment
Hide comment
@SietsevanderMolen

SietsevanderMolen May 23, 2016

@marmarek There should now be a settings package (github is being a bit slow today). I'm not sure if I did it right, but it works for me.

@marmarek There should now be a settings package (github is being a bit slow today). I'm not sure if I did it right, but it works for me.

marmarek added a commit to marmarek/qubes-desktop-linux-i3 that referenced this issue May 23, 2016

marmarek added a commit to marmarek/qubes-desktop-linux-i3 that referenced this issue May 23, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 23, 2016

Member

Looks good. Is that all? Then I'd increase version and upload to testing repository.

Member

marmarek commented May 23, 2016

Looks good. Is that all? Then I'd increase version and upload to testing repository.

@minad

This comment has been minimized.

Show comment
Hide comment
@minad

minad May 24, 2016

@marmarek I just went again over the scripts and there are some minor issues, which I am fixing right now.

minad commented May 24, 2016

@marmarek I just went again over the scripts and there are some minor issues, which I am fixing right now.

@minad

This comment has been minimized.

Show comment
Hide comment
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 24, 2016

Member

When you think it's ready, please create PR against https://github.com/QubesOS/qubes-desktop-linux-i3

Member

marmarek commented May 24, 2016

When you think it's ready, please create PR against https://github.com/QubesOS/qubes-desktop-linux-i3

@minad

This comment has been minimized.

Show comment
Hide comment
@minad

minad May 29, 2016

@SietsevanderMolen What is the status? Do you think it is ready for testing now?

minad commented May 29, 2016

@SietsevanderMolen What is the status? Do you think it is ready for testing now?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 29, 2016

Member

Packages are already in testing repository QubesOS/qubes-desktop-linux-i3#1 (comment)

Member

marmarek commented May 29, 2016

Packages are already in testing repository QubesOS/qubes-desktop-linux-i3#1 (comment)

@minad

This comment has been minimized.

Show comment
Hide comment

minad commented May 30, 2016

@marmarek cool thx!

andrewdavidwong added a commit that referenced this issue May 31, 2016

@cyrinux

This comment has been minimized.

Show comment
Hide comment
@cyrinux

cyrinux Jun 8, 2016

Hi, I use this since few times, it is awesome (joke) but I can't find how to set correctly my i3 rules due to all class replaced with VM name.
For example if I want to put all my work window on a workspace and personal on another it is easy.
But next if I want to put my thunderbird work in a dedicated IM workspace I can't.
How do you do that?

cyrinux commented Jun 8, 2016

Hi, I use this since few times, it is awesome (joke) but I can't find how to set correctly my i3 rules due to all class replaced with VM name.
For example if I want to put all my work window on a workspace and personal on another it is easy.
But next if I want to put my thunderbird work in a dedicated IM workspace I can't.
How do you do that?

@minad

This comment has been minimized.

Show comment
Hide comment
@minad

minad Jun 8, 2016

Hi, yes this is an issue. There was a discussion here: https://groups.google.com/forum/embed/#!topic/qubes-devel/4b8OI6wE0R0

@marmarek This will be resolved in 3.2 I guess? #1953

minad commented Jun 8, 2016

Hi, yes this is an issue. There was a discussion here: https://groups.google.com/forum/embed/#!topic/qubes-devel/4b8OI6wE0R0

@marmarek This will be resolved in 3.2 I guess? #1953

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jun 8, 2016

Member

On Wed, Jun 08, 2016 at 03:23:19AM -0700, Daniel Mendler wrote:

@marmarek This will be resolved in 3.2 I guess? #1953

Yes, exactly.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Member

marmarek commented Jun 8, 2016

On Wed, Jun 08, 2016 at 03:23:19AM -0700, Daniel Mendler wrote:

@marmarek This will be resolved in 3.2 I guess? #1953

Yes, exactly.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

@cyrinux

This comment has been minimized.

Show comment
Hide comment
@cyrinux

cyrinux Jun 8, 2016

Ok thanks you, I wait ;)

cyrinux commented Jun 8, 2016

Ok thanks you, I wait ;)

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jun 8, 2016

Member

@SietsevanderMolen for Qubes 3.2 - do you want to update to newer i3 version (Fedora 23 have 4.12 by default), or leave it as it is at 4.8?

Member

marmarek commented Jun 8, 2016

@SietsevanderMolen for Qubes 3.2 - do you want to update to newer i3 version (Fedora 23 have 4.12 by default), or leave it as it is at 4.8?

@SietsevanderMolen

This comment has been minimized.

Show comment
Hide comment
@SietsevanderMolen

SietsevanderMolen Jun 8, 2016

Definitely update, 4.8 is pretty old already and 4.12 has a lot of improvements. I have some patches for 4.12 lying around already, I'll look at it tomorrow.
9. jun. 2016 00.46 skrev Marek Marczykowski-Górecki notifications@github.com:

@SietsevanderMolen for Qubes 3.2 - do you want to update to newer i3 version (Fedora 23 have 4.12 by default), or leave it as it is at 4.8?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Definitely update, 4.8 is pretty old already and 4.12 has a lot of improvements. I have some patches for 4.12 lying around already, I'll look at it tomorrow.
9. jun. 2016 00.46 skrev Marek Marczykowski-Górecki notifications@github.com:

@SietsevanderMolen for Qubes 3.2 - do you want to update to newer i3 version (Fedora 23 have 4.12 by default), or leave it as it is at 4.8?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

andrewdavidwong added a commit that referenced this issue Jun 9, 2016

@cyrinux

This comment has been minimized.

Show comment
Hide comment
@cyrinux

cyrinux Jun 26, 2016

Hi,
I would like to try qube 3.2rc1 but dom0 failed because i3 version not
compatible ^^.

Le jeu. 9 juin 2016 à 01:02, Sietse van der Molen notifications@github.com
a écrit :

Definitely update, 4.8 is pretty old already and 4.12 has a lot of
improvements. I have some patches for 4.12 lying around already, I'll look
at it tomorrow.
9. jun. 2016 00.46 skrev Marek Marczykowski-Górecki <
notifications@github.com>:

@SietsevanderMolen for Qubes 3.2 - do you want to update to newer i3
version (Fedora 23 have 4.12 by default), or leave it as it is at 4.8?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#2015 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAfrqxxki8DVrkHJIlzWXXgw85pIXQlpks5qJ0oAgaJpZM4Ikihr
.

cyrinux commented Jun 26, 2016

Hi,
I would like to try qube 3.2rc1 but dom0 failed because i3 version not
compatible ^^.

Le jeu. 9 juin 2016 à 01:02, Sietse van der Molen notifications@github.com
a écrit :

Definitely update, 4.8 is pretty old already and 4.12 has a lot of
improvements. I have some patches for 4.12 lying around already, I'll look
at it tomorrow.
9. jun. 2016 00.46 skrev Marek Marczykowski-Górecki <
notifications@github.com>:

@SietsevanderMolen for Qubes 3.2 - do you want to update to newer i3
version (Fedora 23 have 4.12 by default), or leave it as it is at 4.8?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#2015 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAfrqxxki8DVrkHJIlzWXXgw85pIXQlpks5qJ0oAgaJpZM4Ikihr
.

@cyrinux

This comment has been minimized.

Show comment
Hide comment
@cyrinux

cyrinux Jun 26, 2016

-> I have understand i must now be possible to use i3 4.12? Could you
please put it in the repository? Thanks!

Le dim. 26 juin 2016 à 18:55, LEVIS Cyril levis.cyril@gmail.com a écrit :

Hi,
I would like to try qube 3.2rc1 but dom0 failed because i3 version not
compatible ^^.

Le jeu. 9 juin 2016 à 01:02, Sietse van der Molen <
notifications@github.com> a écrit :

Definitely update, 4.8 is pretty old already and 4.12 has a lot of
improvements. I have some patches for 4.12 lying around already, I'll look
at it tomorrow.
9. jun. 2016 00.46 skrev Marek Marczykowski-Górecki <
notifications@github.com>:

@SietsevanderMolen for Qubes 3.2 - do you want to update to newer i3
version (Fedora 23 have 4.12 by default), or leave it as it is at 4.8?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#2015 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAfrqxxki8DVrkHJIlzWXXgw85pIXQlpks5qJ0oAgaJpZM4Ikihr
.

cyrinux commented Jun 26, 2016

-> I have understand i must now be possible to use i3 4.12? Could you
please put it in the repository? Thanks!

Le dim. 26 juin 2016 à 18:55, LEVIS Cyril levis.cyril@gmail.com a écrit :

Hi,
I would like to try qube 3.2rc1 but dom0 failed because i3 version not
compatible ^^.

Le jeu. 9 juin 2016 à 01:02, Sietse van der Molen <
notifications@github.com> a écrit :

Definitely update, 4.8 is pretty old already and 4.12 has a lot of
improvements. I have some patches for 4.12 lying around already, I'll look
at it tomorrow.
9. jun. 2016 00.46 skrev Marek Marczykowski-Górecki <
notifications@github.com>:

@SietsevanderMolen for Qubes 3.2 - do you want to update to newer i3
version (Fedora 23 have 4.12 by default), or leave it as it is at 4.8?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#2015 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAfrqxxki8DVrkHJIlzWXXgw85pIXQlpks5qJ0oAgaJpZM4Ikihr
.

@SietsevanderMolen

This comment has been minimized.

Show comment
Hide comment
@SietsevanderMolen

SietsevanderMolen Jun 27, 2016

Yes, working on it. I'm at work and don't want to upgrade my work laptop to 3.2rc1 right now. :-) I'll do it in 8 hours or so.

Yes, working on it. I'm at work and don't want to upgrade my work laptop to 3.2rc1 right now. :-) I'll do it in 8 hours or so.

@cyrinux

This comment has been minimized.

Show comment
Hide comment
@cyrinux

cyrinux Jun 27, 2016

I fact I say wrong, I have successfully upgrade next fixing a typo in my
config, but allways with same i3 version so ;) Keep me in touch for test ^^

Le lun. 27 juin 2016 à 11:25, Sietse van der Molen notifications@github.com
a écrit :

Yes, working on it. I'm at work and don't want to upgrade my work laptop
to 3.2rc1 right now. :-) I'll do it in 8 hours or so.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#2015 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAfrq0F4kNB4iSCh4fVTC-YcDBa3hnfuks5qP5cegaJpZM4Ikihr
.

cyrinux commented Jun 27, 2016

I fact I say wrong, I have successfully upgrade next fixing a typo in my
config, but allways with same i3 version so ;) Keep me in touch for test ^^

Le lun. 27 juin 2016 à 11:25, Sietse van der Molen notifications@github.com
a écrit :

Yes, working on it. I'm at work and don't want to upgrade my work laptop
to 3.2rc1 right now. :-) I'll do it in 8 hours or so.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#2015 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAfrq0F4kNB4iSCh4fVTC-YcDBa3hnfuks5qP5cegaJpZM4Ikihr
.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jun 27, 2016

Member

I've tried i3 4.12 on R3.2-rc1, but had some problems - namely no window was visible. Haven't debugged it yet - it might be something with my system, not i3 in particular.
The version I've tested is already pushed to https://github.com/qubesos/qubes-desktop-linux-i3 master. Will have time to look at it probably somehow on Wed.

Member

marmarek commented Jun 27, 2016

I've tried i3 4.12 on R3.2-rc1, but had some problems - namely no window was visible. Haven't debugged it yet - it might be something with my system, not i3 in particular.
The version I've tested is already pushed to https://github.com/qubesos/qubes-desktop-linux-i3 master. Will have time to look at it probably somehow on Wed.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jun 28, 2016

Member

i3 4.12 uploaded to current-testing repository for R3.2-rc1 :)

Member

marmarek commented Jun 28, 2016

i3 4.12 uploaded to current-testing repository for R3.2-rc1 :)

andrewdavidwong added a commit that referenced this issue Jun 28, 2016

@minad

This comment has been minimized.

Show comment
Hide comment
@minad

minad Jun 28, 2016

@marmarek Is the 4.12 version working fine for you?

minad commented Jun 28, 2016

@marmarek Is the 4.12 version working fine for you?

@cyrinux

This comment has been minimized.

Show comment
Hide comment
@cyrinux

cyrinux Jun 28, 2016

It works for me ! :)

Le 28/06/2016 à 21:51, Daniel Mendler a écrit :

@marmarek https://github.com/marmarek Is the 4.12 version working
fine for you?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#2015 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAfrq0uvHCApHMYXzChE4jM_bhhNtfVVks5qQXs1gaJpZM4Ikihr.

cyrinux commented Jun 28, 2016

It works for me ! :)

Le 28/06/2016 à 21:51, Daniel Mendler a écrit :

@marmarek https://github.com/marmarek Is the 4.12 version working
fine for you?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#2015 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAfrq0uvHCApHMYXzChE4jM_bhhNtfVVks5qQXs1gaJpZM4Ikihr.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jun 29, 2016

Member

@marmarek Is the 4.12 version working fine for you?

Yes (but I don't use it daily, at least not yet ;) ).

Member

marmarek commented Jun 29, 2016

@marmarek Is the 4.12 version working fine for you?

Yes (but I don't use it daily, at least not yet ;) ).

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jun 29, 2016

Member

@SietsevanderMolen could you create a branch for R3.2? I'd like to sync latest changes back to your repo (especially 4.12).

Member

marmarek commented Jun 29, 2016

@SietsevanderMolen could you create a branch for R3.2? I'd like to sync latest changes back to your repo (especially 4.12).

andrewdavidwong added a commit that referenced this issue Jun 30, 2016

@SietsevanderMolen

This comment has been minimized.

Show comment
Hide comment
@SietsevanderMolen

SietsevanderMolen Jul 5, 2016

@marmarek sorry for the delay, there is a qubes-3.2 branch now

@marmarek sorry for the delay, there is a qubes-3.2 branch now

andrewdavidwong added a commit that referenced this issue Jul 5, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 11, 2016

Member

As packages already uploaded to the repository, it is complete :)

Member

marmarek commented Jul 11, 2016

As packages already uploaded to the repository, it is complete :)

@marmarek marmarek closed this Jul 11, 2016

andrewdavidwong added a commit that referenced this issue Jul 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment