Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upQubes Manager and modal windows #2130
Comments
andrewdavidwong
added
enhancement
C: qubes-manager
P: minor
labels
Jul 1, 2016
andrewdavidwong
added this to the Far in the future milestone
Jul 1, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jpouellet
Nov 27, 2016
Contributor
This bothered me too, but...
There various assumptions in qubes-manager which make this not a trivial change. A side-effect of the way this is now helps to ensure consistency.
Consider this rather user-visible example:
- VM is off.
- Opening VM settings dialog shows enabled controls for options which are only mutable while VM is off (for example device assignment)
- Turn vm on! (which would be easy to do with a non-modal dialog)
- Add some devices and click Ok
Now what...
The operation cannot proceed. Do we have all the proper asserts to ensure it does not attempt to and leave things in an inconsistent state? Best case the user just gets a very unhelpful stack trace, worst case then end up with an inconsistent qubes.xml or something.
IMO it appears not worth trying to fix, at least until we are satisfied with the result of #2132.
|
This bothered me too, but... There various assumptions in qubes-manager which make this not a trivial change. A side-effect of the way this is now helps to ensure consistency. Consider this rather user-visible example:
The operation cannot proceed. Do we have all the proper asserts to ensure it does not attempt to and leave things in an inconsistent state? Best case the user just gets a very unhelpful stack trace, worst case then end up with an inconsistent qubes.xml or something. IMO it appears not worth trying to fix, at least until we are satisfied with the result of #2132. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Nov 28, 2016
Member
IMO it appears not worth trying to fix, at least until we are satisfied with the result of #2132.
This is one of the reasons for the P: minor label and Far in the future milestone. Those and, of course, the lack of dev time to devote to this.
This is one of the reasons for the |
jpouellet
referenced this issue
in QubesOS/qubes-manager
Jul 12, 2017
Closed
Add some more keyboard shortcuts (Ctrl+_) #19
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarta
Jul 13, 2018
This has been fixed in the 4.0 decomposed Qubes Manager; the fix won't be back-ported to 3.2 due to amount of work needed, so I'm going to close this one.
marmarta
commented
Jul 13, 2018
|
This has been fixed in the 4.0 decomposed Qubes Manager; the fix won't be back-ported to 3.2 due to amount of work needed, so I'm going to close this one. |
nielsk commentedJun 30, 2016
•
edited
Edited 1 time
-
nielsk
edited Jun 30, 2016 (most recent)
Qubes OS version (e.g.,
R3.1):R3.1, R3.2RC1
Affected TemplateVMs (e.g.,
fedora-23, if applicable):Expected behavior:
When I do something like updating dom0 or another action that brings up a new window created by the manager, I should be able to do something else in the manager while that window is open.
Actual behavior:
You click for example that dom0 shall get updated and a modal window appears, the Manager gets darker and you cannot do any action in the manager until a certain state of the update is reached.
Steps to reproduce the behavior:
Try to update dom0 in the Qubes Manager or any other action that will create a new window.