/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping `salt-call saltutl.sync_all` from rpm post-install scripts #2140

Closed
marmarek opened this Issue Jul 1, 2016 · 1 comment

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Release 3.2
1 participant
@marmarek
@marmarek
Member

marmarek commented Jul 1, 2016

It shouldn't be necessary anymore since salt configuration is no longer automatically generated (by config formula). And will save a lot of time during package installation.
Additionally bare salt-call may be harmful as it doesn't load backported features and may miss some configuration (merging file_roots setting doesn't work).

@marmarek marmarek added P: minor task C: mgmt labels Jul 1, 2016

@marmarek marmarek added this to the Release 3.2 milestone Jul 1, 2016

marmarek added a commit to marmarek/qubes-mgmt-salt that referenced this issue Jul 1, 2016

@marmarek
rpm: drop saltutil.sync_all calls in %post script 
Calls done with `salt-call` instead of `qubesctl` can be harmful since
it doesn't load backported features.
Also it looks to be no longer necessary (since dropping generation of
/etc/salt/minion/f_defaults.conf). And not having those calls save a lot
of time during package installation.

QubesOS/qubes-issues#2140
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
b39faa9

marmarek added a commit to marmarek/qubes-mgmt-salt-base-overrides that referenced this issue Jul 16, 2016

@marmarek
Drop post installation scripts at all 
QubesOS/qubes-issues#2140
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
b2638e7

marmarek added a commit to QubesOS/qubes-mgmt-salt-dom0-virtual-machines that referenced this issue Jul 19, 2016

@marmarek
Drop saltutil.* from post installation scripts 
QubesOS/qubes-issues#2140
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
0a4e528

marmarek added a commit to marmarek/qubes-mgmt-salt-base-config that referenced this issue Aug 8, 2016

@marmarek
Drop automatic enabling formulas and clearing cache 
QubesOS/qubes-issues#2140
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
156df5f
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 19, 2016

Member

Done.
Member

marmarek commented Nov 19, 2016

Done.

@marmarek marmarek closed this Nov 19, 2016

This was referenced Sep 25, 2017

Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment