/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to restore backup from R3.1 to R3.1 & R3.2 #2168

Closed
Chilinot opened this Issue Jul 13, 2016 · 9 comments

Comments

Assignees

@marmarek marmarek

Labels
Projects
None yet
Milestone
  Release 3.2
3 participants
@Chilinot @marmarek @andrewdavidwong
@Chilinot

Chilinot commented Jul 13, 2016 •
edited
Edited 1 time
  • @Chilinot Chilinot edited Jul 13, 2016 (most recent)

Qubes OS version (e.g., R3.1):

R3.1 & R3.2-rc

Affected TemplateVMs (e.g., fedora-23, if applicable):

Unknown

Expected behavior:

List the names of the backup VM's in the backup file.

Actual behavior:

Popup window with error message:
Title: "Houston, we have a problem..."
Content:

AttributeError: 'NoneType' object has no attribute 'name'
This is most likely a bug in the Qubes Manager

Details:

 ----
 line: vm_info['netvm'] = host_collection \
 func: restore_info_verify
 line no.: 1729
 file: /usr/lib64/python2.7/site-packages/qubes/backup.py
 ----
 line: vms_to_restore = restore_info_verify(vms_to_restore, host_collection)
 func: backup_restore_prepare
 line no.: 1906
 file: /usr/lib64/python2.7/site-packages/qubes/backup.py
 ----
 line: appvm=self.target_appvm)
 func: __fill_vms_list__
 line no.: 140
 file: /usr/lib64/python2.7/site-packages/qubesmanager/restore.py
 ----
 line: self.__fill_vms_list__()
 func: current_page_changed
 line no.: 220
 file: /usr/lib64/python2.7/site-packages/qubesmanager/restore.py

Steps to reproduce the behavior:

  1. Back up VM's in R3.1
  2. Attempt to restore the VM's on fresh install of either R3.1 or R3.2-rc.
  3. Check the "ignore missing" tick-box.
  4. Press next.
  5. Error.

The same happens when used in the terminal with the "--ignore-missing" option.

General notes:

When the restoration program attempts to list all VM's in the backup file so that I will be able to select which ones to restore it fails with the above error.

I created the backup in order to reinstall my system.
I selected all VM's except the firewall and net-vm.
The backup is encrypted.
First I installed R3.2-rc, failed with the same message.
Then I tried R3.1 since that was the stable release and the one I had installed previously.
Still failed with the above error.

Related issues:

#1124
@Chilinot

This comment has been minimized.

Show comment
Hide comment
@Chilinot

Chilinot Jul 13, 2016

I forgot to add that this issue only happens if the "Ignore missing" is checked.
EDIT: I have added it to the description.

Chilinot commented Jul 13, 2016 •
edited
Edited 1 time
  • @Chilinot Chilinot edited Jul 13, 2016 (most recent)

I forgot to add that this issue only happens if the "Ignore missing" is checked.
EDIT: I have added it to the description.
@Chilinot

This comment has been minimized.

Show comment
Hide comment
@Chilinot

Chilinot Jul 13, 2016

Full output when run in terminal with debug mode:

[lucas@dom0 ~]$ qvm-backup-restore --ignore-missing --encrypted --debug /run/media/lucas/Lillextern/Backup/Laptop/Qubes/qubes-backup-2016-07-12T101504 
Please enter the pass phrase that will be used to decrypt/verify the backup: 
Checking backup content...
Working in temporary dir:/var/tmp/restore_K0mWC6
Extracting data: 1.0 MiB to restore
Run command[u'tar', u'-ixvf', '/run/media/lucas/Lillextern/Backup/Laptop/Qubes/qubes-backup-2016-07-12T101504', u'-C', u'/var/tmp/restore_K0mWC6', u'backup-header', u'backup-header.hmac', u'qubes.xml.000', u'qubes.xml.000.hmac']
Got backup header and hmac: backup-header, backup-header.hmac
Verifying file /var/tmp/restore_K0mWC6/backup-header
Loading hmac for file /var/tmp/restore_K0mWC6/backup-header
File verification OK -> Sending file /var/tmp/restore_K0mWC6/backup-header
Creating pipe in: /var/tmp/restore_K0mWC6/restore_pipe
Getting new file:qubes.xml.000
Getting hmac:qubes.xml.000.hmac
Verifying file /var/tmp/restore_K0mWC6/qubes.xml.000
Started sending thread
Moving to dir /var/tmp/restore_K0mWC6
Loading hmac for file /var/tmp/restore_K0mWC6/qubes.xml.000
File verification OK -> Sending file /var/tmp/restore_K0mWC6/qubes.xml.000
Getting new file:
Waiting for the extraction process to finish...Extracting file /var/tmp/restore_K0mWC6/qubes.xml.000

Running command [u'tar', u'-xkv', u'qubes.xml']
Removing file /var/tmp/restore_K0mWC6/qubes.xml.000
qubes.xml
Finished extracting thread
Extraction process finished with code:0
Loading file /var/tmp/restore_K0mWC6/qubes.xml
debian-8 is included in backup
whonix-ws is included in backup
whonix-gw is included in backup
fedora-23 is included in backup
anon-whonix is included in backup
vault is included in backup
personal is included in backup
web is included in backup
mail is included in backup
dev is included in backup
spotify is included in backup
encore is included in backup
Traceback (most recent call last):
  File "/usr/bin/qvm-backup-restore", line 266, in <module>
    main()
  File "/usr/bin/qvm-backup-restore", line 151, in main
    error_callback=error_callback)
  File "/usr/lib64/python2.7/site-packages/qubes/backup.py", line 1906, in backup_restore_prepare
    vms_to_restore = restore_info_verify(vms_to_restore, host_collection)
  File "/usr/lib64/python2.7/site-packages/qubes/backup.py", line 1720, in restore_info_verify
    vm_info['netvm'] = host_collection \
AttributeError: 'NoneType' object has no attribute 'name'

Chilinot commented Jul 13, 2016

Full output when run in terminal with debug mode:

[lucas@dom0 ~]$ qvm-backup-restore --ignore-missing --encrypted --debug /run/media/lucas/Lillextern/Backup/Laptop/Qubes/qubes-backup-2016-07-12T101504 
Please enter the pass phrase that will be used to decrypt/verify the backup: 
Checking backup content...
Working in temporary dir:/var/tmp/restore_K0mWC6
Extracting data: 1.0 MiB to restore
Run command[u'tar', u'-ixvf', '/run/media/lucas/Lillextern/Backup/Laptop/Qubes/qubes-backup-2016-07-12T101504', u'-C', u'/var/tmp/restore_K0mWC6', u'backup-header', u'backup-header.hmac', u'qubes.xml.000', u'qubes.xml.000.hmac']
Got backup header and hmac: backup-header, backup-header.hmac
Verifying file /var/tmp/restore_K0mWC6/backup-header
Loading hmac for file /var/tmp/restore_K0mWC6/backup-header
File verification OK -> Sending file /var/tmp/restore_K0mWC6/backup-header
Creating pipe in: /var/tmp/restore_K0mWC6/restore_pipe
Getting new file:qubes.xml.000
Getting hmac:qubes.xml.000.hmac
Verifying file /var/tmp/restore_K0mWC6/qubes.xml.000
Started sending thread
Moving to dir /var/tmp/restore_K0mWC6
Loading hmac for file /var/tmp/restore_K0mWC6/qubes.xml.000
File verification OK -> Sending file /var/tmp/restore_K0mWC6/qubes.xml.000
Getting new file:
Waiting for the extraction process to finish...Extracting file /var/tmp/restore_K0mWC6/qubes.xml.000

Running command [u'tar', u'-xkv', u'qubes.xml']
Removing file /var/tmp/restore_K0mWC6/qubes.xml.000
qubes.xml
Finished extracting thread
Extraction process finished with code:0
Loading file /var/tmp/restore_K0mWC6/qubes.xml
debian-8 is included in backup
whonix-ws is included in backup
whonix-gw is included in backup
fedora-23 is included in backup
anon-whonix is included in backup
vault is included in backup
personal is included in backup
web is included in backup
mail is included in backup
dev is included in backup
spotify is included in backup
encore is included in backup
Traceback (most recent call last):
  File "/usr/bin/qvm-backup-restore", line 266, in <module>
    main()
  File "/usr/bin/qvm-backup-restore", line 151, in main
    error_callback=error_callback)
  File "/usr/lib64/python2.7/site-packages/qubes/backup.py", line 1906, in backup_restore_prepare
    vms_to_restore = restore_info_verify(vms_to_restore, host_collection)
  File "/usr/lib64/python2.7/site-packages/qubes/backup.py", line 1720, in restore_info_verify
    vm_info['netvm'] = host_collection \
AttributeError: 'NoneType' object has no attribute 'name'

@andrewdavidwong andrewdavidwong added bug C: core P: major labels Jul 13, 2016

@andrewdavidwong andrewdavidwong added this to the Release 3.2 milestone Jul 13, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 13, 2016

Member

What did you choose during installation in firstboot dialog? I guess "do nothing", right?
Member

marmarek commented Jul 13, 2016

What did you choose during installation in firstboot dialog? I guess "do nothing", right?
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 13, 2016

Member

It looks to be caused by missing default netvm. As a workaround create any netvm (may be not functional at all) and set as default one. Then after restore change default netvm to the restored one (as you probably want).
Member

marmarek commented Jul 13, 2016

It looks to be caused by missing default netvm. As a workaround create any netvm (may be not functional at all) and set as default one. Then after restore change default netvm to the restored one (as you probably want).

@marmarek marmarek self-assigned this Jul 14, 2016

@Chilinot

This comment has been minimized.

Show comment
Hide comment
@Chilinot

Chilinot Jul 14, 2016

@marmarek yes, precisely. When I performed the fresh install I selected "don't configure anything".

Chilinot commented Jul 14, 2016

@marmarek yes, precisely. When I performed the fresh install I selected "don't configure anything".

@marmarek marmarek closed this in marmarek/old-qubes-core-admin@f15ddf7 Jul 18, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 19, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.2.7-1.fc23 has been pushed to the r3.2 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update
Member

marmarek commented Jul 19, 2016

Automated announcement from builder-github

The package qubes-core-dom0-3.2.7-1.fc23 has been pushed to the r3.2 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@marmarek marmarek added the r3.2-dom0-cur-test label Jul 19, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 28, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.2.7-1.fc23 has been pushed to the r3.2 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update
Member

marmarek commented Jul 28, 2016

Automated announcement from builder-github

The package qubes-core-dom0-3.2.7-1.fc23 has been pushed to the r3.2 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@marmarek marmarek added r3.2-dom0-stable and removed r3.2-dom0-cur-test labels Jul 28, 2016

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Nov 20, 2016

@marmarek
backup: fix restoring on system without default netvm 
Fixes QubesOS/qubes-issues#2168

(cherry picked from commit f15ddf7)
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
1dfadbf
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 20, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.1.18-1.fc20 has been pushed to the r3.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update
Member

marmarek commented Nov 20, 2016

Automated announcement from builder-github

The package qubes-core-dom0-3.1.18-1.fc20 has been pushed to the r3.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@marmarek marmarek added the r3.1-dom0-cur-test label Nov 20, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 4, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.1.18-1.fc20 has been pushed to the r3.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update
Member

marmarek commented Dec 4, 2016

Automated announcement from builder-github

The package qubes-core-dom0-3.1.18-1.fc20 has been pushed to the r3.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@marmarek marmarek added r3.1-dom0-stable and removed r3.1-dom0-cur-test labels Dec 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment