New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create compatibility layer in salt #2174

Open
woju opened this Issue Jul 15, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@woju
Member

woju commented Jul 15, 2016

Make salt states from 3.x work in 4.x

Potential problems:

  • netvm/proxyvm
  • Fix changes reporting for creating VMs

@woju woju added the task label Jul 15, 2016

@woju woju added this to the Release 4.0 milestone Jul 15, 2016

@kalkin

This comment has been minimized.

Show comment
Hide comment
@kalkin

kalkin Jul 15, 2016

Member

@woju Are you already working on this? I also wanted to tackle this next

Member

kalkin commented Jul 15, 2016

@woju Are you already working on this? I also wanted to tackle this next

@kalkin kalkin self-assigned this Jul 15, 2016

@woju

This comment has been minimized.

Show comment
Hide comment
@woju

woju Jul 16, 2016

Member

On Fri, Jul 15, 2016 at 01:04:15PM -0700, Bahtiar Gadimov wrote:

@woju Are you already working on this? I also wanted to tackle this next

No, just a random thought that occured to me that I wanted to write down.
Feel free to assign to yourself.

pozdrawiam / best regards .-.
Wojtek Porczyk .-^' '^-.
Invisible Things Lab |'-.-^-.-'|
| | | |
I do not fear computers, | '-.-' |
I fear lack of them. '-._ : ,-'
-- Isaac Asimov `^-^-_>

Member

woju commented Jul 16, 2016

On Fri, Jul 15, 2016 at 01:04:15PM -0700, Bahtiar Gadimov wrote:

@woju Are you already working on this? I also wanted to tackle this next

No, just a random thought that occured to me that I wanted to write down.
Feel free to assign to yourself.

pozdrawiam / best regards .-.
Wojtek Porczyk .-^' '^-.
Invisible Things Lab |'-.-^-.-'|
| | | |
I do not fear computers, | '-.-' |
I fear lack of them. '-._ : ,-'
-- Isaac Asimov `^-^-_>

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 16, 2016

Member

While at it - fix changes reporting for creating VMs - currently when VM is created, it is reported that no change was made as VM already existed.

You may want to read this: https://docs.saltstack.com/en/latest/ref/states/writing.html
Especially this: https://docs.saltstack.com/en/latest/ref/states/writing.html#return-data

Member

marmarek commented Jul 16, 2016

While at it - fix changes reporting for creating VMs - currently when VM is created, it is reported that no change was made as VM already existed.

You may want to read this: https://docs.saltstack.com/en/latest/ref/states/writing.html
Especially this: https://docs.saltstack.com/en/latest/ref/states/writing.html#return-data

@kalkin

This comment has been minimized.

Show comment
Hide comment
Member

kalkin commented Jul 16, 2016

marmarek added a commit to marmarek/qubes-mgmt-salt-dom0-qvm that referenced this issue May 22, 2017

Update to Admin API
1. Use 'qubesadmin' instead of 'qubes' module.
2. Adjust services values - encode True/False as strings (see
   documentation about 'features').
3. Drop properties no longer applicable, for which there will be no
   backward compatiblity (not reasonably useful in the past):
    - dir
    - config
    - updateable
    - root-img
    - root-volatile-img
    - private-img
    - flags: force-root

QubesOS/qubes-issues#1825
QubesOS/qubes-issues#2174

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jul 5, 2017

Closed

mgmt-salt-dom0-qvm v4.0.0 (r4.0) #111

@kalkin kalkin removed their assignment Aug 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment