New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding anti-evil-maid package to R3.2 iso #2176

Closed
rustybird opened this Issue Jul 15, 2016 · 9 comments

Comments

Projects
None yet
2 participants
@rustybird

If QubesOS/qubes-antievilmaid#14 is merged, AEM would be totally inactive (and hidden in the GRUB menu anyway) for users who haven't run anti-evil-maid-install.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 15, 2016

Member

This is somehow related to #803. Maybe even a duplicate?
We're quite late in R3.2 release cycle, but if it indeed will be inactive by default, the regression risk is low and I'm for it.

Member

marmarek commented Jul 15, 2016

This is somehow related to #803. Maybe even a duplicate?
We're quite late in R3.2 release cycle, but if it indeed will be inactive by default, the regression risk is low and I'm for it.

@marmarek marmarek added this to the Release 3.2 milestone Jul 15, 2016

@rustybird

This comment has been minimized.

Show comment
Hide comment
@rustybird

rustybird Jul 15, 2016

We're quite late in R3.2 release cycle, but if it indeed will be inactive by default, the regression risk is low and I'm for it.

I don't want to break the iso build (which is hard to test for me right now, my notebook is throttled down all the way due to overheating). Will these two commands be a problem in such a context?

https://github.com/rustybird/qubes-antievilmaid/blob/608b894ee2355eb7c75ec962c052c5262e5d66a0/anti-evil-maid/anti-evil-maid.spec#L61-L62

We're quite late in R3.2 release cycle, but if it indeed will be inactive by default, the regression risk is low and I'm for it.

I don't want to break the iso build (which is hard to test for me right now, my notebook is throttled down all the way due to overheating). Will these two commands be a problem in such a context?

https://github.com/rustybird/qubes-antievilmaid/blob/608b894ee2355eb7c75ec962c052c5262e5d66a0/anti-evil-maid/anti-evil-maid.spec#L61-L62

@rustybird

This comment has been minimized.

Show comment
Hide comment
@rustybird

rustybird Jul 15, 2016

Sorry, let me rephrase that: The iso build shouldn't break, but maybe the %post scriptlet would not work inside of Anaconda?

Sorry, let me rephrase that: The iso build shouldn't break, but maybe the %post scriptlet would not work inside of Anaconda?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 15, 2016

Member

At the time package is installed there may be no dracut or grub2-mkconfig yet. For this, better add:

Requires(post): dracut
Requires(post): grub2-tools

initrd + grub configuration will be regenerated anyway at the end of installation.

But I see other problem: UEFI installation. Currently tboot doesn't have native UEFI support, so it can't be directly plugged in. In such installation we don't even install grub, since xen.efi is directly plugged into UEFI BIOS.

Member

marmarek commented Jul 15, 2016

At the time package is installed there may be no dracut or grub2-mkconfig yet. For this, better add:

Requires(post): dracut
Requires(post): grub2-tools

initrd + grub configuration will be regenerated anyway at the end of installation.

But I see other problem: UEFI installation. Currently tboot doesn't have native UEFI support, so it can't be directly plugged in. In such installation we don't even install grub, since xen.efi is directly plugged into UEFI BIOS.

@rustybird

This comment has been minimized.

Show comment
Hide comment
@rustybird

rustybird Jul 15, 2016

I've updated the dependencies. Not sure what to do about UEFI

I've updated the dependencies. Not sure what to do about UEFI

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 15, 2016

Member

It may be an option to add the packages, but do not install them by default - available in software selection dialog.
But since the user still needs to download SINIT file, I'm not sure if all this worth an effort.

Member

marmarek commented Jul 15, 2016

It may be an option to add the packages, but do not install them by default - available in software selection dialog.
But since the user still needs to download SINIT file, I'm not sure if all this worth an effort.

@rustybird

This comment has been minimized.

Show comment
Hide comment
@rustybird

rustybird Jul 15, 2016

Yeah, if the user would have to choose manually anyway then it doesn't seem worth the trouble.

Is it possible to tell Anaconda to only add a package when not doing an UEFI installation?

Yeah, if the user would have to choose manually anyway then it doesn't seem worth the trouble.

Is it possible to tell Anaconda to only add a package when not doing an UEFI installation?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 15, 2016

Member

Is it possible to tell Anaconda to only add a package when not doing an UEFI installation?

Theoretically yes, but it's rather hacky (there is a list of packages required for bootloader, hardcoded into anaconda itself).

Member

marmarek commented Jul 15, 2016

Is it possible to tell Anaconda to only add a package when not doing an UEFI installation?

Theoretically yes, but it's rather hacky (there is a list of packages required for bootloader, hardcoded into anaconda itself).

@rustybird

This comment has been minimized.

Show comment
Hide comment
@rustybird

rustybird Jul 15, 2016

Oh well. Maybe another time

Oh well. Maybe another time

@rustybird rustybird closed this Jul 15, 2016

@rustybird rustybird referenced this issue in QubesOS/qubes-antievilmaid Feb 16, 2018

Closed

add systemctl enable tcsd #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment