Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upLUKS passphrase strength visible upon entering #2199
Comments
andrewdavidwong
added
enhancement
C: desktop-linux
P: minor
UX
labels
Jul 26, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Jul 26, 2016
Member
I assume the reason for the existing behavior is to give the user visual confirmation that additional passphrase characters are being entered (beyond what can fit in the box). Not having any form of visual feedback for the input of additional characters could be an accessibility concern.
It's not clear what the security significance of the "darker dots" issue is compared to having dots at all. An attacker who can see the screen while you enter your passphrase will be able to tell exactly how long your passphrase is either way. If your passphrase fits within the box, the attacker can count the number of dots. If the passphrase doesn't fit within the box because it's longer, then having the darker dots preserves the attacker's ability to count the dots. If this is a problem, then presumably we shouldn't have any visual indicator of passphrase length even (especially) for short passphrases that fit within the box.
In other words, it's strange to focus on the "darker dots" issue when the real problem (if it's even a problem, which I'm not sure it is) is having dots at all.
|
I assume the reason for the existing behavior is to give the user visual confirmation that additional passphrase characters are being entered (beyond what can fit in the box). Not having any form of visual feedback for the input of additional characters could be an accessibility concern. It's not clear what the security significance of the "darker dots" issue is compared to having dots at all. An attacker who can see the screen while you enter your passphrase will be able to tell exactly how long your passphrase is either way. If your passphrase fits within the box, the attacker can count the number of dots. If the passphrase doesn't fit within the box because it's longer, then having the darker dots preserves the attacker's ability to count the dots. If this is a problem, then presumably we shouldn't have any visual indicator of passphrase length even (especially) for short passphrases that fit within the box. In other words, it's strange to focus on the "darker dots" issue when the real problem (if it's even a problem, which I'm not sure it is) is having dots at all. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Roennie
Jul 26, 2016
Thank you for the feedback! Having done some additional research, I think that this is configured in plymouth? Thus, it should be configurable after installation?
I am not familiar at all with plymouth, but would the option to change this behavior during initial installation perhaps be an outcome? An opt-in, like "Hide the length of my passphrase during disk unlocking?". I might be able to work out a pull request for this issue, if desireable.
Roennie
commented
Jul 26, 2016
|
Thank you for the feedback! Having done some additional research, I think that this is configured in plymouth? Thus, it should be configurable after installation? I am not familiar at all with plymouth, but would the option to change this behavior during initial installation perhaps be an outcome? An opt-in, like "Hide the length of my passphrase during disk unlocking?". I might be able to work out a pull request for this issue, if desireable. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Jul 26, 2016
Member
I am not familiar at all with plymouth, but would the option to change this behavior during initial installation perhaps be an outcome? An opt-in, like "Hide the length of my passphrase during disk unlocking?".
@marmarek probably knows about this.
I might be able to work out a pull request for this issue, if desireable.
A pull request would be great, though I'm not sure how much demand there is for this feature aside from you. :)
@marmarek probably knows about this.
A pull request would be great, though I'm not sure how much demand there is for this feature aside from you. :) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adrelanos
Jul 27, 2016
Member
Andrew David Wong:
If this is a problem, then presumably we shouldn't have any visual indicator of passphrase length even (especially) for short passphrases that fit within the box.
I don't have a strong point and would just like to note, that this
influences UX. I witnessed lesser/common computer literate people being
greatly confused when there is no indicator in a password box when they
type. (such as full disk encryption password at boot time of some
operating systemd)
|
Andrew David Wong:
I don't have a strong point and would just like to note, that this |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Jul 27, 2016
Member
I think Kerchoff's principle applies here. Allowing an attacker to learn the length of your passphrase should not decrease the security of your system. If the passphrase is short enough for brute forcing to be feasible, then concealing the length is just security through obscurity. If the passphrase is long enough for brute forcing to be unfeasible, then the attacker knowing the length doesn't aid the attacker, since brute forcing is still unfeasible.
|
I think Kerchoff's principle applies here. Allowing an attacker to learn the length of your passphrase should not decrease the security of your system. If the passphrase is short enough for brute forcing to be feasible, then concealing the length is just security through obscurity. If the passphrase is long enough for brute forcing to be unfeasible, then the attacker knowing the length doesn't aid the attacker, since brute forcing is still unfeasible. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Jul 27, 2016
Member
(Not to mention that an attacker who can see your screen while you enter your masked passphrase could probably just look down at your hands to see which keys you're pressing.)
|
(Not to mention that an attacker who can see your screen while you enter your masked passphrase could probably just look down at your hands to see which keys you're pressing.) |
Roennie commentedJul 26, 2016
•
edited
Edited 1 time
-
Roennie
edited Jul 26, 2016 (most recent)
Qubes OS version: R3.1
Affected TemplateVMs: N/A
Expected behavior:
No visual disclosure of the LUKS passphrase length if the used passphrase is longer than the 'input box'.
Actual behavior:
If a LUKS passphrase is used, longer than the 'input box' in the boot process, the remaining characters get darker 'dots' than the initial 'dots'.
Steps to reproduce the behavior:
Set a LUKS passphrase of 40 (?) characters, enter them on boot to unlock FDE.
General notes:
Perhaps an option to disable any visual passphrase length 'confirmation' would be an idea, without having to fall back to the text boot environment?
Related issues: