New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure IP address is configured before network.target #2210

Open
adrelanos opened this Issue Jul 29, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@adrelanos
Member

adrelanos commented Jul 29, 2016

From the WIP commit message marmarek/qubes-core-agent-linux@7eb7561 by @marmarek:

setup-ip script can be called in two places:

  1. from udev rule
  2. from qubes-misc-post.service

The former one may fail if happen before qubes-db daemon is started. The
later one will fix it, but in the meantime some services (like whonix
update proxy sanity check) may expect to have already working network
(before are ordered after network.target or even network-online.target).

Delaying udev rules processing seems unreasonable, so introduce another
systemd service responsible for just configuring IP address. This does
not replace udev rule (but during startup will duplicate the same task),
because it is still needed to handle dynamic network switch. Also
the call in qubes-misc-post may be needed to handle DispVM startup
(network needs to be re-configured after restoring savefile).

Another idea would be to order qubes-misc-post.service after
network-online.target.

This commit is work in progres. It doesn't deal with the case where
initial setup-ip call from udev rule succeed. Second call will fail,
marking qubes-setup-ip service as failed. Also the third call (from
qubes-misc-post.service) will almost always fail - probably in every VM
but DispVM.

QubesOS/qubes-issues#2198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment