pkg.installed salt state fails with yum error message

[woju]

Qubes OS version (e.g., R3.1):

R3.2-rc2

Affected TemplateVMs (e.g., fedora-23, if applicable):

the issue is entirely in dom0

---

Expected behavior:

pkg.installed salt state module function works as advertised.

Actual behavior:

pkg.installed fails.

Steps to reproduce the behavior:

packages-dom0:
  pkg.installed:
    - pkgs:
      - terminus-fonts

Note that terminus-fonts package is arbitrary, probably any package triggers this bug.

General notes:

The error message contains yum help and the note suggesting some command line parameters are wrong.

---

Related issues:

[marmarek]

Are you using debian-based VM as updatevm?

[marmarek]

Are you using debian-based VM as updatevm?

[marmarek]

Or maybe VM with outdated qubes-core-vm package? Like from R3.1.

[marmarek]

Or maybe VM with outdated qubes-core-vm package? Like from R3.1.

[vladimir-lu]

This seems closest to the issue I'm facing right now on R4.

If you have a salt state that installs packages in dom0, then dom0 will use the updates proxy to get the packages. In my case, this is sys-whonix (jessie). This has yum installed but the output complains that --best is not an option. --best is only used in the qubes-download-dom0-updates.sh script when dnf is detected but dnf is clearly not installed in this whonix version. Some parameters are however passed from the salt yum module directly - specifically in yumpkg.py when salt detects that dnf is available it uses those options: https://github.com/saltstack/salt/blob/17e5a568bcd13d2b866f86512f9a4aa519392bd5/salt/modules/yumpkg.py#L1654

This gets passed into the updates proxy as an option and subsequently fails because of course these are invalid in yum. So you have dom0 with dnf and the updates proxy without.

I've made a local workaround where I remove those options if found from the $OPTIONS in the qubes-download-dom0-updates.sh script - maybe I will make a PR :)

[vladimir-lu]

This seems closest to the issue I'm facing right now on R4.

If you have a salt state that installs packages in dom0, then dom0 will use the updates proxy to get the packages. In my case, this is sys-whonix (jessie). This has yum installed but the output complains that --best is not an option. --best is only used in the qubes-download-dom0-updates.sh script when dnf is detected but dnf is clearly not installed in this whonix version. Some parameters are however passed from the salt yum module directly - specifically in yumpkg.py when salt detects that dnf is available it uses those options: https://github.com/saltstack/salt/blob/17e5a568bcd13d2b866f86512f9a4aa519392bd5/salt/modules/yumpkg.py#L1654

This gets passed into the updates proxy as an option and subsequently fails because of course these are invalid in yum. So you have dom0 with dnf and the updates proxy without.

I've made a local workaround where I remove those options if found from the $OPTIONS in the qubes-download-dom0-updates.sh script - maybe I will make a PR :)

[qubesos-bot]

Automated announcement from builder-github

The component core-agent-linux (including package python2-dnf-plugins-qubes-hooks-4.0.25-1.fc26) has been pushed to the r4.0 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The component core-agent-linux (including package python2-dnf-plugins-qubes-hooks-4.0.25-1.fc26) has been pushed to the r4.0 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package qubes-core-agent_4.0.25-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package qubes-core-agent_4.0.25-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The component core-agent-linux (including package python2-dnf-plugins-qubes-hooks-4.0.28-1.fc26) has been pushed to the r4.0 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The component core-agent-linux (including package python2-dnf-plugins-qubes-hooks-4.0.28-1.fc26) has been pushed to the r4.0 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.0 stable repository for the Fedora centos7 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.0 stable repository for the Fedora centos7 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package qubes-core-agent_4.0.28-1+deb9u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package qubes-core-agent_4.0.28-1+deb9u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update