New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-revert-template-changes tool #223

Closed
marmarek opened this Issue Mar 8, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@marmarek
Member

marmarek commented Mar 8, 2015

Reported by joanna on 14 Apr 2011 21:46 UTC
Currently we do auto-commit for the template changes, so that whenever the user shuts down a template VM, all the changes are automatically committed.

However, it would actually be better if we could display a dialog box on template shutdown asking the user if he or she intends to commit or discard the changes just introduced to the template.

Migrated-From: https://wiki.qubes-os.org/ticket/223

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 25 Apr 2011 14:19 UTC
https://wiki.qubes-os.org/trac/ticket/96

Originally there was dialog box and this was bad. Now there is no dialog box and also this is bad...

I think there is another way to solve the true problem - easy way to rollback last changes. This can be separate tool (qvm-template-rollback) which will do the work (as described in full procedure some time ago in email).

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 25 Apr 2011 14:19 UTC
https://wiki.qubes-os.org/trac/ticket/96

Originally there was dialog box and this was bad. Now there is no dialog box and also this is bad...

I think there is another way to solve the true problem - easy way to rollback last changes. This can be separate tool (qvm-template-rollback) which will do the work (as described in full procedure some time ago in email).

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 25 Apr 2011 14:23 UTC
Hm, I don't think that originally there was a dialog box to confirm the changes... IIRC, originally the user had to do qvm-comit-template or press the comit button in the mamanger. Any of this was just too easy to forget about.

Anyway, perhaps doing the default commit, but also having such a rollback tool might be the best solution (plus a rollback button in the manager).

Member

marmarek commented Mar 8, 2015

Comment by joanna on 25 Apr 2011 14:23 UTC
Hm, I don't think that originally there was a dialog box to confirm the changes... IIRC, originally the user had to do qvm-comit-template or press the comit button in the mamanger. Any of this was just too easy to forget about.

Anyway, perhaps doing the default commit, but also having such a rollback tool might be the best solution (plus a rollback button in the manager).

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Modified by marmarek on 23 May 2011 16:31 UTC

Member

marmarek commented Mar 8, 2015

Modified by marmarek on 23 May 2011 16:31 UTC

@marmarek marmarek assigned marmarek and unassigned rootkovska Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 28 May 2011 09:11 UTC
Changes title to match what we agreed on above.

Member

marmarek commented Mar 8, 2015

Comment by joanna on 28 May 2011 09:11 UTC
Changes title to match what we agreed on above.

@marmarek marmarek changed the title from Ask user whether to commit template changes after template shutdown to qvm-revert-template-changes tool Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment

@marmarek marmarek closed this Mar 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment