Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upqvm-revert-template-changes tool #223
Comments
marmarek
assigned
rootkovska
Mar 8, 2015
marmarek
added this to the Release 1 Beta 2 milestone
Mar 8, 2015
marmarek
added
enhancement
C: core
P: major
labels
Mar 8, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by marmarek on 25 Apr 2011 14:19 UTC
https://wiki.qubes-os.org/trac/ticket/96
Originally there was dialog box and this was bad. Now there is no dialog box and also this is bad...
I think there is another way to solve the true problem - easy way to rollback last changes. This can be separate tool (qvm-template-rollback) which will do the work (as described in full procedure some time ago in email).
|
Comment by marmarek on 25 Apr 2011 14:19 UTC Originally there was dialog box and this was bad. Now there is no dialog box and also this is bad... I think there is another way to solve the true problem - easy way to rollback last changes. This can be separate tool (qvm-template-rollback) which will do the work (as described in full procedure some time ago in email). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by joanna on 25 Apr 2011 14:23 UTC
Hm, I don't think that originally there was a dialog box to confirm the changes... IIRC, originally the user had to do qvm-comit-template or press the comit button in the mamanger. Any of this was just too easy to forget about.
Anyway, perhaps doing the default commit, but also having such a rollback tool might be the best solution (plus a rollback button in the manager).
|
Comment by joanna on 25 Apr 2011 14:23 UTC Anyway, perhaps doing the default commit, but also having such a rollback tool might be the best solution (plus a rollback button in the manager). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Modified by marmarek on 23 May 2011 16:31 UTC |
marmarek
assigned
marmarek
and unassigned
rootkovska
Mar 8, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by joanna on 28 May 2011 09:11 UTC
Changes title to match what we agreed on above.
|
Comment by joanna on 28 May 2011 09:11 UTC |
marmarek
changed the title from
Ask user whether to commit template changes after template shutdown
to
qvm-revert-template-changes tool
Mar 8, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by marmarek on 10 Jun 2011 16:47 UTC
http://git.qubes-os.org/gitweb/?p=marmarek/core.git;a=commit;h=5cce87c7d2f1dc5b65f147d2920ea5d8826c2492
|
Comment by marmarek on 10 Jun 2011 16:47 UTC |
marmarek commentedMar 8, 2015
Reported by joanna on 14 Apr 2011 21:46 UTC
Currently we do auto-commit for the template changes, so that whenever the user shuts down a template VM, all the changes are automatically committed.
However, it would actually be better if we could display a dialog box on template shutdown asking the user if he or she intends to commit or discard the changes just introduced to the template.
Migrated-From: https://wiki.qubes-os.org/ticket/223