Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDiscrepancy in handling of periods in VM names #2422
Comments
andrewdavidwong
added
bug
C: core
C: qubes-manager
labels
Nov 8, 2016
andrewdavidwong
added this to the Release 3.2 milestone
Nov 8, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
unman
Nov 8, 2016
Member
@3n7r0p1 Yes, there's a discrepancy - it's not the only one. You can also use underscore with qvm-create, but not in Manager. The regexes are slightly different. I don't think it matters. (The command line often offers greater control.)
Yes, using a period will cause issues. DNS uses the period as a delimiter between labels, and various system elements will expect this to be the case. Trivially, the standard prompt will appear as user@a rather than user@a.b . Generally, anything that interacts with DNS will break. Don't do it. (This isn't specific to Qubes.)
|
@3n7r0p1 Yes, there's a discrepancy - it's not the only one. You can also use underscore with qvm-create, but not in Manager. The regexes are slightly different. I don't think it matters. (The command line often offers greater control.) Yes, using a period will cause issues. DNS uses the period as a delimiter between labels, and various system elements will expect this to be the case. Trivially, the standard prompt will appear as user@a rather than user@a.b . Generally, anything that interacts with DNS will break. Don't do it. (This isn't specific to Qubes.) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jpouellet
Nov 11, 2016
Contributor
Additionally underscores are allowed in vm names but not allowed in the creation gui.
https://github.com/QubesOS/qubes-core-admin/blob/master/core-modules/000QubesVm.py#L572
Thought: Reserving a special character not able to be created in the gui would allow qubes-internal VMs (such as foo-dm for HVMs) to never conflict with user-specified domains. This would mean using foo_dm instead of foo-dm as the auto-generated domain for the 'foo' HVM.
|
Additionally underscores are allowed in vm names but not allowed in the creation gui. Thought: Reserving a special character not able to be created in the gui would allow qubes-internal VMs (such as foo-dm for HVMs) to never conflict with user-specified domains. This would mean using foo_dm instead of foo-dm as the auto-generated domain for the 'foo' HVM. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
unman
Nov 11, 2016
Member
@jpouellet Not clear on your proposal -I think you must mean reserving characters that cant be used in gui AND command line? Otherwise you will still have potential for conflict with user-specified names.
|
@jpouellet Not clear on your proposal -I think you must mean reserving characters that cant be used in gui AND command line? Otherwise you will still have potential for conflict with user-specified names. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jpouellet
Nov 11, 2016
Contributor
Not really a proposal so much as an observation.
If I create an HVM named "foo", and a pvm named "foo-dm", and start "foo", then I will be unable to start "foo-dm", because the name is already used internally by qubes. Instead, you get this unhelpful (if you don't already know why) error message:

Qubes internally using _dm instead of -dm would avoid this problem, because users in the gui can not create VMs named ..._dm.
Users on the command line are assumed to not be bothered by such minor user experience things.
added a commit
to jpouellet/qubes-manager
that referenced
this issue
Nov 11, 2016
added a commit
to jpouellet/qubes-core-admin
that referenced
this issue
Nov 11, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Nov 11, 2016
Member
-dm suffix is hardcoded in Xen toolstack, so not something we could easily change. Much easier thing to do for this particular problem, would be to prevent VM to have -dm suffix.
|
|
marmarek
modified the milestones:
Release 3.2,
Release 3.2 updates
Nov 19, 2016
jpouellet
referenced this issue
in QubesOS/qubes-core-admin
Nov 22, 2016
Merged
Don't allow VM name ending in -dm #72
marmarek
closed this
in
marmarek/qubes-core-admin@c4f30bc
Nov 25, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jpouellet
Nov 25, 2016
Contributor
This issue isn't really resolved and IMO is not ready to be closed. There is still a discrepancy in periods (as the OP was about).
There was a reason my commit said "Partially fixes ..."
|
This issue isn't really resolved and IMO is not ready to be closed. There is still a discrepancy in periods (as the OP was about). There was a reason my commit said "Partially fixes ..." |
marmarek
reopened this
Nov 25, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
github: "Partially fixes" still matches "fixes" ;) |
added a commit
to QubesOS/qubes-core-admin
that referenced
this issue
Mar 14, 2017
qubesos-bot
referenced this issue
in QubesOS/updates-status
Mar 16, 2017
Closed
core-admin v3.2.13 (r3.2) #13
andrewdavidwong
referenced this issue
Nov 10, 2017
Open
qvm-clone ProxyVM with '_' char in name produces menu & VM Manager error #3301
added a commit
to marmarta/qubes-manager
that referenced
this issue
Jul 13, 2018
added a commit
to marmarta/qubes-manager
that referenced
this issue
Jul 13, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarta
Jul 13, 2018
I've made it more consistent:
- in R3.2, where dot is allowed in VM names, it will now be also allowed in GUI tools
- in R4.0, where dot is not allowed in VM names, it will not be allowed in GUI tools (but underscore, that should have been allowed but wasn't, will be)
marmarta
commented
Jul 13, 2018
|
I've made it more consistent:
|
entr0py commentedNov 7, 2016
Qubes 3.1
VM Manager does not allow creation of VM's with period in name.
qvm-create allows periods.
Will using a period in VM name cause any issues?