/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device created with `qvm-block -A` not listed as attached #2453

Closed
marmarek opened this Issue Nov 23, 2016 · 0 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Release 3.2 updates
1 participant
@marmarek
@marmarek
Member

marmarek commented Nov 23, 2016

Qubes OS version (e.g., R3.1):

R3.2

Expected behavior:

qvm-block -l list sourcevm:loop0 device as attached to target VM.

Actual behavior:

qvm-block -l see new device, but as unused instead of attached to some VM. It allows attaching the device to another VM at the same time.

Steps to reproduce the behavior:

  1. Create file in some VM (like truncate -s 100M /home/user/test.img)
  2. Attach it to another VM: qvm-block -A another-VM some-VM:/home/user/test.img

General notes:

It the file is created in dom0, it isn't listed by qvm-block at all.

Related issues:

Forked from #2047

@marmarek marmarek added bug C: core P: major labels Nov 23, 2016

@marmarek marmarek added this to the Release 3.2 updates milestone Nov 23, 2016

@marmarek marmarek closed this in marmarek/qubes-linux-utils@db2b027 Nov 23, 2016

marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Nov 23, 2016

@marmarek
qvm-block: fix checking attached status of disk image files 
Libvirt do not show actual block device (loop*) choosen for the device -
only original (file) path. But file path is available in device
description. Please note that VM can provide any description (withing
allowed limits), effectively breaking this check again (hidding the
attachment status). But even without this bug it could do that - by
hidding the whole device from QubesDB.

Fixes QubesOS/qubes-issues#2453
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
ba4dec5

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Mar 14, 2017

@marmarek
qvm-block: fix checking attached status of disk image files 
Libvirt do not show actual block device (loop*) choosen for the device -
only original (file) path. But file path is available in device
description. Please note that VM can provide any description (withing
allowed limits), effectively breaking this check again (hidding the
attachment status). But even without this bug it could do that - by
hidding the whole device from QubesDB.

Fixes QubesOS/qubes-issues#2453

(cherry picked from commit ba4dec5)
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
05960cd

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Mar 16, 2017

Closed

core-admin v3.2.13 (r3.2) #13

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Mar 23, 2017

Closed

linux-utils v3.2.4 (r3.2) #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment