/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-move-to-vm removes unrelated files #2472

Closed
marmarek opened this Issue Dec 2, 2016 · 17 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Release 3.1 updates
3 participants
@marmarek @rustybird @qubesos-bot
@marmarek
Member

marmarek commented Dec 2, 2016

Qubes OS version (e.g., R3.1):

R3.2

Affected TemplateVMs (e.g., fedora-23, if applicable):

all

Expected behavior:

qvm-move-to-vm should send required files to other VM and then (after successful operation) remove them locally.

Actual behavior:

File/directory named after target VM is removed too.

Steps to reproduce the behavior:

  1. Create directory named after target VM, or have one already with very important files inside. In my case I was in qubes-builder, which have doc directory.
  2. Execute qvm-move-to-vm, like this: qvm-move-to-vm doc some-unrelated-file
  3. Observe that your doc directory is gone.

General notes:

qvm-move-to-vm:

. qvm-copy-to-vm "$@" &&
rm -rf -- "$@"

$@ is all arguments, including target VM name.

@marmarek marmarek added bug C: core P: major labels Dec 2, 2016

@marmarek marmarek added this to the Release 3.1 updates milestone Dec 2, 2016

@rustybird

This comment has been minimized.

Show comment
Hide comment
@rustybird

rustybird Dec 4, 2016

Shit, will fix this ASAP

rustybird commented Dec 4, 2016

Shit, will fix this ASAP

rustybird added a commit to rustybird/qubes-core-admin-linux that referenced this issue Dec 4, 2016

@rustybird
(dom0) qvm-move-to-vm: don't "rm -rf" vm name argument 
Fixes QubesOS/qubes-issues#2472 from commit
bc29af7
Verified
This commit was signed with a verified signature.
@rustybird rustybird Rusty Bird
GPG key ID: 469D78F47AAF2ADF Learn about signing commits
519b088

This was referenced Dec 4, 2016

Closed
Closed

This was referenced Dec 4, 2016

Merged
Merged
@rustybird

This comment has been minimized.

Show comment
Hide comment
@rustybird

rustybird Dec 4, 2016

The v2 pull requests make qvm-move-to-vm a symlink to qvm-copy-to-vm, which removes the files (or not) depending on the last component of $0. This way, it doesn't matter if qvm-copy-to-vm accepts additional arguments, such as --without-progress.

Sorry for introducing this bug!

rustybird commented Dec 4, 2016

The v2 pull requests make qvm-move-to-vm a symlink to qvm-copy-to-vm, which removes the files (or not) depending on the last component of $0. This way, it doesn't matter if qvm-copy-to-vm accepts additional arguments, such as --without-progress.

Sorry for introducing this bug!

@marmarek marmarek closed this in marmarek/old-qubes-core-agent-linux@0d24325 Dec 4, 2016

marmarek added a commit to QubesOS/qubes-core-agent-linux that referenced this issue Dec 4, 2016

@rustybird @marmarek
v2: (vm) qvm-move-to-vm: don't "rm -rf" vm name argument 
Fixes QubesOS/qubes-issues#2472 from commit
3f600d0

(cherry picked from commit 0d24325)
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
214105a
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 4, 2016

Member

Thanks @rustybird for prompt fix!
Member

marmarek commented Dec 4, 2016

Thanks @rustybird for prompt fix!
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 5, 2016

Member

Automated announcement from builder-github

The package qubes-core-agent_3.1.20-1+deb8u1 has been pushed to the r3.1 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update
Member

marmarek commented Dec 5, 2016

Automated announcement from builder-github

The package qubes-core-agent_3.1.20-1+deb8u1 has been pushed to the r3.1 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@marmarek marmarek added the r3.1-jessie-cur-test label Dec 5, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 5, 2016

Member

Automated announcement from builder-github

The package qubes-core-agent_3.1.20-1+deb9u1 has been pushed to the r3.1 testing repository for the Debian stretch template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update
Member

marmarek commented Dec 5, 2016

Automated announcement from builder-github

The package qubes-core-agent_3.1.20-1+deb9u1 has been pushed to the r3.1 testing repository for the Debian stretch template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@marmarek marmarek added the r3.1-stretch-cur-test label Dec 5, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 5, 2016

Member

Automated announcement from builder-github

The package qubes-core-agent_3.1.20-1+deb7u1 has been pushed to the r3.1 testing repository for the Debian wheezy template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing wheezy-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update
Member

marmarek commented Dec 5, 2016

Automated announcement from builder-github

The package qubes-core-agent_3.1.20-1+deb7u1 has been pushed to the r3.1 testing repository for the Debian wheezy template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing wheezy-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@marmarek marmarek added the r3.1-wheezy-cur-test label Dec 5, 2016

@rustybird

This comment has been minimized.

Show comment
Hide comment
@rustybird

rustybird Dec 5, 2016

Please reopen, this was closed prematurely by the vm PR's commit message. The dom0 PR is still pending: QubesOS/qubes-core-admin-linux#16

rustybird commented Dec 5, 2016

Please reopen, this was closed prematurely by the vm PR's commit message. The dom0 PR is still pending: QubesOS/qubes-core-admin-linux#16

@marmarek marmarek reopened this Dec 5, 2016

@marmarek marmarek closed this in marmarek/qubes-core-admin-linux@4d18800 Dec 6, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 6, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.2.11-1.fc23 has been pushed to the r3.2 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update
Member

marmarek commented Dec 6, 2016

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.2.11-1.fc23 has been pushed to the r3.2 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@marmarek marmarek added the r3.2-dom0-cur-test label Dec 6, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 12, 2016

Member

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.2.15-1.fc23 has been pushed to the r3.2 testing repository for the Fedora fc23 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.2-current-testing

Changes included in this update
Member

marmarek commented Dec 12, 2016

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.2.15-1.fc23 has been pushed to the r3.2 testing repository for the Fedora fc23 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.2-current-testing

Changes included in this update

@marmarek marmarek added the r3.2-fc23-cur-test label Dec 12, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 12, 2016

Member

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.2.15-1.fc24 has been pushed to the r3.2 testing repository for the Fedora fc24 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.2-current-testing

Changes included in this update
Member

marmarek commented Dec 12, 2016

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.2.15-1.fc24 has been pushed to the r3.2 testing repository for the Fedora fc24 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.2-current-testing

Changes included in this update

@marmarek marmarek added the r3.2-fc24-cur-test label Dec 12, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 12, 2016

Member

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.2.15-1.fc25 has been pushed to the r3.2 testing repository for the Fedora fc25 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.2-current-testing

Changes included in this update
Member

marmarek commented Dec 12, 2016

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.2.15-1.fc25 has been pushed to the r3.2 testing repository for the Fedora fc25 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.2-current-testing

Changes included in this update

@marmarek marmarek added the r3.2-fc25-cur-test label Dec 12, 2016

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jan 8, 2017

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.2.15-1.fc23 has been pushed to the r3.2 stable repository for the Fedora fc23 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

qubesos-bot commented Jan 8, 2017

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.2.15-1.fc23 has been pushed to the r3.2 stable repository for the Fedora fc23 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot qubesos-bot added r3.2-fc23-stable and removed r3.2-fc23-cur-test labels Jan 8, 2017

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jan 8, 2017

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.2.15-1.fc24 has been pushed to the r3.2 stable repository for the Fedora fc24 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

qubesos-bot commented Jan 8, 2017

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.2.15-1.fc24 has been pushed to the r3.2 stable repository for the Fedora fc24 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot qubesos-bot added r3.2-fc24-stable and removed r3.2-fc24-cur-test labels Jan 8, 2017

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jan 8, 2017

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.2.15-1.fc25 has been pushed to the r3.2 stable repository for the Fedora fc25 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

qubesos-bot commented Jan 8, 2017

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.2.15-1.fc25 has been pushed to the r3.2 stable repository for the Fedora fc25 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot qubesos-bot removed the r3.2-fc25-cur-test label Jan 8, 2017

@qubesos-bot qubesos-bot added the r3.2-fc25-stable label Jan 8, 2017

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jan 8, 2017

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.2.11-1.fc23 has been pushed to the r3.2 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

qubesos-bot commented Jan 8, 2017

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.2.11-1.fc23 has been pushed to the r3.2 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@qubesos-bot qubesos-bot added r3.2-dom0-stable and removed r3.2-dom0-cur-test labels Jan 8, 2017

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jan 8, 2017

Automated announcement from builder-github

The package qubes-core-agent_3.2.15-1+deb8u1 has been pushed to the r3.2 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot commented Jan 8, 2017

Automated announcement from builder-github

The package qubes-core-agent_3.2.15-1+deb8u1 has been pushed to the r3.2 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot qubesos-bot added the r3.2-jessie-cur-test label Jan 8, 2017

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jan 8, 2017

Automated announcement from builder-github

The package qubes-core-agent_3.2.15-1+deb9u1 has been pushed to the r3.2 testing repository for the Debian stretch template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot commented Jan 8, 2017

Automated announcement from builder-github

The package qubes-core-agent_3.2.15-1+deb9u1 has been pushed to the r3.2 testing repository for the Debian stretch template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot qubesos-bot added the r3.2-stretch-cur-test label Jan 8, 2017

@marmarek marmarek referenced this issue Oct 1, 2017

Closed

qvm-copy-to-vm useless target parameter #3141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment