Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upHarcoded Whonix template names used in Qubes scripts #2490
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Dec 6, 2016
Member
Can you spot anything else? Because those two places are totally ok. It's about automated tests, where environment is strictly controlled and it's ok to require some particular names of templates/VMs.
Also, this is about looking at those templates from dom0, where you can't easily check those markers (without starting the template).
Quick grep yields no other in-VM places detecting Whonix by name.
|
Can you spot anything else? Because those two places are totally ok. It's about automated tests, where environment is strictly controlled and it's ok to require some particular names of templates/VMs. Quick grep yields no other in-VM places detecting Whonix by name. |
entr0py commentedDec 5, 2016
•
edited
Edited 1 time
-
entr0py
edited Dec 5, 2016 (most recent)
Qubes OS version (e.g.,
R3.2):all
Affected TemplateVMs (e.g.,
fedora-23, if applicable):Whonix
Expected behavior:
Whonix templates should be identified by markers and not by their names since it is not a requirement for templates to be kept using default names (whonix-gw, whonix-ws)
@adrelanos suggests using markers:
Actual behavior:
Some scripts check template name to identify Whonix templates.
Example commits:
QubesOS/qubes-app-linux-split-gpg@ead80b1
QubesOS/qubes-app-linux-split-gpg@1a22a2f
Further work is required to identify additional scripts.