New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB mouse works without approval #2491

Closed
starius opened this Issue Dec 6, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@starius

starius commented Dec 6, 2016

Qubes OS version: R3.2.

When I plugged in my USB mouse, it became usable without any approval from me. I think, it smells like a security problem. I have not tested a keyboard, but if it works in the same manner, it is even worse. A malicious USB device can pretend to be a mouse and tamper user's activity in dom0 (e.g., open Qubes VM manager or some application, reboot physical machine).

Note: if the OS requested an approval for all USB devices, there would be a chicken-and-egg problem with requesting an approval for a keyboard if there is only one keyboard and it is the USB keyboard in question. It can be solved by pre-approving some devices during the installation (explicitly asking a user to choose which devices to trust).

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Dec 6, 2016

Member

I think enabling mouse input by default if the user opts to create a USB qube is an intentional design decision related to issue #1930. Is that right, @marmarek?

@starius, just so you know, you can edit your own policy however you see fit in /etc/qubes-rpc/policy/qubes.InputMouse.

Member

andrewdavidwong commented Dec 6, 2016

I think enabling mouse input by default if the user opts to create a USB qube is an intentional design decision related to issue #1930. Is that right, @marmarek?

@starius, just so you know, you can edit your own policy however you see fit in /etc/qubes-rpc/policy/qubes.InputMouse.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 6, 2016

Member
Member

marmarek commented Dec 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment