Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMore colors in VM settings or possibility to add colors (only 8 at the moment) #2523
Comments
andrewdavidwong
added this to the Far in the future milestone
Dec 17, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
grey-olli
commented
Feb 12, 2017
|
Could anyone point into source where changes to be impemented? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jpouellet
Feb 12, 2017
Contributor
Unfortunately there are many places where the current labels are hard-coded, so this is not a trivial task.
I think the master list is intended to be the list in core-admin/core/qubes.py, but simply adding to that list would not be sufficient.
If you wish to work on this, I suggest you start by eliminating the other places in the codebase which hard-code labels. These can be found with e.g. grep -r purple qubes-src from a checked-out qubes-builder repo.
There have also been proposals to add different patterns instead of simply more colors, and I personally think that approach would be more useful for those of us with many VMs.
|
Unfortunately there are many places where the current labels are hard-coded, so this is not a trivial task. I think the master list is intended to be the list in core-admin/core/qubes.py, but simply adding to that list would not be sufficient. If you wish to work on this, I suggest you start by eliminating the other places in the codebase which hard-code labels. These can be found with e.g. There have also been proposals to add different patterns instead of simply more colors, and I personally think that approach would be more useful for those of us with many VMs. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
unman
Feb 19, 2017
Member
I would defer to those who specialise in user interfaces. I don't.
But I have worked on a number of projects where we have used expensive consultants who do specialise in that area. Their advice has always been to keep the number of colours to the minimum, particularly where this has significant consequences for the user. The advice has usually been to use no more than 7 or 8 colours.
In Qubes the use of colour obviously has significant consequences.
I'm opposed not just because people are far worse at discriminating between a range of colours than you would think. It's because they are being asked to identify, and give significance to, a particular colour when it isnt part of a range. I mean that if you see a colour as part of a colour chart you may be able to call it out, but when presented with a sample on its own then it isn't so easy to do so.
An added problem in Qubes is that we allow users to customise their desktops by changing wallpaper and/or background colour. Colour perception is very much influenced by background, so the users ability to differentiate similar colours may be adversely affected by their choice here.
For these reasons I would argue against the proposal, but as I've said, I'm happy to defer to those who have expertise in this area.
There is one change that I would like to see, which I think has been mentioned on the mailing lists in the past. The current colour choices are not suitable for those with some degree of colour blindness - it wouldn't take much to change them to a range which was colourblind safe.
Note that, by using different workspaces with colour coded backgrounds, the existing 7 choices (8 if black is included) can be simply extended to differentiate a larger number of VMs. wmctrl is installed by default in dom0 and can be used to help with such a set-up. I'd recommend that as the way to go.
|
I would defer to those who specialise in user interfaces. I don't. I'm opposed not just because people are far worse at discriminating between a range of colours than you would think. It's because they are being asked to identify, and give significance to, a particular colour when it isnt part of a range. I mean that if you see a colour as part of a colour chart you may be able to call it out, but when presented with a sample on its own then it isn't so easy to do so. For these reasons I would argue against the proposal, but as I've said, I'm happy to defer to those who have expertise in this area. Note that, by using different workspaces with colour coded backgrounds, the existing 7 choices (8 if black is included) can be simply extended to differentiate a larger number of VMs. wmctrl is installed by default in dom0 and can be used to help with such a set-up. I'd recommend that as the way to go. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
grey-olli
Feb 22, 2017
grey-olli
commented
Feb 22, 2017
|
On Sat, Feb 18, 2017 at 9:27 PM, unman ***@***.***> wrote:
I would defer to those who specialise in user interfaces. I don't.
But I have worked on a number of projects where we have used expensive
consultants who *do* specialise in that area. Their advice has always
been to keep the number of colours to the minimum, particularly where this
has significant consequences for the user. The advice has usually been to
use no more than 7 or 8 colours.
In Qubes the use of colour obviously has significant consequences.
Currently I can't separate two similar contexts for two different companies
neither by desktop bindings nor by colors.
If desktop bindings will be implemented, when some activity cannot appear
on same desktop w/ another activity separation will be easier. Though, I'd
like to have more colors anyway and hope to have time to get this patched
at least for myself . AFAIK I'm not the only person who wants more colors.
I'm opposed not just because people are far worse at discriminating
between a range of colours than you would think. It's because they are
being asked to identify, and give significance to, a particular colour when
it *isnt* part of a range. I mean that if you see a colour as part of a
colour chart you may be able to call it out, but when presented with a
sample on its own then it isn't so easy to do so.
Agree. Though what are alternatives? When I've same colors for different
activities that is not better than have a little different colors.
An added problem in Qubes is that we allow users to customise their
desktops by changing wallpaper and/or background colour.
And that "problem" I'd like to keep as a nice ability common for all window
managers. :) Guess I'm not alone w/ this.
Colour perception is very much influenced by background, so the users
ability to differentiate similar colours may be adversely affected by their
choice here.
Software developers can't make users "never misbehave". When you set green
phone and can't see green
For these reasons I would argue against the proposal, but as I've said, I'm
… happy to defer to those who have expertise in this area.
There is one change that I would like to see, which I think has been
mentioned on the mailing lists in the past. The current colour choices are
not suitable for those with some degree of colour blindness - it wouldn't
take much to change them to a range which was colourblind safe.
Note that, by using different workspaces with colour coded backgrounds,
the existing 7 choices (8 if black is included) can be simply extended to
differentiate a larger number of VMs. wmctrl is installed by default in
dom0 and can be used to help with such a set-up. I'd recommend that as the
way to go.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2523 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALHcA5RVgsg-ccBCOKV2lyNjq-S0tGhwks5rd6ijgaJpZM4LP65b>
.
--
Bye.Olli.
gpg --search-keys grey_olli , use key w/ fingerprint below:
Key fingerprint = 9901 6808 768C 8B89 544C 9BE0 49F9 5A46 2B98 147E
Blog keys (the blog is mostly in Russian): http://grey-olli.livejournal.
com/tag/
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
grey-olli
Feb 22, 2017
grey-olli
commented
Feb 22, 2017
|
On Wed, Feb 22, 2017 at 8:40 AM, Oleg Artemiev <grey.olli@gmail.com> wrote:
Sorry - two ctrl-enter sent before I finalized my letter
Currently I can't separate two similar contexts for two different
companies neither by desktop bindings nor by colors.
If desktop bindings will be implemented, when some activity cannot appear
on same desktop w/ another activity separation will be easier. Though, I'd
like to have more colors anyway and hope to have time to get this patched
at least for myself . AFAIK I'm not the only person who wants more colors.
Colour perception is very much influenced by background, so the users
ability to differentiate similar colours may be adversely affected by their
choice here.
When some popup razes on top of current application, most often it is not
hovering background - it is hovering current VM window and foreign to Qubes
application picture is not what we could control or should alter.
Coloring is good to differ popup from some other VM to popup from current
VM. There're two color separation context - one VM to another VM and two
similar full screen or non-full screen programs opened on difrent desktops.
Software developers can't make users "never misbehave". When you set green
background and can't see green window captions that is not developer
problem.
And this doesn't seem to be design problem - programmers allow users delete
their data. If user misbehave and deletes his data - is this a developer
problem? If developer made a confirmation note - no - this is exactly user
misbehave.
For these reasons I would argue against the proposal, but as I've said,
> I'm happy to defer to those who have expertise in this area
>
I'm not sure I'll make a patch, but I'm sure I need ability to separate
more contexts than I'm able now. I'm not claiming that should go via
coloring - binding VM activities to desktops is another alternative.
There is one change that I would like to see, which I think has been
> mentioned on the mailing lists in the past. The current colour choices are
> not suitable for those with some degree of colour blindness - it wouldn't
> take much to change them to a range which was colourblind safe.
>
I guess beter ides is not a single color for those people, but a different
"zebra/pedestrian" styles (i.e color blind people are okay w/ contrast and
thus should be able to differ a set of black and white shades like
"|\|\|\|\|" and " | | | | ",
Note that, by using different workspaces with colour coded backgrounds,
> the existing 7 choices (8 if black is included) can be simply extended to
> differentiate a larger number of VMs. wmctrl is installed by default in
> dom0 and can be used to help with such a set-up. I'd recommend that as the
> way to go.
>
We need strict bindings VM<->desktop from VM configuration in Qubes VM
manger then.
Restricting background color for a desktop should be optional - full screen
mode windows hide background at all (at least I usually do full screen).
…--
Bye.Olli.
gpg --search-keys grey_olli , use key w/ fingerprint below:
Key fingerprint = 9901 6808 768C 8B89 544C 9BE0 49F9 5A46 2B98 147E
Blog keys (the blog is mostly in Russian): http://grey-olli.livejournal.c
om/tag/
--
Bye.Olli.
gpg --search-keys grey_olli , use key w/ fingerprint below:
Key fingerprint = 9901 6808 768C 8B89 544C 9BE0 49F9 5A46 2B98 147E
Blog keys (the blog is mostly in Russian):
http://grey-olli.livejournal.com/tag/
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
woju
Feb 22, 2017
Member
For R3.2 this probably will remain as is. For R4.0, the list of labels is in qubes.xml and only the initialisation is hardcoded: https://github.com/QubesOS/qubes-core-admin/blob/core3-devel/qubes/app.py#L852-L861. There is however neither tool nor API to change that, apart from directly editing XML. @andrewdavidwong Is there a reason to change that approach? If not, we can close this bug.
|
For R3.2 this probably will remain as is. For R4.0, the list of labels is in |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
grey-olli
Feb 22, 2017
grey-olli
commented
Feb 22, 2017
|
On Wed, Feb 22, 2017 at 9:05 PM, Wojtek Porczyk ***@***.***> wrote:
For R3.2 this probably will remain as is.
Means useless to try to make a patch within nearest 2-3 months?
For R4.0, the list of labels is in qubes.xml and only the initialisation
is hardcoded: https://github.com/QubesOS/qubes-core-admin/blob/core3-
devel/qubes/app.py#L852-L861. There is however neither tool nor API to
change that, apart from directly editing XML. @andrewdavidwong
<https://github.com/andrewdavidwong> Is there a reason to change that
approach? If not, we can close this bug.
My +1cent: this should definitely be switched from "bug" to "feature
request" for 4.0 and got documented.
My idea is a standard-looking color picker . If it's too effort-costly to
add it in Qubes VM manager - make VM color picker to be a separate dom0
tool + note it in documentation.
…--
Bye.Olli.
gpg --search-keys grey_olli , use key w/ fingerprint below:
Key fingerprint = 9901 6808 768C 8B89 544C 9BE0 49F9 5A46 2B98 147E
Blog keys (the blog is mostly in Russian):
http://grey-olli.livejournal.com/tag/
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
woju
Feb 22, 2017
Member
|
On Wed, Feb 22, 2017 at 10:44:34AM -0800, grey-olli wrote:
On Wed, Feb 22, 2017 at 9:05 PM, Wojtek Porczyk ***@***.***>
wrote:
> For R3.2 this probably will remain as is.
>
Means useless to try to make a patch within nearest 2-3 months?
For R3.2, yes. This work is already done, so there is no need to duplicate
that. And no-one would find that of much use anyway.
> For R4.0, the list of labels is in qubes.xml and only the initialisation
> is hardcoded: https://github.com/QubesOS/qubes-core-admin/blob/core3-
> devel/qubes/app.py#L852-L861. There is however neither tool nor API to
> change that, apart from directly editing XML. @andrewdavidwong
> <https://github.com/andrewdavidwong> Is there a reason to change that
> approach? If not, we can close this bug.
>
My +1cent: this should definitely be switched from "bug" to "feature
request" for 4.0 and got documented.
My idea is a standard-looking color picker . If it's too effort-costly to
add it in Qubes VM manager - make VM color picker to be a separate dom0
tool + note it in documentation.
Not at all. This is intentionally obscure for reasons extensively summed up by
@unman. I'd label that "wontfix".
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Feb 23, 2017
Member
We need to defer to the UX experts on this one. Since we don't have any to offer a firsthand analysis of this problem, I'm inclined to defer to @unman's report.
|
We need to defer to the UX experts on this one. Since we don't have any to offer a firsthand analysis of this problem, I'm inclined to defer to @unman's report. |
andrewdavidwong
closed this
Feb 23, 2017
andrewdavidwong
added
the
wontfix
label
Feb 23, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Feb 23, 2017
Member
For what it's worth, I want to acknowledge that the problem @grey-olli is experiencing is a legitimate one. With a large number of VMs, it becomes difficult to distinguish them, given a limited number of colors. However, it doesn't follow that adding more and more colors (or even building a tool that allows the user to do so) is the correct solution. For the reasons @unman points out, that's likely to backfire and ultimately harm the user instead. This calls for a more creative solution.
|
For what it's worth, I want to acknowledge that the problem @grey-olli is experiencing is a legitimate one. With a large number of VMs, it becomes difficult to distinguish them, given a limited number of colors. However, it doesn't follow that adding more and more colors (or even building a tool that allows the user to do so) is the correct solution. For the reasons @unman points out, that's likely to backfire and ultimately harm the user instead. This calls for a more creative solution. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Feb 23, 2017
Member
I've created #2646 to encourage ideas for such a creative solution.
|
I've created #2646 to encourage ideas for such a creative solution. |
ghost commentedDec 17, 2016
Qubes OS version:
R3.2