/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Restore functionality of disable-default-route and disable-dns-server. #2551

Closed
gr-g opened this Issue Jan 3, 2017 · 4 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Release 3.2 updates
3 participants
@gr-g @andrewdavidwong @marmarek
@gr-g

gr-g commented Jan 3, 2017 •
edited
Edited 1 time
  • @gr-g gr-g edited Jan 3, 2017 (most recent)

0001-Restore-functionality-of-disable-default-route-and-d.txt

Qubes OS version (e.g., R3.2): R3.2

Recently (after the R3.2 release) I noticed that the service "disable-dns-server" documented here was not working anymore. Even with the service enabled in a VM configuration, iptables rules for forwarding DNS queries were still created.

I tracked down the issue to this commit in qubes-core-agent-linux: link.
Apparently the commit replaced some instances of this test
if [ "x$disablegw" != "x1" ]"
with this:
if ! qsvc disable-default-route
(and similarly for dns) but left some references to $disablegw and $disabledns in other places.

The attached patch fixes the problem for me. After applying it, the behaviour of disable-dns-server and disable-default-route is as expected.
@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Jan 4, 2017

Member

Thanks, @gr-g! If you prefer, you can submit this as a pull request against qubes-core-agent-linux instead.
Member

andrewdavidwong commented Jan 4, 2017

Thanks, @gr-g! If you prefer, you can submit this as a pull request against qubes-core-agent-linux instead.

@andrewdavidwong andrewdavidwong added C: core enhancement labels Jan 4, 2017

@andrewdavidwong andrewdavidwong added this to the Release 3.2 updates milestone Jan 4, 2017

@gr-g

This comment has been minimized.

Show comment
Hide comment
@gr-g

gr-g Jan 4, 2017

gr-g commented Jan 4, 2017

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Jan 5, 2017

Member

@marmarek: Please feel free to merge this (or ask for followup interaction) as you see fit.
Member

andrewdavidwong commented Jan 5, 2017

@marmarek: Please feel free to merge this (or ask for followup interaction) as you see fit.
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 19, 2017

Member

Merged and already included in qubes-core-agent 3.2.16.
Member

marmarek commented Mar 19, 2017

Merged and already included in qubes-core-agent 3.2.16.

@marmarek marmarek closed this Mar 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment