New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split-gpg for git broken on Debian stretch #2582

Closed
adrelanos opened this Issue Jan 15, 2017 · 23 comments

Comments

@adrelanos
Member

adrelanos commented Jan 15, 2017

Qubes OS version (e.g., R3.2):

R3.2 with testing repository

Affected TemplateVMs (e.g., fedora-23, if applicable):

debian-stretch


Expected behavior:

git log --show-signature

Should just work.

Actual behavior:

qubes-gpg-client: unrecognized option '--keyid-format=long'

Steps to reproduce the behavior:

Change the template of a fronted and backed VM using split-gpg from debian-8 to debian-stretch.

General notes:

stretch comes with gpg 2.1 only. gpg 1.x is not available. (The gnupg and gnupg2 package are the same.)

@WillyPillow

This comment has been minimized.

Show comment
Hide comment
@WillyPillow

WillyPillow Jan 23, 2017

I just ran into this issue with stretch as the frontend and jessie as the backend, and came up with a quick hack as a temporary solution.

Basically I made the wrapper ignore the --keyid-format option by adding the following lines in the parsing part of /usr/bin/qubes-gpg-client-wrapper:

--keyid-format=long)
  shift
  ;;

I just ran into this issue with stretch as the frontend and jessie as the backend, and came up with a quick hack as a temporary solution.

Basically I made the wrapper ignore the --keyid-format option by adding the following lines in the parsing part of /usr/bin/qubes-gpg-client-wrapper:

--keyid-format=long)
  shift
  ;;
@tasket

This comment has been minimized.

Show comment
Hide comment
@tasket

tasket Jul 18, 2017

Ran into this also with git tag -v. A little surprised split-gpg is still tooled for GPG 1.x.

Used @WillyPillow 's workaround.

What should the fix look like? I noticed that Fedora 25 comes with gpg2 by default.

tasket commented Jul 18, 2017

Ran into this also with git tag -v. A little surprised split-gpg is still tooled for GPG 1.x.

Used @WillyPillow 's workaround.

What should the fix look like? I noticed that Fedora 25 comes with gpg2 by default.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 18, 2017

Member

A little surprised split-gpg is still tooled for GPG 1.x.

That would mean you use really old version (QubesOS/qubes-app-linux-split-gpg@3bb1f8e). Maybe you have updated version in /etc/qubes-rpc/qubes.Gpg.dpkg-new file?

Member

marmarek commented Jul 18, 2017

A little surprised split-gpg is still tooled for GPG 1.x.

That would mean you use really old version (QubesOS/qubes-app-linux-split-gpg@3bb1f8e). Maybe you have updated version in /etc/qubes-rpc/qubes.Gpg.dpkg-new file?

@tasket

This comment has been minimized.

Show comment
Hide comment
@tasket

tasket Jul 18, 2017

There are no *dpkg-new in that folder and the file uses gpg2. The qubes-gpg-split package version is 2.0.25-1+deb9u1.

But the issue is in qubes-gpg-client-wrapper or gpg-server, I think..?

tasket commented Jul 18, 2017

There are no *dpkg-new in that folder and the file uses gpg2. The qubes-gpg-split package version is 2.0.25-1+deb9u1.

But the issue is in qubes-gpg-client-wrapper or gpg-server, I think..?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 18, 2017

Member

Hmm, if your /etc/qubes-rpc/qubes.Gpg have "gpg2", what part use gpg 1.x? How exactly you come to that conclusion?

Member

marmarek commented Jul 18, 2017

Hmm, if your /etc/qubes-rpc/qubes.Gpg have "gpg2", what part use gpg 1.x? How exactly you come to that conclusion?

@tasket

This comment has been minimized.

Show comment
Hide comment
@tasket

tasket Jul 18, 2017

Re: gpg 1.x, I thought the original issue notes implied there was a version mismatch somewhere.

Real bug is probably here:
https://github.com/QubesOS/qubes-app-linux-split-gpg/blob/master/src/gpg-common.h

The keyid-format is not an included option so qubes-gpg-client rejects the call.

tasket commented Jul 18, 2017

Re: gpg 1.x, I thought the original issue notes implied there was a version mismatch somewhere.

Real bug is probably here:
https://github.com/QubesOS/qubes-app-linux-split-gpg/blob/master/src/gpg-common.h

The keyid-format is not an included option so qubes-gpg-client rejects the call.

@marmarek marmarek referenced this issue in QubesOS/qubes-app-linux-split-gpg Jul 24, 2017

Merged

Add options to whitelist #10

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 26, 2017

Automated announcement from builder-github

The package qubes-gpg-split-dom0-2.0.26-1.fc23 has been pushed to the r3.2 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Automated announcement from builder-github

The package qubes-gpg-split-dom0-2.0.26-1.fc23 has been pushed to the r3.2 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jul 26, 2017

Closed

app-linux-split-gpg v2.0.26 (r3.2) #147

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 26, 2017

Automated announcement from builder-github

The package qubes-gpg-split-dom0-2.0.26-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Automated announcement from builder-github

The package qubes-gpg-split-dom0-2.0.26-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jul 26, 2017

Closed

app-linux-split-gpg v2.0.26 (r4.0) #148

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 26, 2017

Automated announcement from builder-github

The package qubes-gpg-split-2.0.26-1.fc23 has been pushed to the r3.2 testing repository for the Fedora fc23 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.2-current-testing

Changes included in this update

Automated announcement from builder-github

The package qubes-gpg-split-2.0.26-1.fc23 has been pushed to the r3.2 testing repository for the Fedora fc23 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.2-current-testing

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 26, 2017

Automated announcement from builder-github

The package qubes-gpg-split-2.0.26-1.fc24 has been pushed to the r3.2 testing repository for the Fedora fc24 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.2-current-testing

Changes included in this update

Automated announcement from builder-github

The package qubes-gpg-split-2.0.26-1.fc24 has been pushed to the r3.2 testing repository for the Fedora fc24 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.2-current-testing

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 26, 2017

Automated announcement from builder-github

The package qubes-gpg-split-2.0.26-1.fc25 has been pushed to the r3.2 testing repository for the Fedora fc25 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.2-current-testing

Changes included in this update

Automated announcement from builder-github

The package qubes-gpg-split-2.0.26-1.fc25 has been pushed to the r3.2 testing repository for the Fedora fc25 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.2-current-testing

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 26, 2017

Automated announcement from builder-github

The package qubes-gpg-split-2.0.26-1.fc24 has been pushed to the r4.0 testing repository for the Fedora fc24 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

Automated announcement from builder-github

The package qubes-gpg-split-2.0.26-1.fc24 has been pushed to the r4.0 testing repository for the Fedora fc24 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 26, 2017

Automated announcement from builder-github

The package qubes-gpg-split-2.0.26-1.fc25 has been pushed to the r4.0 testing repository for the Fedora fc25 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

Automated announcement from builder-github

The package qubes-gpg-split-2.0.26-1.fc25 has been pushed to the r4.0 testing repository for the Fedora fc25 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 26, 2017

Automated announcement from builder-github

The package qubes-gpg-split_2.0.26-1+deb8u1 has been pushed to the r3.2 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Automated announcement from builder-github

The package qubes-gpg-split_2.0.26-1+deb8u1 has been pushed to the r3.2 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 26, 2017

Automated announcement from builder-github

The package qubes-gpg-split_2.0.26-1+deb9u1 has been pushed to the r3.2 testing repository for the Debian stretch template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Automated announcement from builder-github

The package qubes-gpg-split_2.0.26-1+deb9u1 has been pushed to the r3.2 testing repository for the Debian stretch template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 26, 2017

Automated announcement from builder-github

The package qubes-gpg-split_2.0.26-1+deb8u1 has been pushed to the r4.0 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Automated announcement from builder-github

The package qubes-gpg-split_2.0.26-1+deb8u1 has been pushed to the r4.0 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 26, 2017

Automated announcement from builder-github

The package qubes-gpg-split_2.0.26-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian stretch template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Automated announcement from builder-github

The package qubes-gpg-split_2.0.26-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian stretch template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Sep 18, 2017

Automated announcement from builder-github

The package qubes-gpg-split_2.0.26-1+deb8u1 has been pushed to the r3.2 stable repository for the Debian jessie template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Automated announcement from builder-github

The package qubes-gpg-split_2.0.26-1+deb8u1 has been pushed to the r3.2 stable repository for the Debian jessie template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Sep 18, 2017

Automated announcement from builder-github

The package qubes-gpg-split_2.0.26-1+deb9u1 has been pushed to the r3.2 stable repository for the Debian stretch template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Automated announcement from builder-github

The package qubes-gpg-split_2.0.26-1+deb9u1 has been pushed to the r3.2 stable repository for the Debian stretch template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Sep 18, 2017

Automated announcement from builder-github

The package qubes-gpg-split-2.0.26-1.fc23 has been pushed to the r3.2 stable repository for the Fedora fc23 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

Automated announcement from builder-github

The package qubes-gpg-split-2.0.26-1.fc23 has been pushed to the r3.2 stable repository for the Fedora fc23 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Sep 18, 2017

Automated announcement from builder-github

The package qubes-gpg-split-2.0.26-1.fc24 has been pushed to the r3.2 stable repository for the Fedora fc24 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

Automated announcement from builder-github

The package qubes-gpg-split-2.0.26-1.fc24 has been pushed to the r3.2 stable repository for the Fedora fc24 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Sep 18, 2017

Automated announcement from builder-github

The package qubes-gpg-split-2.0.26-1.fc25 has been pushed to the r3.2 stable repository for the Fedora fc25 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

Automated announcement from builder-github

The package qubes-gpg-split-2.0.26-1.fc25 has been pushed to the r3.2 stable repository for the Fedora fc25 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Sep 18, 2017

Automated announcement from builder-github

The package qubes-gpg-split-dom0-2.0.26-1.fc23 has been pushed to the r3.2 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Automated announcement from builder-github

The package qubes-gpg-split-dom0-2.0.26-1.fc23 has been pushed to the r3.2 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment