New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for translations in Qubes Manager #2599

Closed
marmarek opened this Issue Jan 22, 2017 · 14 comments

Comments

Projects
None yet
5 participants
@marmarek
Member

marmarek commented Jan 22, 2017

No description provided.

@pdinoto

This comment has been minimized.

Show comment
Hide comment
@pdinoto

pdinoto Feb 2, 2017

I will be involved in the actual spanish localization.
Let me know if I can help testing this changes.

pdinoto commented Feb 2, 2017

I will be involved in the actual spanish localization.
Let me know if I can help testing this changes.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 2, 2017

Member

@pdinoto See this file: https://github.com/marmarek/qubes-manager/blob/519cacc5ce44ba7a0a553251498a7ff0b77fb8ba/i18n/qubesmanager_es.ts
Does it makes sense? When loaded to transifex probably it will be much more user friendly.
Can you provide few translations to put there to actually test if it works? Then I'd merge this change (currently living in i18n branch) into master branch and upload updated package - this would make further testing much easier.

Member

marmarek commented Feb 2, 2017

@pdinoto See this file: https://github.com/marmarek/qubes-manager/blob/519cacc5ce44ba7a0a553251498a7ff0b77fb8ba/i18n/qubesmanager_es.ts
Does it makes sense? When loaded to transifex probably it will be much more user friendly.
Can you provide few translations to put there to actually test if it works? Then I'd merge this change (currently living in i18n branch) into master branch and upload updated package - this would make further testing much easier.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 2, 2017

Member

@mfc could you add me to qubes organization on transifex, so I'll be able to upload/download translation files?

Member

marmarek commented Feb 2, 2017

@mfc could you add me to qubes organization on transifex, so I'll be able to upload/download translation files?

pdinoto added a commit to pdinoto/qubes-manager that referenced this issue Feb 3, 2017

Translated some strings to test the process
"About" dialog and most of "VM Backup" wizard translated
(missing a couple of HTML-embedded strings I am in doubt if valid

Ref: QubesOS/qubes-issues#2599 (comment)
@mfc

This comment has been minimized.

Show comment
Hide comment
@mfc

mfc Feb 3, 2017

Member

@marmarek sent you an invitation, let me know if you can get in or we need to ask transifex to manually add you.

Member

mfc commented Feb 3, 2017

@marmarek sent you an invitation, let me know if you can get in or we need to ask transifex to manually add you.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 3, 2017

Member

@mfc thanks, it works.

Member

marmarek commented Feb 3, 2017

@mfc thanks, it works.

@marmarek marmarek closed this Feb 3, 2017

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Feb 3, 2017

Automated announcement from builder-github

The package qubes-manager-3.2.7-1.fc23 has been pushed to the r3.2 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Automated announcement from builder-github

The package qubes-manager-3.2.7-1.fc23 has been pushed to the r3.2 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@pdinoto

This comment has been minimized.

Show comment
Hide comment
@pdinoto

pdinoto Feb 6, 2017

@marmarek: Installed qubes-manager-3.2.7-1.fc23. Test es translation working as expected.

Noticed that any right-click (like trying to get the contextual menu for a running VM, or even pulling the status bar menu) brings

2017-02-05-qubes-manager-right-click-error
and Qubes Manager has to be killed and restarted. Cannot click on "More details". Not sure if it is related. Any pointers how to provide more meaninful debug info?

pdinoto commented Feb 6, 2017

@marmarek: Installed qubes-manager-3.2.7-1.fc23. Test es translation working as expected.

Noticed that any right-click (like trying to get the contextual menu for a running VM, or even pulling the status bar menu) brings

2017-02-05-qubes-manager-right-click-error
and Qubes Manager has to be killed and restarted. Cannot click on "More details". Not sure if it is related. Any pointers how to provide more meaninful debug info?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 6, 2017

Member

It looks to affect not only right-clicks but many more dialogs - like removing VM, stopping it etc.

Member

marmarek commented Feb 6, 2017

It looks to affect not only right-clicks but many more dialogs - like removing VM, stopping it etc.

@marmarek marmarek closed this Feb 6, 2017

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Feb 6, 2017

Automated announcement from builder-github

The package qubes-manager-3.2.8-1.fc23 has been pushed to the r3.2 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Automated announcement from builder-github

The package qubes-manager-3.2.8-1.fc23 has been pushed to the r3.2 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@pdinoto

This comment has been minimized.

Show comment
Hide comment
@pdinoto

pdinoto Feb 8, 2017

@marmarek: Installed qubes-manager-3.2.8-1.fc23. The error I was experiencing ⬆️ does not appear anymore.

Noticed that amongst the changes there is some string processing at qubesmanager/main.py (L105-108 for the copy&paste desktop notification) and now I do not longer see the that notification when copy inter-vm copy&paste. I wonder if that could be related.

Other strings modified in 3.2.8 seem to be displaying fine.
The strings for the copy&paste desktop notification were not translated yet.

pdinoto commented Feb 8, 2017

@marmarek: Installed qubes-manager-3.2.8-1.fc23. The error I was experiencing ⬆️ does not appear anymore.

Noticed that amongst the changes there is some string processing at qubesmanager/main.py (L105-108 for the copy&paste desktop notification) and now I do not longer see the that notification when copy inter-vm copy&paste. I wonder if that could be related.

Other strings modified in 3.2.8 seem to be displaying fine.
The strings for the copy&paste desktop notification were not translated yet.

@mfc

This comment has been minimized.

Show comment
Hide comment
@mfc

mfc Mar 7, 2017

Member

@marmarek can you pull in the recently fully-translated qubes vm manager so we can see what it looks like? thanks!

Member

mfc commented Mar 7, 2017

@marmarek can you pull in the recently fully-translated qubes vm manager so we can see what it looks like? thanks!

@marmarek

This comment has been minimized.

Show comment
Hide comment
Member

marmarek commented Mar 7, 2017

@pdinoto

This comment has been minimized.

Show comment
Hide comment
@pdinoto

pdinoto Mar 8, 2017

Looking good!

Quick question: Where do desktop notification message strings come from? (Like "Attached block device..." and "Detached block device..." when inserting a USB drive and using sys-usb)

pdinoto commented Mar 8, 2017

Looking good!

Quick question: Where do desktop notification message strings come from? (Like "Attached block device..." and "Detached block device..." when inserting a USB drive and using sys-usb)

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2017

Member

It's also in manager (https://github.com/QubesOS/qubes-manager/blob/master/qubesmanager/block.py), but it isn't included in automatic translation because of technical difficulties (#2637 (comment))

Member

marmarek commented Mar 8, 2017

It's also in manager (https://github.com/QubesOS/qubes-manager/blob/master/qubesmanager/block.py), but it isn't included in automatic translation because of technical difficulties (#2637 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment