/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After long VM uptime, qrexec calls fails with "too many pending requests" #2699

Closed
marmarek opened this Issue Mar 13, 2017 · 3 comments

Comments

Assignees

@marmarek marmarek

Labels
Projects
None yet
Milestone
  Release 3.2 updates
2 participants
@marmarek @qubesos-bot
@marmarek
Member

marmarek commented Mar 13, 2017

Qubes OS version (e.g., R3.2): R3.2

After long system uptime, trying to run multiple qrexec calls simultaneously fails - only one of them got allowed. /var/log/qubes/qrexec.<vmname>.log contains Service request denied, too many pending requests. Looking at process list, there were only 2 pending requests, which is far below limit (1024).

This is especially annoying when it hit qubes.InputKeyboard service, so you're left without keyboard...
In this case, workaround is is to unplug and plug it again (one device at the time).

@marmarek marmarek added bug C: core P: minor labels Mar 13, 2017

@marmarek marmarek added this to the Release 3.2 updates milestone Mar 13, 2017

@marmarek marmarek self-assigned this Mar 13, 2017

@marmarek marmarek closed this in marmarek/qubes-core-admin-linux@dad208a Mar 13, 2017

marmarek added a commit to marmarek/qubes-core-admin-linux that referenced this issue May 17, 2017

@marmarek
qrexec: fix pending requests cleanup code 
There was a logic error in pending requests cleanup code, causing
policy_pending_max being set to 0, even if there were more pending
requests. This effectively limited maximum pending requests to 1, after
some system uptime, because policy_pending_max set to 0 makes the code
looks only at the first pending request slot.

While at it, remove outdated FIXME comment, actually this bug is in the
code implementing this FIXME.

Fixes QubesOS/qubes-issues#2699
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
723d32b

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status May 26, 2017

Closed

core-admin-linux v4.0.0 (r4.0) #57

marmarek added a commit to marmarek/qubes-core-admin-linux that referenced this issue May 29, 2017

@marmarek
qrexec: fix pending requests cleanup code (cont) 
There was a second place with exactly the same bug. See
dad208a "qrexec: fix pending requests cleanup code" for details.

Fixes QubesOS/qubes-issues#2699
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
8719e5d

marmarek added a commit to QubesOS/qubes-core-admin-linux that referenced this issue May 29, 2017

@marmarek
qrexec: fix pending requests cleanup code (cont) 
There was a second place with exactly the same bug. See
dad208a "qrexec: fix pending requests cleanup code" for details.

Fixes QubesOS/qubes-issues#2699

(cherry picked from commit 8719e5d)
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
bb88d74
@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot May 29, 2017

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.2.14-1.fc23 has been pushed to the r3.2 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

qubesos-bot commented May 29, 2017

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.2.14-1.fc23 has been pushed to the r3.2 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot added the r3.2-dom0-cur-test label May 29, 2017

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status May 29, 2017

Closed

core-admin-linux v3.2.14 (r3.2) #61

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 5, 2017

Automated announcement from builder-github

The package qubes-core-dom0-linux-4.0.1-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

qubesos-bot commented Jul 5, 2017

Automated announcement from builder-github

The package qubes-core-dom0-linux-4.0.1-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot added the r4.0-dom0-cur-test label Jul 5, 2017

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jul 5, 2017

Closed

core-admin-linux v4.0.1 (r4.0) #105

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 11, 2017

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.2.15-1.fc23 has been pushed to the r3.2 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

qubesos-bot commented Jul 11, 2017

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.2.15-1.fc23 has been pushed to the r3.2 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@qubesos-bot qubesos-bot added r3.2-dom0-stable and removed r3.2-dom0-cur-test labels Jul 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment