Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upShutdown error unmounting /rw/home #2708
Comments
andrewdavidwong
added
C: Fedora
task
labels
Mar 16, 2017
andrewdavidwong
added this to the Release 3.2 updates milestone
Mar 16, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 16, 2017
Member
AFAIK changing to auto is a problem, because systemd will attempt to mount it earlier, when it may not be populated (on fresh VM startup) yet. And also there are cases when we don't want to mount it at all (DispVM).
|
AFAIK changing to auto is a problem, because systemd will attempt to mount it earlier, when it may not be populated (on fresh VM startup) yet. And also there are cases when we don't want to mount it at all (DispVM). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 16, 2017
Member
If it's about ordering during shutdown, probably some ordering options should be added, instead of touching auto/noauto.
|
If it's about ordering during shutdown, probably some ordering options should be added, instead of touching auto/noauto. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adrelanos
Mar 16, 2017
Member
|
This may also be affecting Debian stretch based templates?
I noticed that shutdown takes very long and causes high CPU while
systemd reports failing to unmount /rw.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Rudd-O
Mar 17, 2017
Rudd-O
commented
Mar 17, 2017
|
No it won't. Before=rw.mount in the relevant Qubes unit file will prevent that from happening.
…On March 16, 2017 11:19:51 AM GMT+01:00, "Marek Marczykowski-Górecki" ***@***.***> wrote:
AFAIK changing to auto _is_ a problem, because systemd will attempt to
mount it earlier, when it may not be populated (on fresh VM startup)
yet. And also there are cases when we don't want to mount it at all
(DispVM).
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#2708 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Rudd-O
Mar 17, 2017
Rudd-O
commented
Mar 17, 2017
|
Auto is the right fix.
…On March 16, 2017 11:20:30 AM GMT+01:00, "Marek Marczykowski-Górecki" ***@***.***> wrote:
If it's about ordering during shutdown, probably some ordering options
should be added, instead of touching auto/noauto.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#2708 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Rudd-O
Mar 17, 2017
Qubes-mount-dirs.service:
[Unit]
Description=Initialize and mount /rw and /home
# There is a dependency on dev-xvdb.device because
# mount-dirs.sh calls setup-rwdev.sh which
# must happen only when /dev/xvdb has appeared.
After=qubes-sysinit.service dev-xvdb.device
DefaultDependencies=no
Before=local-fs.target rw.mount home.mount qubes-gui-agent.service
[Service]
Type=oneshot
RemainAfterExit=yes
ExecStart=/usr/lib/qubes/init/mount-dirs.sh
# There is no need for an ExecStop because systemd
# cleans up mount units in the right order, killing
# processes as needed.
[Install]
WantedBy=multi-user.target
See the Before=rw.mount and the Before=home.mount?
That means systemd will always execute the script before the mount points are mounted, thus mounting /home and /rw the way we like it, rather than letting systemd do it.
Rudd-O
commented
Mar 17, 2017
|
Qubes-mount-dirs.service: See the That means systemd will always execute the script before the mount points are mounted, thus mounting /home and /rw the way we like it, rather than letting systemd do it. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Rudd-O
Mar 17, 2017
By the way, I tried it. I can also confirm that changing to auto fixes the problem of unmounting /rw cleanly.
Rudd-O
commented
Mar 17, 2017
|
By the way, I tried it. I can also confirm that changing to |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 17, 2017
Member
What about the cases of not mounting /home at all (DispVM)? In that case, adding auto would make /home mounted anyway, effectively breaking DispVMs.
|
What about the cases of not mounting /home at all (DispVM)? In that case, adding |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 17, 2017
Member
Maybe that could be fixed by adding appropriate ConditionPathExists= to rw.mount and home.mount using drop-ins files (after dropping noauto)?
marmarek
commented
Mar 17, 2017
•
edited
Edited 1 time
-
marmarek
edited Mar 17, 2017 (most recent)
edited
-
Mar 17, 2017 (most recent)
|
Maybe that could be fixed by adding appropriate |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Rudd-O
Mar 18, 2017
Rudd-O
commented
Mar 18, 2017
|
On 03/17/2017 09:52 PM, Marek Marczykowski-Górecki wrote:
Maybe that could be fixed by adding appropriate |ConditionPathExists=|
to |rw.mount| and |home.mount| (after dropping |noauto|)?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2708 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVIwncVbraqS11XUJlNaaSnuOQxcLvkks5rmwCYgaJpZM4Me3AH>.
I have to say, my DVM works just fine here, even after removing noauto.
/home_volatile is correctly mounted onto /home. /rw/home is never
mounted either.
From observation here, what I can tell is this: apparently, systemd will
not bother mounting /home using the /etc/fstab parameters if, by the
time /home must be mounted, something is already mounted onto /home.
…--
Rudd-O
http://rudd-o.com/
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 18, 2017
Member
|
What about /rw? It should be _unmounted_ just after initializing /home.
…--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Rudd-O
Mar 19, 2017
Rudd-O
commented
Mar 19, 2017
|
In my DVMs (with auto option) /rw is not mounted after the DVM has been
created.
…--
Rudd-O
http://rudd-o.com/
|
Rudd-O commentedMar 16, 2017
•
edited
Edited 1 time
-
Rudd-O
edited Mar 16, 2017 (most recent)
Qubes OS version R3.2
Affected TemplateVMs:
fedora-24
fedora-24-minimal
Mount option for /rw/home should not be noauto. It should be auto. Otherwise systemd will assume it is a mount that was mounted by the user/operator, attempt to unmount it too early, and this will almost always fail because applications will still be running and holding files in /rw/home open.
It is not a problem to change the option since those file systems are mounted manually anyway.