New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-prefs claims to be able to modify dom0 #2722

Closed
kulinacs opened this Issue Mar 22, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@kulinacs

Qubes OS version (e.g., R3.2):

R3.2

Affected TemplateVMs (e.g., fedora-23, if applicable):

dom0


Expected behavior:

qvm-prefs should not list dom0, or allow it to be edited

Actual behavior:

qvm-prefs does list dom0 and allow it to be edited

Steps to reproduce the behavior:

run qvm-prefs -l dom0 in dom0

General notes:

Mailing list thread: https://groups.google.com/forum/#!topic/qubes-devel/pRkDqzK0hzg

@kulinacs kulinacs referenced this issue in QubesOS/qubes-core-admin Mar 22, 2017

Merged

Added dom0 check to qvm-prefs #96

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Mar 22, 2017

Member

[Copying Marek's response here for anyone who doesn't look at the thread.]

On 2017-03-21 18:09, Marek Marczykowski-Górecki wrote:

On Tue, Mar 21, 2017 at 07:54:12PM -0500, Nicklaus McClendon wrote:

Currently, qvm-prefs allows you to edit dom0 settings, while Qubes
Manager does not. When listing attributes, qvm-prefs claims dom0 has a
VM directory, when it currently doesn't. Is qvm-prefs' ability to
modify dom0 desired behavior?

No, it isn't. Those settings have no effect on dom0.

Member

andrewdavidwong commented Mar 22, 2017

[Copying Marek's response here for anyone who doesn't look at the thread.]

On 2017-03-21 18:09, Marek Marczykowski-Górecki wrote:

On Tue, Mar 21, 2017 at 07:54:12PM -0500, Nicklaus McClendon wrote:

Currently, qvm-prefs allows you to edit dom0 settings, while Qubes
Manager does not. When listing attributes, qvm-prefs claims dom0 has a
VM directory, when it currently doesn't. Is qvm-prefs' ability to
modify dom0 desired behavior?

No, it isn't. Those settings have no effect on dom0.

@andrewdavidwong andrewdavidwong added this to the Release 4.1 milestone Mar 22, 2017

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Apr 23, 2017

Added dom0 check to qvm-prefs
Added a check to qvm-prefs to see if the specified VM is dom0 and,
if so, error out with a message that dom0 cannot be managed by
qvm-prefs

(cherry picked from commit 7896dc5)
Notes from origin:
    Fixed QubesOS/qubes-issues#2722

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Apr 23, 2017

Closed

core-admin v3.2.14 (r3.2) #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment