/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit coroutines definition, maybe change to async def #2738

Open
woju opened this Issue Apr 5, 2017 · 0 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Release 4.1
1 participant
@woju
@woju
Member

woju commented Apr 5, 2017

The problem with async def is that pylint < 1.7 crashes of them. It's clumsy to use pylint from git, since it needs astroid also from git (at the time of writing). Let's check this sometime in the future.

@woju woju added C: core P: minor task labels Apr 5, 2017

@woju woju added this to the Release 4.1 milestone Apr 5, 2017

woju added a commit to woju/qubes-core-admin that referenced this issue Apr 5, 2017

@woju
qubes: revert async def, use @asyncio.coroutine 
Current pylint (any released version) stumbles on async def'ined
functions. Let's use @asyncio.coroutines for now.

Seems like python-3.5 is not that mature yet.

QubesOS/qubes-issues#2622
QubesOS/qubes-issues#2738
PyCQA/pylint#1126
f3804d2

woju added a commit to woju/qubes-core-admin that referenced this issue Apr 5, 2017

@woju
qubes: revert async def, use @asyncio.coroutine 
Current pylint (any released version) stumbles on async def'ined
functions. Let's use @asyncio.coroutines for now.

Seems like python-3.5 is not that mature yet.

QubesOS/qubes-issues#2622
QubesOS/qubes-issues#2738
PyCQA/pylint#1126
23fdb94

woju added a commit to woju/qubes-core-admin that referenced this issue Apr 5, 2017

@woju
qubes: revert async def, use @asyncio.coroutine 
Current pylint (any released version) stumbles on async def'ined
functions. Let's use @asyncio.coroutines for now.

Seems like python-3.5 is not that mature yet.

QubesOS/qubes-issues#2622
QubesOS/qubes-issues#2738
PyCQA/pylint#1126
64d3585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment