New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: broken links on download page #2752

Closed
jpouellet opened this Issue Apr 17, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@jpouellet
Contributor

jpouellet commented Apr 17, 2017

While working on #2725, I discovered the following:

There are two (invalid) links to https://mirrors.kernel.org%20/ on https://www.qubes-os.org/downloads/ (the links on the right for the torrent entries)

This comes from the way that the data is being templated which is trying to use the mirror names as unique keys, but also wants more than one entry per :

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Apr 17, 2017

Member

Yeah, I'm pretty sure that's an intentional (but admittedly ugly) workaround.

Member

andrewdavidwong commented Apr 17, 2017

Yeah, I'm pretty sure that's an intentional (but admittedly ugly) workaround.

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Apr 17, 2017

Member

I saw that we already had some entries like that, and that there was no other obvious, quick, and easy way to add new entries, so I followed that convention. Do you have a better solution, @jpouellet?

Member

andrewdavidwong commented Apr 17, 2017

I saw that we already had some entries like that, and that there was no other obvious, quick, and easy way to add new entries, so I followed that convention. Do you have a better solution, @jpouellet?

@andrewdavidwong andrewdavidwong added this to the Documentation/website milestone Apr 17, 2017

jpouellet added a commit to jpouellet/qubesos.github.io that referenced this issue Apr 17, 2017

@jpouellet jpouellet referenced this issue in QubesOS/qubesos.github.io Apr 17, 2017

Merged

Fix mirror links #94

@jpouellet

This comment has been minimized.

Show comment
Hide comment
Contributor

jpouellet commented Apr 17, 2017

How about QubesOS/qubesos.github.io#94?

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Apr 18, 2017

Member

Looks great, thanks!

Member

andrewdavidwong commented Apr 18, 2017

Looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment