Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upqvm-* tools should use stderr for diagnostic output #276
Comments
marmarek
assigned
rootkovska
Mar 8, 2015
marmarek
added this to the Release 1 Beta 2 milestone
Mar 8, 2015
marmarek
added
bug
C: core
P: critical
labels
Mar 8, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by marmarek on 17 Jul 2011 10:08 UTC
Have you used '-q' switch? Without it there is 'Running command on VM ...' message from qvm-run...
|
Comment by marmarek on 17 Jul 2011 10:08 UTC |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by joanna on 17 Jul 2011 10:33 UTC
Ha! Indeed, the -q solves the problem. Has this changes since some previous version?
Anyway, I think we should implicitly assume '-q' when '--pass_io' is specified. This would confuse less users and also is pretty logical IMHO.
|
Comment by joanna on 17 Jul 2011 10:33 UTC Anyway, I think we should implicitly assume '-q' when '--pass_io' is specified. This would confuse less users and also is pretty logical IMHO. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by marmarek on 17 Jul 2011 11:40 UTC
IMHO this message should be printed to stderr, instead of stdout, which also solves problem.
|
Comment by marmarek on 17 Jul 2011 11:40 UTC |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Comment by joanna on 17 Jul 2011 11:41 UTC |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by joanna on 17 Jul 2011 11:53 UTC
But then, we should really change all the prints in all the qvm-tools to use stderr -- currently they all are using stdout...
|
Comment by joanna on 17 Jul 2011 11:53 UTC |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by joanna on 17 Jul 2011 11:57 UTC
For now, I just disable verbose when --passio is passed:
http://git.qubes-os.org/?p=joanna/core.git;a=commitdiff;h=4044c2da8be2100f2d81bfa3de869735ada20994
and I will move this ticket to Beta 3 (renaming it)
|
Comment by joanna on 17 Jul 2011 11:57 UTC http://git.qubes-os.org/?p=joanna/core.git;a=commitdiff;h=4044c2da8be2100f2d81bfa3de869735ada20994 and I will move this ticket to Beta 3 (renaming it) |
marmarek
modified the milestones:
Release 1 Beta 3,
Release 1 Beta 2
Mar 8, 2015
marmarek
added
P: minor
and removed
P: critical
labels
Mar 8, 2015
marmarek
changed the title from
qvm-run --pass_io corrputs data
to
qvm-* tools should use stderr for diagnostic output
Mar 8, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by rafal on 17 Jul 2011 19:06 UTC
Another issue is with "-a" flag - when starting a domain, xl prints some "Daemon running with PID xxx" at stdout.
|
Comment by rafal on 17 Jul 2011 19:06 UTC |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by marmarek on 10 Oct 2011 23:55 UTC
Fixed in qubes core, xl still uses stdout.
http://git.qubes-os.org/gitweb/?p=marmarek/core.git;a=commit;h=98827c7020987290a97a164c4c7c24b8c82e4e05
http://git.qubes-os.org/gitweb/?p=marmarek/core.git;a=commit;h=ed23b0d6a2f6bb8a846577364c14f9fa9a82448c
|
Comment by marmarek on 10 Oct 2011 23:55 UTC http://git.qubes-os.org/gitweb/?p=marmarek/core.git;a=commit;h=98827c7020987290a97a164c4c7c24b8c82e4e05 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 8, 2015
Member
Comment by marmarek on 13 Oct 2011 10:23 UTC
http://git.qubes-os.org/gitweb/?p=marmarek/xen.git;a=commit;h=6e6d71d4e29d46ad5a1251e16940e098bc2957b3
|
Comment by marmarek on 13 Oct 2011 10:23 UTC |
marmarek commentedMar 8, 2015
Reported by joanna on 17 Jul 2011 10:00 UTC
Tested with:
They do not return the same checksum! This has been tested on the old qrexec1, not the new qrexec2. I will test the new later today.
Migrated-From: https://wiki.qubes-os.org/ticket/276