New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-* tools should use stderr for diagnostic output #276

Closed
marmarek opened this Issue Mar 8, 2015 · 9 comments

Comments

Projects
None yet
2 participants
@marmarek
Member

marmarek commented Mar 8, 2015

Reported by joanna on 17 Jul 2011 10:00 UTC
Tested with:


qvm-run --pass_io somevm "cat somelarge.jpg | md5sum"

qvm-run --pass_io somevm "cat somelarge.jpg" | md5sum

They do not return the same checksum! This has been tested on the old qrexec1, not the new qrexec2. I will test the new later today.

Migrated-From: https://wiki.qubes-os.org/ticket/276

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 17 Jul 2011 10:08 UTC
Have you used '-q' switch? Without it there is 'Running command on VM ...' message from qvm-run...

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 17 Jul 2011 10:08 UTC
Have you used '-q' switch? Without it there is 'Running command on VM ...' message from qvm-run...

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 17 Jul 2011 10:33 UTC
Ha! Indeed, the -q solves the problem. Has this changes since some previous version?

Anyway, I think we should implicitly assume '-q' when '--pass_io' is specified. This would confuse less users and also is pretty logical IMHO.

Member

marmarek commented Mar 8, 2015

Comment by joanna on 17 Jul 2011 10:33 UTC
Ha! Indeed, the -q solves the problem. Has this changes since some previous version?

Anyway, I think we should implicitly assume '-q' when '--pass_io' is specified. This would confuse less users and also is pretty logical IMHO.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by marmarek on 17 Jul 2011 11:40 UTC
IMHO this message should be printed to stderr, instead of stdout, which also solves problem.

Member

marmarek commented Mar 8, 2015

Comment by marmarek on 17 Jul 2011 11:40 UTC
IMHO this message should be printed to stderr, instead of stdout, which also solves problem.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 17 Jul 2011 11:41 UTC
Yes, agree.

Member

marmarek commented Mar 8, 2015

Comment by joanna on 17 Jul 2011 11:41 UTC
Yes, agree.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 17 Jul 2011 11:53 UTC
But then, we should really change all the prints in all the qvm-tools to use stderr -- currently they all are using stdout...

Member

marmarek commented Mar 8, 2015

Comment by joanna on 17 Jul 2011 11:53 UTC
But then, we should really change all the prints in all the qvm-tools to use stderr -- currently they all are using stdout...

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by joanna on 17 Jul 2011 11:57 UTC
For now, I just disable verbose when --passio is passed:

http://git.qubes-os.org/?p=joanna/core.git;a=commitdiff;h=4044c2da8be2100f2d81bfa3de869735ada20994

and I will move this ticket to Beta 3 (renaming it)

Member

marmarek commented Mar 8, 2015

Comment by joanna on 17 Jul 2011 11:57 UTC
For now, I just disable verbose when --passio is passed:

http://git.qubes-os.org/?p=joanna/core.git;a=commitdiff;h=4044c2da8be2100f2d81bfa3de869735ada20994

and I will move this ticket to Beta 3 (renaming it)

@marmarek marmarek added P: minor and removed P: critical labels Mar 8, 2015

@marmarek marmarek changed the title from qvm-run --pass_io corrputs data to qvm-* tools should use stderr for diagnostic output Mar 8, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 8, 2015

Member

Comment by rafal on 17 Jul 2011 19:06 UTC
Another issue is with "-a" flag - when starting a domain, xl prints some "Daemon running with PID xxx" at stdout.

Member

marmarek commented Mar 8, 2015

Comment by rafal on 17 Jul 2011 19:06 UTC
Another issue is with "-a" flag - when starting a domain, xl prints some "Daemon running with PID xxx" at stdout.

@marmarek

This comment has been minimized.

Show comment
Hide comment

@marmarek marmarek closed this Mar 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment