New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use createrepo_c instead of createrepo #2815

Closed
cyrinux opened this Issue May 17, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@cyrinux

cyrinux commented May 17, 2017

Qubes OS version (e.g., R3.2):

I suggest use createrepo_c instead of createrepo, createrepo_c is faster.

Affected TemplateVMs (e.g., fedora-23, if applicable):

dom0


Expected behavior:

createrepo_cmd = ["/usr/bin/createrepo_c"]

Actual behavior:

createrepo_cmd = ["/usr/bin/createrepo"]

Steps to reproduce the behavior:

createrepo_cmd = ["/usr/bin/createrepo_c"] in /usr/libexec/qubes/qubes-receive-update

General notes:


Related issues:

https://groups.google.com/forum/#!searchin/qubes-devel/createrepo%7Csort:relevance/qubes-devel/BVyLF-Qsp4E/8U-ivqEmAQAJ

@jpouellet

This comment has been minimized.

Show comment
Hide comment
@jpouellet

jpouellet May 26, 2017

Contributor

To check: Are the incoming packages already verified by this point? (Is this untrusted data? Untrusted package file names or such perhaps?)

If not: IMO we should prefer the normal createrepo (which is in written in python).

Contributor

jpouellet commented May 26, 2017

To check: Are the incoming packages already verified by this point? (Is this untrusted data? Untrusted package file names or such perhaps?)

If not: IMO we should prefer the normal createrepo (which is in written in python).

@cyrinux

This comment has been minimized.

Show comment
Hide comment
@cyrinux

cyrinux May 27, 2017

@jpouellet I'm not sure to correctly understand what you mean. But createrepo_c package is installed by default and come from default fedora repo.

cyrinux commented May 27, 2017

@jpouellet I'm not sure to correctly understand what you mean. But createrepo_c package is installed by default and come from default fedora repo.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 28, 2017

Member

@jpouellet yes, at this point packages have signatures verified already

Member

marmarek commented May 28, 2017

@jpouellet yes, at this point packages have signatures verified already

@anoadragon453 anoadragon453 referenced this issue in QubesOS/qubes-core-admin-linux Aug 1, 2017

Merged

Switch to createrepo_c #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment