New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tray icon background color transparent instead of white #2846

Open
andrewdavidwong opened this Issue Jun 4, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@andrewdavidwong
Member

andrewdavidwong commented Jun 4, 2017

If possible, it would be nice if system tray icons could have transparent backgrounds instead of solid white. This would make them look more like native dom0 tray icons in dark color schemes.

Here's a screenshot of how they currently look, courtesy of user Epitre:

white-tray-icons

(Compare the backgrounds of the the Skype and NetworkManager icons to the Volume and Qubes Manager icons.)

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Sep 27, 2017

Member

There are different modes for handling icons - see man qubes-guid. None of them offer transparent background, but it could be easily added based on "bg" one.
But first we need to make sure it will be still clearly marked that the icon is from a VM.

Member

marmarek commented Sep 27, 2017

There are different modes for handling icons - see man qubes-guid. None of them offer transparent background, but it could be easily added based on "bg" one.
But first we need to make sure it will be still clearly marked that the icon is from a VM.

@fepitre

This comment has been minimized.

Show comment
Hide comment
@fepitre

fepitre Oct 3, 2017

Member

I'm working on it. As a first step, I added the choice of having a background with a specific color for "bg" and "tint". From what I have seen and tested in the code, the "bg" mode seems to not color the background with respect to appvm color? In that case, I could adjust it.

Member

fepitre commented Oct 3, 2017

I'm working on it. As a first step, I added the choice of having a background with a specific color for "bg" and "tint". From what I have seen and tested in the code, the "bg" mode seems to not color the background with respect to appvm color? In that case, I could adjust it.

@fepitre

This comment has been minimized.

Show comment
Hide comment
@fepitre

fepitre Oct 3, 2017

Member

@marmarek Do you know what is the best way to pass a value to vmside from xside? It is intended to pass a color for setting the background in vmside when XCreateSimpleWindow with WhitePixel as background. Without it, the icons look like badly stripped on their border due to the white.

Member

fepitre commented Oct 3, 2017

@marmarek Do you know what is the best way to pass a value to vmside from xside? It is intended to pass a color for setting the background in vmside when XCreateSimpleWindow with WhitePixel as background. Without it, the icons look like badly stripped on their border due to the white.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Oct 3, 2017

Member

You mean that vmside would fill the background with the color of actual tray background? What if the color changes? What about choosing some different than white (but static) color as a "transparent" one? Like 0xfefefe, or so. Also, in theory each pixel is 32 bits, but in practice only 24 bits are used. Maybe we can have RGBA, instead of RGB there?

Member

marmarek commented Oct 3, 2017

You mean that vmside would fill the background with the color of actual tray background? What if the color changes? What about choosing some different than white (but static) color as a "transparent" one? Like 0xfefefe, or so. Also, in theory each pixel is 32 bits, but in practice only 24 bits are used. Maybe we can have RGBA, instead of RGB there?

@fepitre

This comment has been minimized.

Show comment
Hide comment
@fepitre

fepitre Oct 3, 2017

Member

Yes the vmside would fill the color of actual tray but if color change, the vm needs to restart...not a so good final way. I will try with a different static color but probably we will have a bad stripping. The best solution would be to use the RGBA indeed. I will investigate.

Member

fepitre commented Oct 3, 2017

Yes the vmside would fill the color of actual tray but if color change, the vm needs to restart...not a so good final way. I will try with a different static color but probably we will have a bad stripping. The best solution would be to use the RGBA indeed. I will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment