New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM names should not allow keywords #2857

Closed
svenssonaxel opened this Issue Jun 18, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@svenssonaxel

Qubes OS version (e.g., R3.2):

R3.2

Affected TemplateVMs (e.g., fedora-23, if applicable):

N/A


Steps to reproduce the behavior:

Use the VM Manager to create a new NetVM with the name "default".

Expected behavior:

The operation fails, similarly to the names "none", "true" and "false".

Actual behavior:

The NetVM is created. This leads to an ambiguity in the following command:
qvm-prefs -s my-new-vm netvm default

General notes:

To avoid similar mistakes in the future, maybe keywords should be uniformly distinguished from VM names, e.g. begin with _ or $, similarly to the current policy file format that uses $any and $dispvm. This would also provide backward compatibility with backups if new keywords are introduced in the future.


Related issues:

@marmarek

This comment has been minimized.

Show comment
Hide comment
Member

marmarek commented Nov 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment