New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-appmenus (and successor) interface #2885

Open
woju opened this Issue Jul 5, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@woju
Member

woju commented Jul 5, 2017

--get-whitelisted:

  • ''.join('{}\n'.format(ident) for ...)
  • does ident contain .desktop?
  • no name or description

--set-whitelisted:

  • expected like in --get-whitelisted, last '\n' optional (parsed with .strip().split())

--get-available --i-know-format-is-unstable:

  • ''.join('{} {} {}\n'.format(ident, icon_path, name) for ...)
  • icon_path for now would be '-' and unused, so this becomes '{} - {}\n' and parses correctly with line.split(' ', maxsplit=2)
  • name is permitted to contain whitespace and is not delimited besides '\n', which is prohibited (and maybe .replace()d to space)

When creating Python API (R4.1), the object appmenu object would have attrs (ident, name, description, icon_path, whitelisted, anything else?). Only then description would be available.

comments?

@woju woju added C: core task labels Jul 5, 2017

@woju woju added this to the Release 4.0 milestone Jul 5, 2017

@woju woju assigned marmarek and woju Jul 5, 2017

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 5, 2017

Member

does ident contain .desktop

I think it shouldn't. Same as an argument to qubes.StartApp service. But currently it does.

Otherwise, looks good.

Member

marmarek commented Jul 5, 2017

does ident contain .desktop

I think it shouldn't. Same as an argument to qubes.StartApp service. But currently it does.

Otherwise, looks good.

woju added a commit to QubesOS/qubes-desktop-linux-common that referenced this issue Jul 7, 2017

woju added a commit to QubesOS/qubes-desktop-linux-common that referenced this issue Jul 12, 2017

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jul 16, 2017

Closed

desktop-linux-common v4.0.1 (r4.0) #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment