/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'service/xxx' features to 'service.xxx' #2906

Closed
marmarek opened this Issue Jul 12, 2017 · 0 comments

Comments

Assignees

@marmarek marmarek

Labels
Projects
None yet
Milestone
  Release 4.0
1 participant
@marmarek
@marmarek
Member

marmarek commented Jul 12, 2017

Qubes OS version (e.g., R3.2): R4.0

We initially mapped R3.x "services" into features with "service/" prefix, but this isn't a good idea, because "/" is not allowed in qrexec call argument, so such features would be unreachable through Admin API. Change the prefix to "service.".

@marmarek marmarek added bug C: core P: minor labels Jul 12, 2017

@marmarek marmarek added this to the Release 4.0 milestone Jul 12, 2017

@marmarek marmarek self-assigned this Jul 12, 2017

marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Jul 12, 2017

@marmarek
features: change 'service/' prefix to 'service.' 
'/' is not allowed in qrexec service call argument, but feature name is
passed there in Admin API.

Fixes QubesOS/qubes-issues#2906
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
Loading status checks…
f9b8b77

@marmarek marmarek referenced this issue in QubesOS/qubes-core-admin Jul 12, 2017

Closed

features: change 'service/' prefix to 'service.' #129

@woju woju referenced this issue in QubesOS/qubes-core-admin Jul 12, 2017

Merged

qubes: have "service" features' keys separated by period #130

marmarek added a commit to marmarek/qubes-mgmt-salt-dom0-qvm that referenced this issue Jul 13, 2017

@marmarek
Change 'service/' prefix to 'service.' 
QubesOS/qubes-issues#2906
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
e67e0b7

@marmarek marmarek closed this in QubesOS/qubes-core-admin#130 Jul 13, 2017

marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Jul 18, 2017

@marmarek
Rename 'net/*' features to 'net.*' 
Same reasoning as with 'service/*' - '/' is not allowed in qrexec (so
Admin API) call argument.

Related to QubesOS/qubes-issues#2906
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
Loading status checks…
801d6ac

@marmarek marmarek referenced this issue in QubesOS/qubes-core-admin Jul 18, 2017

Merged

Rename features to not contain '/', fix service start order #134

This was referenced Jul 18, 2017

Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment