New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change VM 'hvm' property into 'virt_mode' property #2912

Closed
marmarek opened this Issue Jul 17, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@marmarek
Member

marmarek commented Jul 17, 2017

Qubes OS version (e.g., R3.2): R4.0

Currently there is hvm property, which if True (default) means the VM should start as HVM, but if False - PV. There are two issues with this:

  1. This is quite Xen specific (other VMMs may support other modes, or just one)
  2. Even in Xen it is not enough, because we miss PVHv2 mode here (#2185)

Lets change this to virt_mode property, with possible values hvm, pv and later pvhv2 (or hvmlite?). When porting to other VMMs, other values may be supported, but property itself will be already there.

@marmarek marmarek added this to the Release 4.0 milestone Jul 17, 2017

@marmarek marmarek self-assigned this Jul 17, 2017

marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Jul 17, 2017

Add code and test for migrating vm.hvm into vm.virt_mode
This will allow to load old qubes.xml - otherwise previous change render
the system unusable (until manual qubes.xml edit).

QubesOS/qubes-issues#2912

marmarek added a commit to marmarek/qubes-core-admin-client that referenced this issue Jul 17, 2017

marmarek added a commit to marmarek/qubes-desktop-linux-common that referenced this issue Jul 18, 2017

marmarek added a commit to marmarek/qubes-core-admin-client that referenced this issue Jul 18, 2017

@marmarek marmarek referenced this issue in QubesOS/qubes-core-admin-client Jul 18, 2017

Merged

Change 'hvm' property to 'virt_mode' #18

marmarek added a commit to marmarek/qubes-mgmt-salt-dom0-qvm that referenced this issue Jul 18, 2017

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 18, 2017

Automated announcement from builder-github

The package qubes-core-dom0-4.0.2-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Automated announcement from builder-github

The package qubes-core-dom0-4.0.2-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment