New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-usb/qubesutils not discovering all usb devices #2938

Closed
olim5 opened this Issue Jul 24, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@olim5

olim5 commented Jul 24, 2017

Qubes OS version (e.g., R3.2):

R3.2

Affected TemplateVMs (e.g., fedora-23, if applicable):

All


Expected behavior:

Show all usb devices connected to sys-usb.

Actual behavior:

Shows only usb devices with usb id format of [0-9]+-[0-9]+.[0-9]+ (sys-usb:2-1.6) Not discovered are devices like sys-usb:2.1.1.3 or even sys-usb:2-1.1.2.1 .

Steps to reproduce the behavior:

Just connect devices with longer usb id trees:
[user@sys-usb ~]$ usbip list -l

  • busid 2-1.1.1 (0461:4d16)
    Primax Electronics, Ltd : unknown product (0461:4d16)

  • busid 2-1.1.2.1 (0458:004c)
    KYE Systems Corp. (Mouse Systems) : Slimstar Pro Keyboard (0458:004c)

  • busid 2-1.1.3 (0c4b:0300)
    Reiner SCT Kartensysteme GmbH : cyberJack pinpad(a) (0c4b:0300)

  • busid 2-1.3 (147e:2016)
    Upek : Biometric Touchchip/Touchstrip Fingerprint Sensor (147e:2016)

  • busid 2-1.6 (04f2:b217)
    Chicony Electronics Co., Ltd : Lenovo Integrated Camera (0.3MP) (04f2:b217)

General notes:

Modifying regex "usb_device_re" to "re.compile(r"^[0-9]+-[0-9]+([0-9]+?[0-9]*)?$")" in
/usr/lib64/python2.7/site-packages/qubes/qubesutils.py solved the issue at least for sys-usb:2.1.1.3 usb ids.


Related issues:

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Jul 25, 2017

Member

Is this on Qubes R3.2?

Member

andrewdavidwong commented Jul 25, 2017

Is this on Qubes R3.2?

@olim5

This comment has been minimized.

Show comment
Hide comment
@olim5

olim5 Jul 25, 2017

Yes, it is R3.2 .

olim5 commented Jul 25, 2017

Yes, it is R3.2 .

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 26, 2017

Member

Already fixed for Qubes 4.0 but indeed the fix worth backporting to Qubes 3.2

Member

marmarek commented Jul 26, 2017

Already fixed for Qubes 4.0 but indeed the fix worth backporting to Qubes 3.2

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 26, 2017

Member

Oh well, it's already in release3.2 branch too: QubesOS/qubes-core-admin#106
Updated package was not released.

Member

marmarek commented Jul 26, 2017

Oh well, it's already in release3.2 branch too: QubesOS/qubes-core-admin#106
Updated package was not released.

@marmarek

This comment has been minimized.

Show comment
Hide comment

@marmarek marmarek closed this Jul 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment