Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAsk to create default policy for new qrexec services? #3005
Comments
rootkovska
added
C: core
enhancement
labels
Aug 10, 2017
rootkovska
added this to the Release 4.0 milestone
Aug 10, 2017
rootkovska
assigned
marmarek
Aug 10, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Aug 10, 2017
Member
Since now we have new qrexec prompt window - which is harder to accidentally accept, what do you think about applying default policy "$anyvm $anyvm ask", without asking first?
|
Since now we have new qrexec prompt window - which is harder to accidentally accept, what do you think about applying default policy "$anyvm $anyvm ask", without asking first? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
+1 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Aug 12, 2017
Member
On the other hand, this would allow VM existence confirmation, which may be privacy issue. So, I'll implement explicit confirmation, as it was in 3.2.
|
On the other hand, this would allow VM existence confirmation, which may be privacy issue. So, I'll implement explicit confirmation, as it was in 3.2. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Why would it allow VM existence confirmation any better? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Aug 13, 2017
Member
Because when target domain specified by source domain does not exist, the call will be rejected (not existing domain does not match with $anyvm, so ask action will not be applied).
|
Because when target domain specified by source domain does not exist, the call will be rejected (not existing domain does not match with |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
But... here we're discussing non-existing services? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Aug 13, 2017
Member
Yes. And when you automatically get $anyvm $anyvm ask policy, it allows exactly what I've described above. That's why I prefer to ask before policy creation (before even looking at target domain).
|
Yes. And when you automatically get |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rootkovska
Aug 13, 2017
Member
Is there anything fundamental that prevents us from not dropping the call before we display the window? Or perhaps adding a random delay in case non-existing target?
|
Is there anything fundamental that prevents us from not dropping the call before we display the window? Or perhaps adding a random delay in case non-existing target? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
(Random delay simulating the user reading and click on the dialog) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Aug 13, 2017
Member
Is there anything fundamental that prevents us from not dropping the call before we display the window?
Can you rephrase? We are actually dropping the call before displaying the window.
Note that the "problem" is not "ask" action rejecting non-existing target, but not applying "ask" action at all (so it gets to implicit deny, because no rule have matched).
As for random delay - I think it may break many legitimate use cases... And getting it right will be really hard - for example we need to assume some range, and it should match how much this particular user spends on reading the dialog.
IMO one time ask before policy creation, at the first service call is much simpler solution - both in terms of implementation and usability.
Can you rephrase? We are actually dropping the call before displaying the window. Note that the "problem" is not "ask" action rejecting non-existing target, but not applying "ask" action at all (so it gets to implicit deny, because no rule have matched). As for random delay - I think it may break many legitimate use cases... And getting it right will be really hard - for example we need to assume some range, and it should match how much this particular user spends on reading the dialog. IMO one time ask before policy creation, at the first service call is much simpler solution - both in terms of implementation and usability. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Aug 13, 2017
Member
Can you rephrase? We are actually dropping the call before displaying the window.
Ah, there is "not". Ok, so ignore this and read the rest of my comment.
Ah, there is "not". Ok, so ignore this and read the rest of my comment. |
added a commit
to marmarek/qubes-core-admin
that referenced
this issue
Aug 13, 2017
added a commit
to marmarek/qubes-core-admin
that referenced
this issue
Aug 14, 2017
marmarek
referenced this issue
in QubesOS/qubes-core-admin
Aug 14, 2017
Merged
Policy related commits for 4.0 #144
marmarek
closed this
in
QubesOS/qubes-core-admin#144
Aug 16, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Aug 27, 2017
Automated announcement from builder-github
The package qubes-core-dom0-4.0.6-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:
sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing
qubesos-bot
commented
Aug 27, 2017
|
Automated announcement from builder-github The package
|
qubesos-bot
added
the
r4.0-dom0-cur-test
label
Aug 27, 2017
qubesos-bot
referenced this issue
in QubesOS/updates-status
Aug 27, 2017
Closed
core-admin v4.0.6 (r4.0) #194
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Oct 30, 2017
Automated announcement from builder-github
The package qubes-core-dom0-4.0.11-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:
sudo qubes-dom0-update
Or update dom0 via Qubes Manager.
qubesos-bot
commented
Oct 30, 2017
|
Automated announcement from builder-github The package
Or update dom0 via Qubes Manager. |
rootkovska commentedAug 10, 2017
In 3.2 if the user creates a new qrexec service (for which there is no policy file in dom0), we get a window asking to create the default policy for the service. In 4.0-rc1 we get connection refusal if the policy is missing.