New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0rc1 qvm-run --dispvm non-graceful exiting in dom0 #3016

Closed
3hhh opened this Issue Aug 12, 2017 · 12 comments

Comments

Projects
None yet
4 participants
@3hhh

3hhh commented Aug 12, 2017

No graceful handling of non-dvms:

qvm-run --dispvm fedora-25 xterm
Running 'xterm' on $dispvm:fedora-25
$dispvm:fedora-25: Got empty response from qubesd
Traceback (most recent call last):
  File "/usr/bin/qvm-run", line 9, in <module>
    load_entry_point('qubesadmin==4.0.5', 'console_scripts', 'qvm-run')()
  File "/usr/lib/python3.5/site-packages/qubesadmin/tools/qvm_run.py", line 235, in main
    dispvm.cleanup()
  File "/usr/lib/python3.5/site-packages/qubesadmin/vm/__init__.py", line 376, in cleanup
    self.kill()
  File "/usr/lib/python3.5/site-packages/qubesadmin/vm/__init__.py", line 118, in kill
    self.qubesd_call(self._method_dest, 'admin.vm.Kill')
  File "/usr/lib/python3.5/site-packages/qubesadmin/base.py", line 69, in qubesd_call
    payload_stream)
  File "/usr/lib/python3.5/site-packages/qubesadmin/app.py", line 482, in qubesd_call
    return self._parse_qubesd_response(return_data)
  File "/usr/lib/python3.5/site-packages/qubesadmin/base.py", line 82, in _parse_qubesd_response
    'Got empty response from qubesd')
qubesadmin.exc.QubesDaemonNoResponseError: Got empty response from qubesd

No graceful handling of non-existing VMs:

qvm-run --dispvm foo xterm
Running 'xterm' on $dispvm:foo
$dispvm:foo: Got empty response from qubesd
Traceback (most recent call last):
  File "/usr/bin/qvm-run", line 9, in <module>
    load_entry_point('qubesadmin==4.0.5', 'console_scripts', 'qvm-run')()
  File "/usr/lib/python3.5/site-packages/qubesadmin/tools/qvm_run.py", line 235, in main
    dispvm.cleanup()
  File "/usr/lib/python3.5/site-packages/qubesadmin/vm/__init__.py", line 376, in cleanup
    self.kill()
  File "/usr/lib/python3.5/site-packages/qubesadmin/vm/__init__.py", line 118, in kill
    self.qubesd_call(self._method_dest, 'admin.vm.Kill')
  File "/usr/lib/python3.5/site-packages/qubesadmin/base.py", line 69, in qubesd_call
    payload_stream)
  File "/usr/lib/python3.5/site-packages/qubesadmin/app.py", line 482, in qubesd_call
    return self._parse_qubesd_response(return_data)
  File "/usr/lib/python3.5/site-packages/qubesadmin/base.py", line 82, in _parse_qubesd_response
    'Got empty response from qubesd')
qubesadmin.exc.QubesDaemonNoResponseError: Got empty response from qubesd
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Aug 12, 2017

Member

More details are in qubesd log. qvm-run intentionally do not know more details (see QubesOS/qubes-core-admin#113 (comment)). So, this is mostly about better error message here (and not printing traceback). What do you think about "Got empty response from qubesd. See journalctl in dom0 for details."?

Member

marmarek commented Aug 12, 2017

More details are in qubesd log. qvm-run intentionally do not know more details (see QubesOS/qubes-core-admin#113 (comment)). So, this is mostly about better error message here (and not printing traceback). What do you think about "Got empty response from qubesd. See journalctl in dom0 for details."?

@3hhh

This comment has been minimized.

Show comment
Hide comment
@3hhh

3hhh Aug 12, 2017

I see.

Yes, if it's in the journal, it would definitely make sense highlighting that in the error message.

3hhh commented Aug 12, 2017

I see.

Yes, if it's in the journal, it would definitely make sense highlighting that in the error message.

@andrewdavidwong andrewdavidwong added this to the Release 4.0 milestone Aug 13, 2017

@andrewdavidwong andrewdavidwong added task and removed bug labels Aug 13, 2017

marmarek added a commit to marmarek/qubes-core-admin-client that referenced this issue Aug 13, 2017

vm/dispvm: fix dispvm.cleanup() when no service was called
In such a case (especially when running in dom0) there is nothing to
cleanup.

Fixes QubesOS/qubes-issues#3016

marmarek added a commit to marmarek/qubes-core-admin-client that referenced this issue Aug 13, 2017

tests: add DispVM tests
Especially for one service call wrapper

QubesOS/qubes-issues#3016

marmarek added a commit to marmarek/qubes-core-admin-client that referenced this issue Aug 13, 2017

@marmarek marmarek referenced this issue in QubesOS/qubes-core-admin-client Aug 13, 2017

Merged

Tools fixes #25

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Sep 14, 2017

Automated announcement from builder-github

The package python2-qubesadmin-4.0.6-0.1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Automated announcement from builder-github

The package python2-qubesadmin-4.0.6-0.1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Sep 14, 2017

Closed

core-admin-client v4.0.6 (r4.0) #208

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Sep 14, 2017

Automated announcement from builder-github

The package python2-qubesadmin-4.0.6-0.1.fc24 has been pushed to the r4.0 testing repository for the Fedora fc24 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

Automated announcement from builder-github

The package python2-qubesadmin-4.0.6-0.1.fc24 has been pushed to the r4.0 testing repository for the Fedora fc24 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Sep 14, 2017

Automated announcement from builder-github

The package qubes-core-admin-client_4.0.6-1+deb8u1 has been pushed to the r4.0 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Automated announcement from builder-github

The package qubes-core-admin-client_4.0.6-1+deb8u1 has been pushed to the r4.0 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Sep 14, 2017

Automated announcement from builder-github

The package python2-qubesadmin-4.0.6-0.1.fc25 has been pushed to the r4.0 testing repository for the Fedora fc25 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

Automated announcement from builder-github

The package python2-qubesadmin-4.0.6-0.1.fc25 has been pushed to the r4.0 testing repository for the Fedora fc25 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Sep 14, 2017

Automated announcement from builder-github

The package qubes-core-admin-client_4.0.6-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian stretch template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Automated announcement from builder-github

The package qubes-core-admin-client_4.0.6-1+deb9u1 has been pushed to the r4.0 testing repository for the Debian stretch template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 30, 2017

Automated announcement from builder-github

The package qubes-core-admin-client_4.0.9-1+deb8u1 has been pushed to the r4.0 stable repository for the Debian jessie template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Automated announcement from builder-github

The package qubes-core-admin-client_4.0.9-1+deb8u1 has been pushed to the r4.0 stable repository for the Debian jessie template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 30, 2017

Automated announcement from builder-github

The package qubes-core-admin-client_4.0.9-1+deb9u1 has been pushed to the r4.0 stable repository for the Debian stretch template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Automated announcement from builder-github

The package qubes-core-admin-client_4.0.9-1+deb9u1 has been pushed to the r4.0 stable repository for the Debian stretch template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 30, 2017

Automated announcement from builder-github

The package python2-qubesadmin-4.0.9-0.1.fc24 has been pushed to the r4.0 stable repository for the Fedora fc24 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

Automated announcement from builder-github

The package python2-qubesadmin-4.0.9-0.1.fc24 has been pushed to the r4.0 stable repository for the Fedora fc24 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 30, 2017

Automated announcement from builder-github

The package python2-qubesadmin-4.0.9-0.1.fc25 has been pushed to the r4.0 stable repository for the Fedora fc25 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

Automated announcement from builder-github

The package python2-qubesadmin-4.0.9-0.1.fc25 has been pushed to the r4.0 stable repository for the Fedora fc25 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 30, 2017

Automated announcement from builder-github

The package python2-qubesadmin-4.0.9-0.1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Automated announcement from builder-github

The package python2-qubesadmin-4.0.9-0.1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment