New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-usb (dom0) uninformative error message -- R4.0-rc1 #3026

Open
0spinboson opened this Issue Aug 14, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@0spinboson

0spinboson commented Aug 14, 2017

Qubes OS version (e.g., R3.2):

R4.0 rc1

Affected TemplateVMs (e.g., fedora-23, if applicable):

dom0, fedora-25, debian-9


Expected behavior:

USB device is passed through to AppVM (in this case, a printer, usb 2.0 or 1.1)

Actual behavior:

Aug 14 17:34:04 dom0 qubes.USB+1-3-Writing[17651]: /bin/sh: /etc/qubes-rpc/qubes.USB: No such file or directory
Aug 14 17:34:04 dom0 qubesd[2195]: QubesUSBException('Device attach failed: Invalid speed received',) while calling src=b'dom0' meth=b'admin.vm.device.usb.Attach' dest=b'Writing' arg=b'dom0+1-3' len(untrusted_payload)=0
Aug 14 17:34:12 dom0 qrexec[17668]: qubes.USB+1-3: Writing -> dom0: allowed to dom0
Aug 14 17:34:12 dom0 qubes.USB+1-3-Writing[17685]: /bin/sh: /etc/qubes-rpc/qubes.USB: No such file or directory
Aug 14 17:34:12 dom0 qubesd[2195]: QubesUSBException('Device attach failed: Invalid speed received',) while calling src=b'dom0' meth=b'admin.vm.device.usb.Attach' dest=b'Writing' arg=b'dom0+1-3' len(untrusted_payload)=0

Steps to reproduce the behavior:

qvm-usb a name dom0:xx:yy

General notes:

Haven't gotten a USB Qube going yet, and can't test this on short notice.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Aug 14, 2017

Member

Currently qvm-usb do not support attaching devices from dom0. While technically it could be implemented, much better idea is to have USB Qube.
Of course, there should be meaningful error message, not the thing you've got.

Member

marmarek commented Aug 14, 2017

Currently qvm-usb do not support attaching devices from dom0. While technically it could be implemented, much better idea is to have USB Qube.
Of course, there should be meaningful error message, not the thing you've got.

@0spinboson

This comment has been minimized.

Show comment
Hide comment
@0spinboson

0spinboson Aug 14, 2017

Aha. Okay, I guess I'll have to set that up then. :)

Aha. Okay, I guess I'll have to set that up then. :)

@0spinboson

This comment has been minimized.

Show comment
Hide comment
@0spinboson

0spinboson Aug 14, 2017

ok, that's WAI. Also got some others related to device resets, will look into those more later (no time now).

0spinboson commented Aug 14, 2017

ok, that's WAI. Also got some others related to device resets, will look into those more later (no time now).

@0spinboson 0spinboson changed the title from qvm-usb not working properly in R4.0-rc1 to qvm-usb (dom0) uninformative error message -- R4.0-rc1 Aug 14, 2017

@andrewdavidwong andrewdavidwong added this to the Release 4.0 milestone Aug 15, 2017

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 20, 2017

Member

@rootkovska what should we do about this? There are two options:

  • improve error message about not supporting dom0 as "USB VM" (or even, not list USB devices in dom0)
  • add support for attaching USB device from dom0 (no separate USB VM)

The former should encourage usage of USB VM, but there are cases incompatible with USB VM - like booting from USB. And there, using qvm-usb to attach device to some VM could still be better than doing things directly in dom0. What do you think?

Member

marmarek commented Nov 20, 2017

@rootkovska what should we do about this? There are two options:

  • improve error message about not supporting dom0 as "USB VM" (or even, not list USB devices in dom0)
  • add support for attaching USB device from dom0 (no separate USB VM)

The former should encourage usage of USB VM, but there are cases incompatible with USB VM - like booting from USB. And there, using qvm-usb to attach device to some VM could still be better than doing things directly in dom0. What do you think?

marmarek added a commit to marmarek/qubes-app-linux-usb-proxy that referenced this issue Nov 20, 2017

Improve error message when backend fails to send device info
If connection fails early, frontend do not get any device information,
but it prints misleading message "Invalid speed received". The actual
cause may include:
 - unplugged device
 - qubes-usb-proxy not installed in the backend
 - unsupported device
 - ...

QubesOS/qubes-issues#3272
QubesOS/qubes-issues#3026
@0spinboson

This comment has been minimized.

Show comment
Hide comment
@0spinboson

0spinboson Nov 20, 2017

are there also PCs/laptops with only a single USB controller? If not, I'd say 1 is the better option (even if it's probably too much to ask from most people to figure out which controller controls which ports, then only using the dom0 ports for the USB HDD while assigning the other(s) to a USB VM).

are there also PCs/laptops with only a single USB controller? If not, I'd say 1 is the better option (even if it's probably too much to ask from most people to figure out which controller controls which ports, then only using the dom0 ports for the USB HDD while assigning the other(s) to a USB VM).

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 20, 2017

Member

Unfortunately there are a lot of systems with a single USB controller. Most of new Intel-based ones.

Member

marmarek commented Nov 20, 2017

Unfortunately there are a lot of systems with a single USB controller. Most of new Intel-based ones.

@rootkovska

This comment has been minimized.

Show comment
Hide comment
@rootkovska

rootkovska Nov 21, 2017

Member

I'm voting against making it easy to keep any USB devices in dom0. I don't think LiveUSB booting justifies this.

Member

rootkovska commented Nov 21, 2017

I'm voting against making it easy to keep any USB devices in dom0. I don't think LiveUSB booting justifies this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment