New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0 - Feature Reqest: '--skip-if-halted' for 'qvm-shutdown' #3032

Open
r-cheologist opened this Issue Aug 16, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@r-cheologist

Qubes OS version (e.g., R3.2):

4.0-rc1

Affected TemplateVMs (e.g., fedora-23, if applicable):

dom0


Expected behavior:

Analogous to the capabilities of 'qvm-start' ('--skip-if-running'), 'qvm-shutdown' is expected to have the option '--skip-if-halted'.

Actual behavior:

Not implemented.

@kalkin

This comment has been minimized.

Show comment
Hide comment
@kalkin

kalkin Aug 16, 2017

Member

Why do we have --skip-if-running at all? I would expect both just to exit with 0 if the VM is already started or shutdown.

Member

kalkin commented Aug 16, 2017

Why do we have --skip-if-running at all? I would expect both just to exit with 0 if the VM is already started or shutdown.

@r-cheologist

This comment has been minimized.

Show comment
Hide comment
@r-cheologist

r-cheologist Aug 16, 2017

@r-cheologist

This comment has been minimized.

Show comment
Hide comment
@r-cheologist

r-cheologist Aug 17, 2017

I agree with @kalkin above, that not having any skipping option at all and just exiting if a vm already exists would be the preferable option for both qvm-start and qvm-shutdown ... the current error throwing behavior could be retained with an option like --must-work ...

I agree with @kalkin above, that not having any skipping option at all and just exiting if a vm already exists would be the preferable option for both qvm-start and qvm-shutdown ... the current error throwing behavior could be retained with an option like --must-work ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment