/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename `dispvm_allowed` property #3047

Closed
rootkovska opened this Issue Aug 23, 2017 · 3 comments

Comments

Assignees

@marmarek marmarek

@woju woju

Labels
Projects
None yet
Milestone
  Release 4.0
4 participants
@rootkovska @qubesos-bot @marmarek @woju
@rootkovska
Member

rootkovska commented Aug 23, 2017

Current name is confusing enough that lots of users might interpret it as "allow this VM to request DispVMs creation", while, in fact, it means: "allow this VM to become a template for DispVMs (perhaps started by other VMs".

@rootkovska rootkovska added bug C: core P: major labels Aug 23, 2017

@rootkovska rootkovska added this to the Release 4.0 milestone Aug 23, 2017

@rootkovska rootkovska assigned marmarek and woju Aug 23, 2017

@rootkovska

This comment has been minimized.

Show comment
Hide comment
@rootkovska

rootkovska Aug 23, 2017

Member

Suggested new name: template_for_dispvms
Member

rootkovska commented Aug 23, 2017

Suggested new name: template_for_dispvms

@woju woju referenced this issue Aug 23, 2017

Closed

Improve qrexec policy syntax for $dispvm to be more expressive and less confusing #3048

marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Sep 4, 2017

@marmarek
Rename 'dispvm_allowed' to 'template_for_dispvms' 
'dispvm_allowed' name was confusing, because it suggested being able to
spawn new DispVMs, not being a template for DispVM.

Fixes QubesOS/qubes-issues#3047
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
6e95e0c

marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Sep 5, 2017

@marmarek
Rename 'dispvm_allowed' to 'template_for_dispvms' 
'dispvm_allowed' name was confusing, because it suggested being able to
spawn new DispVMs, not being a template for DispVM.

Fixes QubesOS/qubes-issues#3047
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
99bd193

@marmarek marmarek referenced this issue in QubesOS/qubes-core-admin Sep 5, 2017

Merged

Policy related changed for DispVM #148

@marmarek marmarek closed this in QubesOS/qubes-core-admin#148 Sep 13, 2017

marmarek added a commit to marmarek/qubes-mgmt-salt-dom0-qvm that referenced this issue Sep 14, 2017

@marmarek
Rename 'dispvm-allowed' to 'template-for-dispvms' 
But still accept both names, so old formulas will still work.

QubesOS/qubes-issues#3047
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
e9ae760

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Sep 14, 2017

Closed

mgmt-salt-dom0-qvm v4.0.3 (r4.0) #203

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Sep 14, 2017

Automated announcement from builder-github

The package qubes-core-dom0-4.0.7-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

qubesos-bot commented Sep 14, 2017

Automated announcement from builder-github

The package qubes-core-dom0-4.0.7-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot added the r4.0-dom0-cur-test label Sep 14, 2017

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Sep 14, 2017

Closed

core-admin v4.0.7 (r4.0) #204

marmarek added a commit to marmarek/qubes-core-admin-client that referenced this issue Oct 16, 2017

@marmarek
backup: update DispVM template property: template_for_dispvms 
It was renamed from 'dispvm_allowed'.

QubesOS/qubes-issues#3047
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
90002b9

marmarek added a commit to marmarek/qubes-core-admin-client that referenced this issue Oct 16, 2017

@marmarek
backup: update DispVM template property: template_for_dispvms 
It was renamed from 'dispvm_allowed'.

QubesOS/qubes-issues#3047
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
d1eab2d

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Oct 16, 2017

Closed

core-admin-client v4.0.8 (r4.0) #272

fepitre added a commit to fepitre/qubes-core-admin-client that referenced this issue Oct 16, 2017

@marmarek @fepitre
backup: update DispVM template property: template_for_dispvms 
It was renamed from 'dispvm_allowed'.

QubesOS/qubes-issues#3047
Verified
This commit was signed with a verified signature.
@fepitre fepitre Frédéric Pierret
GPG key ID: 1DABC232BE02201E Learn about signing commits
29b0a52
@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Oct 30, 2017

Automated announcement from builder-github

The package qubes-core-dom0-4.0.11-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

qubesos-bot commented Oct 30, 2017

Automated announcement from builder-github

The package qubes-core-dom0-4.0.11-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@qubesos-bot qubesos-bot added r4.0-dom0-stable and removed r4.0-dom0-cur-test labels Oct 30, 2017

@zander zander referenced this issue Nov 27, 2017

Closed

qvm-create --class DispVM throws exception in qubesd #3341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment