New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in qvm-block docs #3088

Closed
starius opened this Issue Sep 10, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@starius

starius commented Sep 10, 2017

The page says:

qvm-block - list/set VM PCI devices.

Probably it should be "list/set VM block devices."

@andrewdavidwong andrewdavidwong added this to the Documentation/website milestone Sep 10, 2017

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Sep 10, 2017

Member

@marmarek: I was going to fix this, but it looks like the qvm-block man/help source file has been moved (or disappeared). Where does it live now?

Member

andrewdavidwong commented Sep 10, 2017

@marmarek: I was going to fix this, but it looks like the qvm-block man/help source file has been moved (or disappeared). Where does it live now?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Sep 10, 2017

Member

For Qubes 4.0 it's moved here: https://github.com/QubesOS/qubes-core-admin-client/tree/master/doc/manpages (qvm-device, a generic tool used as qvm-pci, qvm-block, qvm-usb).
For 3.2, it's still where it was, check release3.2 branch.

Member

marmarek commented Sep 10, 2017

For Qubes 4.0 it's moved here: https://github.com/QubesOS/qubes-core-admin-client/tree/master/doc/manpages (qvm-device, a generic tool used as qvm-pci, qvm-block, qvm-usb).
For 3.2, it's still where it was, check release3.2 branch.

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Sep 11, 2017

Member

For 3.2, it looks like it already says "List/set VM block devices.":
https://github.com/QubesOS/qubes-core-admin/blob/release3.2/qvm-tools/qvm-block#L38

Maybe the website page hasn't been synced?

For 4.0, it looks like this won't be relevant.

Member

andrewdavidwong commented Sep 11, 2017

For 3.2, it looks like it already says "List/set VM block devices.":
https://github.com/QubesOS/qubes-core-admin/blob/release3.2/qvm-tools/qvm-block#L38

Maybe the website page hasn't been synced?

For 4.0, it looks like this won't be relevant.

andrewdavidwong added a commit to andrewdavidwong/qubes-core-admin that referenced this issue Mar 18, 2018

@andrewdavidwong andrewdavidwong self-assigned this Mar 18, 2018

andrewdavidwong added a commit to QubesOS/qubes-doc that referenced this issue Mar 18, 2018

marmarek added a commit to QubesOS/qubesos.github.io that referenced this issue Mar 18, 2018

autoupdate: _doc
_doc:
    gpg: Good signature from "Andrew David Wong (Qubes Documentation Signing Key)" [ultimate]
    object aff2eb53c3a4d76366323d91360dfad0770afd1b
    type commit
    tag adw_aff2eb53
    tagger Andrew David Wong <adw@andrewdavidwong.com> 1521402475 -0500

    Tag for commit aff2eb53c3a4d76366323d91360dfad0770afd1b

    aff2eb5 Fix typo (QubesOS/qubes-issues#3088)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment