New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkManager applet enabled in Whonix VMs #3094

Closed
marmarek opened this Issue Sep 15, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@marmarek
Member

marmarek commented Sep 15, 2017

Qubes OS version (e.g., R3.2):

4.0

Affected TemplateVMs (e.g., fedora-23, if applicable):

whonix-gw, whonix-ws


Expected behavior:

NetworkManager applet hidden.

Actual behavior:

NetworkManager applet visible, but unusable (NetworkManager service not running).

Steps to reproduce the behavior:

Install default configuration of Whonix VMs, either choose so during installation, or later:

sudo qubesctl state.sls qvm.sys-whonix

General notes:

Normally NetworkManager applet is hidden when NetworkManager itself is disabled. This is done by /usr/lib/qubes/show-hide-nm-applet.sh script, which is part of qubes-core-agent-network-manager. This package is not installed in Whonix VMs.

Possible solutions:

  1. Include qubes-core-agent-network-manager package (it does not pull any more dependencies).
  2. Do not install network-manager-gnome package (currently qubes-whonix-shared-packages-recommended depends on it). And maybe the same about network-manger.
  3. Ship a script similar to /usr/lib/qubes/show-hide-nm-applet.sh in some Whonix-specific package. Or maybe not a script, but a static file defining default value for org.gnome.nm-applet show-applet gsetting.

Option 1 is the easiest one. Option 2 IMO is cleaner (unless there is some usage of NetworkManager in Qubes-Whonix).

Cc: @adrelanos


Related issues:

#2954
#1954

@marmarek marmarek added this to the Release 4.0 milestone Sep 15, 2017

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Sep 15, 2017

Member
Member

adrelanos commented Sep 15, 2017

marmarek added a commit to marmarek/qubes-whonix that referenced this issue Sep 15, 2017

@marmarek marmarek referenced this issue in Whonix/qubes-whonix Sep 15, 2017

Merged

Drop dependency on network-manager* #6

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Sep 15, 2017

Member
  1. Include qubes-core-agent-network-manager package (it does not pull any more dependencies).

Sounds good. We should install that by default in Qubes-Whonix anyhow.
Beginning from Whonix 14. Any reason against it?

Disk space(*), memory usage. Is NetworkManager used in Whonix 14?

  • There is no dependency on network-manager / network-manager-gnome in Qubes-Whonix 14 development version. However, I wonder why it's installed there then.

Try to remove and see what depends on it...

  • We can consider this a Whonix 13 bug. - Shall I do a qubes-whonix 13 package stable upgrade to get rid of it?

Since NetworkManager service is disabled anyway, I think yes. Just drop the dependency (should not remove the package for existing users, so risk is low). Whonix/qubes-whonix#6

(*) For example current development built of Qubes 4.0 installation image is 100MB too big for DVD...

Member

marmarek commented Sep 15, 2017

  1. Include qubes-core-agent-network-manager package (it does not pull any more dependencies).

Sounds good. We should install that by default in Qubes-Whonix anyhow.
Beginning from Whonix 14. Any reason against it?

Disk space(*), memory usage. Is NetworkManager used in Whonix 14?

  • There is no dependency on network-manager / network-manager-gnome in Qubes-Whonix 14 development version. However, I wonder why it's installed there then.

Try to remove and see what depends on it...

  • We can consider this a Whonix 13 bug. - Shall I do a qubes-whonix 13 package stable upgrade to get rid of it?

Since NetworkManager service is disabled anyway, I think yes. Just drop the dependency (should not remove the package for existing users, so risk is low). Whonix/qubes-whonix#6

(*) For example current development built of Qubes 4.0 installation image is 100MB too big for DVD...

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Sep 15, 2017

Member
Member

adrelanos commented Sep 15, 2017

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Oct 19, 2017

Member

Anything left to do here?

I don't see this happening.

Member

adrelanos commented Oct 19, 2017

Anything left to do here?

I don't see this happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment