New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-prefs doesn't recognize `$adminvm` keyword #3101

Closed
rootkovska opened this Issue Sep 20, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@rootkovska
Member

rootkovska commented Sep 20, 2017

We want to be able to write (to maintain consistency with qrexec policy)

qvm-prefs \$adminvm

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Sep 20, 2017

Member

No, qvm-prefs do not support $ keywords $adminvm is a keyword used to match AdminVM, not a VM name. Keywords exist only in qrexec policy.
Also, I don't want to support complex code for handling qvm-prefs $tag:xxx (I bet that would be the next expectation, "to maintain consistency with qrexec policy").

Member

marmarek commented Sep 20, 2017

No, qvm-prefs do not support $ keywords $adminvm is a keyword used to match AdminVM, not a VM name. Keywords exist only in qrexec policy.
Also, I don't want to support complex code for handling qvm-prefs $tag:xxx (I bet that would be the next expectation, "to maintain consistency with qrexec policy").

@marmarek marmarek closed this Sep 20, 2017

@rootkovska

This comment has been minimized.

Show comment
Hide comment
@rootkovska

rootkovska Sep 20, 2017

Member

I don't agree with your argumentation. If $adminvm could be specified as a valid destination (and well defined) for qrexec-agent, then consistency demands it should also be a valid "destination" for qvm-prefs.

Member

rootkovska commented Sep 20, 2017

I don't agree with your argumentation. If $adminvm could be specified as a valid destination (and well defined) for qrexec-agent, then consistency demands it should also be a valid "destination" for qvm-prefs.

@rootkovska rootkovska reopened this Sep 20, 2017

@rootkovska

This comment has been minimized.

Show comment
Hide comment
@rootkovska

rootkovska Sep 20, 2017

Member

Otherwise users would be confused why the same entity is named differently in two cases, and would tend to use the name which works in both contexts, effectively not using the (preferred) $adminvm.

Member

rootkovska commented Sep 20, 2017

Otherwise users would be confused why the same entity is named differently in two cases, and would tend to use the name which works in both contexts, effectively not using the (preferred) $adminvm.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Sep 20, 2017

Member

No, the argument in qvm-prefs is a VM name, not any qrexec target. For example it doesn't make sense to use qvm-prefs $dispvm. VM names can be for example listed by qvm-ls. Having to use $adminvm when VM is actually named dom0 (as listed by qvm-ls and all other tools) would be much more confusing.
Also, much less users will ever modify qrexec policy, than use qvm tools. So many will not even know from where that $adminvm came.

Also, VM name cannot contain "$". There is no exception. This is why it is a character used for keywords in qrexec syntax. So, "$adminvm" is not a name of VM (and we shouldn't rename it as such).

Member

marmarek commented Sep 20, 2017

No, the argument in qvm-prefs is a VM name, not any qrexec target. For example it doesn't make sense to use qvm-prefs $dispvm. VM names can be for example listed by qvm-ls. Having to use $adminvm when VM is actually named dom0 (as listed by qvm-ls and all other tools) would be much more confusing.
Also, much less users will ever modify qrexec policy, than use qvm tools. So many will not even know from where that $adminvm came.

Also, VM name cannot contain "$". There is no exception. This is why it is a character used for keywords in qrexec syntax. So, "$adminvm" is not a name of VM (and we shouldn't rename it as such).

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Sep 20, 2017

Member

There is also practical issue: it's much simpler to make a mistake using qvm-prefs $adminvm from shell (note lack of \), than qvm-prefs dom0. This problem does not apply to qrexec policy file.

Member

marmarek commented Sep 20, 2017

There is also practical issue: it's much simpler to make a mistake using qvm-prefs $adminvm from shell (note lack of \), than qvm-prefs dom0. This problem does not apply to qrexec policy file.

@marmarek marmarek closed this Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment